[Bug 32922] New: Remove space in shebang
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Bug ID: 32922 Summary: Remove space in shebang Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org Some of our scripts have a space in the shebang: $ grep -rn --include=*.pl '#! /usr/' * admin/library_groups.pl:1:#! /usr/bin/perl admin/credit_types.pl:1:#! /usr/bin/perl admin/debit_types.pl:1:#! /usr/bin/perl admin/curbside_pickup.pl:1:#! /usr/bin/perl admin/desks.pl:1:#! /usr/bin/perl admin/cities.pl:1:#! /usr/bin/perl admin/classsources.pl:1:#! /usr/bin/perl admin/matching-rules.pl:1:#! /usr/bin/perl admin/background_jobs.pl:1:#! /usr/bin/perl admin/patron-attr-types.pl:1:#! /usr/bin/perl circ/curbside_pickups.pl:1:#! /usr/bin/perl erm/erm.pl:1:#! /usr/bin/perl misc/cronjobs/delete_items.pl:1:#! /usr/bin/perl misc/maintenance/check_syspref_cache.pl:1:#! /usr/bin/perl misc/maintenance/compare_es_to_db.pl:1:#! /usr/bin/perl misc/add_statistics_borrowers_categorycode.pl:1:#! /usr/bin/perl It looks like this is not illegal (see e.g. https://unix.stackexchange.com/questions/276751/is-space-allowed-between-and...) but it has been argued that we should be consistent (bug 26658) so we might want to fix this. Unless there is some reason for it that I am not aware of? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 146416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146416&action=edit Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146416|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 146417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146417&action=edit Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146417|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146419&action=edit Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146419|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146498&action=edit Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146499&action=edit Bug 32922: (follow-up) Fix two additional occurences Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oops.. just spotted this was SO'd by Matt.. but I've gone through a QA process on it already. All working nicely and is a good general consistency improvement. Passing QA.. Tomas, feel free to push back for an independent QA if you want it . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- Created attachment 147193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147193&action=edit Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147193|0 |1 is obsolete| | --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Comment on attachment 147193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147193 Bug 29449: Show userid on "Personal details" tab Wrong bug, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32922 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Does not apply to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org