[Bug 41561] New: "tab" variable in admin/aqbudgetperiods.pl, tt is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Bug ID: 41561 Summary: "tab" variable in admin/aqbudgetperiods.pl,tt is not used and should be removed Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 8117 admin/aqbudgetperiods.pl my $tab = $input->param('tab') ? $input->param('tab') - 1 : 0; This is never used. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 [Bug 8117] Divide budget periods into two tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191061&action=edit Bug 41561: Remove 'tab' from admin/aqbudgetperiods commit 4b312b141ab2dddfac5da1034338a1634cb504e4 CommitDate: Wed Sep 19 16:17:16 2012 +0200 Bug 8117: Divide budget periods into two tabs It was used at the time +$url = "aqbudgetperiods.pl?tab=2"; But this has been removed by commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0 Date: Mon Mar 21 09:32:39 2016 -0400 Bug 13464 - Standardize the pagination class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13464 [Bug 13464] Standardize the pagination class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41564 [Bug 41564] Tidy kohaTable block - admin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191061|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191870&action=edit Bug 41561: Remove 'tab' from admin/aqbudgetperiods commit 4b312b141ab2dddfac5da1034338a1634cb504e4 CommitDate: Wed Sep 19 16:17:16 2012 +0200 Bug 8117: Divide budget periods into two tabs It was used at the time +$url = "aqbudgetperiods.pl?tab=2"; But this has been removed by commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0 Date: Mon Mar 21 09:32:39 2016 -0400 Bug 13464 - Standardize the pagination class Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191870|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 191915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191915&action=edit Bug 41561: Remove 'tab' from admin/aqbudgetperiods commit 4b312b141ab2dddfac5da1034338a1634cb504e4 CommitDate: Wed Sep 19 16:17:16 2012 +0200 Bug 8117: Divide budget periods into two tabs It was used at the time +$url = "aqbudgetperiods.pl?tab=2"; But this has been removed by commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0 Date: Mon Mar 21 09:32:39 2016 -0400 Bug 13464 - Standardize the pagination class Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41561 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is minor, lets not backport to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org