[Bug 38436] New: Unable to hide a column in the holdings table in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Bug ID: 38436 Summary: Unable to hide a column in the holdings table in the staff interface Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the holdings table in the staff interface, if a column has a value, it is show regardless of the table settings. I think this is a regression from previous behaviour. I tested it on 23.05 and 24.05 and the table settings are taken into account and hide the undesired column. A use case example is for single-library system who want to simplify/shorten the holdings table, they might choose to hide the holding library column as it's always going to be the same as the home library. Having those two columns only doubles the information uselessly for them. To recreate : 1. View a record in the staff interface 2. In another tab, go to Administration > Table settings > Catalog > holdings_table and check 'is hidden by default' for holdings_holdingbranch 3. Go back to the tab with the record and refresh the page --> The 'Current library' column is still there -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- It was an illusion. It could have worked in simple situation, but say you have: https://snipboard.io/TpDSZ2.jpg I don't think it could work with the code I have in front of my eyes... To be confirmed however. I am tempted to suggest a proper fix instead of a hack but 24.11 is quite close now :-/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Needs to be confirmed however, I am currently trapped between main (which has several DT changes already) and bug 36640. I am trying to work on top of those ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38433 Status|NEW |CONFIRMED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Pfiou, tricky one here! So keep in mind that we have "Save state" (bug 33484) AND "DataTables upgrade" (bug 36640) that happened in main. We are now on top of that, and things are tricky. I really feel like the previous versions were buggy. They may have kind of worked, but they were not fully working (regarding the different possible configurations). I will be back on Monday, but if you some of you want to test, there is a remote branch on my gitlab repo: bug_38436 You can test the patron search and the items table. There are still some work to do: * Adjust the column names in DB * Adjust the other tables using bKohaColumnsUseNames * Adjust KohaTable code (in columns_settings.inc) I will continue next week but it would be great to know if the expected behaviour is the one from this branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Switched to "Needs Signoff" but it's not ready for inclusion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 38433 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 38456 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174587&action=edit Bug 38436: Do not try to build the table if tab is not there If we don't have the "other holdings" tab, no need to try to build the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174588&action=edit Bug 38436: Store bKohaColumnsUseNames in data instead of DT's settings DataTable's settings do no longer allow to store custom properties. Here we are passing bKohaColumnsUseNames to the constructor, but we cannot retrieve it later from DT's api. We need to store it in data(). Test plan: 0. Do not apply this patch 1. In _dt_visibility add console.log(settings.bKohaColumnsUseNames); where relevant 2. Open your browser, clear localStorage entries (we want to reach the set_default() code) 3. Hit http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that the value is true then false (displayed once per columns). This is because we are calling _dt_visibility twice: * with the 'settings' we passed to the constructor: 1044 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, this) * from set_default() where we pass the settings retrieved from DT's api 900 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, $("#"+settings.nTable.id)); 4. Apply this patch, console.log again and confirm that it's now true. Notice that everything is then buggy... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174589&action=edit Bug 38436: Store loaded_from_state in data instead of DT's settings This has been introduced by bug 33484 as we needed to know if the state was loaded (from URL or localStorage). If the state is loaded then we need to: 1. not redirect if only one patron to display (to prevent a blocking situation) 2. display the table (ie. not defer loading) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174590&action=edit Bug 38436: Adjust column names for the holdings tables Removing the prefix holdings_ and otherholdings_ Could have been done at the code level but does not seem necessary to have different column names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174591&action=edit Bug 38436: Rename columns_settings.columnname in DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174592&action=edit Bug 38436: Fix column visibility when bKohaColumnsUseNames is used When the columns displayed in the table can vary (depending on sysprefs) we use bKohaColumnsUseNames. This allows us to use the name of the columns instead of there order number. The code was totally wrong, and didn't retrieve the correct number. A good example to confirm that is to add: console.log("%s is at %s".format(this.columnname, used_id)); at the end of the `if ( use_names ) {` block of _dt_visibility. If at least one column is hidden by default and cannot be toggled (and so won't appear in the list of the columns of the "Column visibility" button), there will be a shift. This line was definitelly wrong: var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); We cannot rely on the order of the visible columns, we need to retrieve the list of the columns using DT's api. Now the columns are retrieved using their class names, and from DT's api. The code is way nicer and more inline with how we are supposed to play with DT. Look at those 2 lines to pass the list of columns to the colvis button: let included_columns = table_settings.columns.filter(c => !c.cannot_be_toggled); columns: included_columns.map(c => '.' + c.columnname).join(',') Test plan: Play intensively with the items table (detail.pl), but also with the other tables not using bKohaColumnsUseNames (eg. patrons search) You need to set column as hidden by default and/or cannot be toggled. You need to play with the "Columns" button. Note that you need to remove the localStorage keys starting with 'DataTables_' to retrieve the visibility settings from what is defined in the admin area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174593&action=edit Bug 38436: Adjust columns_settings.inc for KohaTable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174594&action=edit Bug 38436: Restore hide columns when empty If a column has no data on the items table we should hide the column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174595&action=edit Bug 38436: Do not hide all if none to hide -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38391 [Bug 38391] DT's add filters called too many times -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Status|Needs Signoff |Failed QA --- Comment #16 from Philip Orr <philip.orr@lmscloud.de> --- I tested on ktd. The holdings table on detail.pl does indeed behave as expected with this patch. However the "Columns" button in the table of patron results in patron search now no longer works, the screen is grayed out as if the menu was open, but there is no menu after clicking on "Columns". (I first searched for some patrons and when the table of results was shown I clicked on "Columns"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #17 from Philip Orr <philip.orr@lmscloud.de> --- (also qa says: ´´´ WARN installer/data/mysql/atomicupdate/bug_38436.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) ´´´) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174634&action=edit Bug 38436: Fix visibility when bKohaColumnsUseNames is not set Typically the patrons search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Philip Orr from comment #16)
I tested on ktd.
Thanks for testing!
The holdings table on detail.pl does indeed behave as expected with this patch.
Great!
However the "Columns" button in the table of patron results in patron search now no longer works, the screen is grayed out as if the menu was open, but there is no menu after clicking on "Columns".
Oops, yes. I was too focused on the items table and its particularities it seems. (In reply to Philip Orr from comment #17)
(also qa says: ´´´ WARN installer/data/mysql/atomicupdate/bug_38436.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) ´´´)
Can be ignored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174641&action=edit Bug 38436: Adjust Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174642&action=edit Bug 38436: Do not deal with 'Columns' button if no table settings If the table does not have table settings we should not deal with the column visibility and not display the 'Columns' button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Don't know whether this is related to these patches: /cgi-bin/koha/admin/columns_settings.pl?module=catalogue&page=detail&table=holdings_table Uncaught Error: Syntax error, unrecognized expression: #detail|holdings_table -- You are receiving this mail because: You are watching all bug changes.
I tested on ktd. The holdings table on detail.pl does indeed behave as expected with this patch. However the "Columns" button in the table of patron results in patron search now no longer works, the screen is grayed out as if the menu was open, but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Also unsure whether this is local but I experience this: there is no menu after clicking on "Columns". (I first searched for some patrons and when the table of results was shown I clicked on "Columns"). But the other way around. The columns button in detail.pl yields a backdrop with no options. The patron search does behave as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #22)
Don't know whether this is related to these patches:
/cgi-bin/koha/admin/columns_settings. pl?module=catalogue&page=detail&table=holdings_table
Uncaught Error: Syntax error, unrecognized expression: #detail|holdings_table
Attached a follow-up on bug 38069. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174688&action=edit Bug 38436: (follow-up) Adjust columns_settings.inc for KohaTable Previous commit didn't adjust columns_settings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174634|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174689&action=edit Bug 38436: Fix visibility when bKohaColumnsUseNames is not set Previous commit didn't adjust columns_settings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174690&action=edit Bug 38436: Fix patron categories Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs. Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38472 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #27)
Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead.
Opened bug 38472. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174691&action=edit Bug 38436: (follow-up) Fix visibility when bKohaColumnsUseNames is not set Previous commit didn't adjust columns_settings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174690|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174692&action=edit Bug 38436: Fix patron categories Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs. Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174593|0 |1 is obsolete| | Attachment #174594|0 |1 is obsolete| | Attachment #174595|0 |1 is obsolete| | Attachment #174641|0 |1 is obsolete| | Attachment #174642|0 |1 is obsolete| | Attachment #174688|0 |1 is obsolete| | Attachment #174689|0 |1 is obsolete| | Attachment #174691|0 |1 is obsolete| | Attachment #174692|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174693&action=edit Bug 38436: Adjust columns_settings.inc for KohaTable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174694&action=edit Bug 38436: Restore hide columns when empty If a column has no data on the items table we should hide the column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174695&action=edit Bug 38436: Do not hide all if none to hide -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174696&action=edit Bug 38436: Fix visibility when bKohaColumnsUseNames is not set Typically the patrons search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174697&action=edit Bug 38436: Adjust Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174698&action=edit Bug 38436: Do not deal with 'Columns' button if no table settings If the table does not have table settings we should not deal with the column visibility and not display the 'Columns' button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174699&action=edit Bug 38069: (follow-up) Fix jump to the correct table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174700&action=edit Bug 38436: (follow-up) Adjust columns_settings.inc for KohaTable Previous commit didn't adjust columns_settings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174701&action=edit Bug 38436: (follow-up) Fix visibility when bKohaColumnsUseNames is not set Previous commit didn't adjust columns_settings.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174702&action=edit Bug 38436: Fix patron categories Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs. Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #40)
Created attachment 174702 [details] [review] Bug 38436: Fix patron categories
Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs.
This is an important one to keep in mind as I am pretty sure there are others in the wild. If the column list is empty it means that the number of columns defined in the settings is not the same as the one in the table. In that case we MUST use bKohaColumnsUseNames and make adjustement to the th, but maybe also to the config (which is actually a bug as we are supposed to keep them in sync). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Where are we at here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #43 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Working on it, testing this is a bit of work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174587|0 |1 is obsolete| | Attachment #174588|0 |1 is obsolete| | Attachment #174589|0 |1 is obsolete| | Attachment #174590|0 |1 is obsolete| | Attachment #174591|0 |1 is obsolete| | Attachment #174592|0 |1 is obsolete| | Attachment #174693|0 |1 is obsolete| | Attachment #174694|0 |1 is obsolete| | Attachment #174695|0 |1 is obsolete| | Attachment #174696|0 |1 is obsolete| | Attachment #174697|0 |1 is obsolete| | Attachment #174698|0 |1 is obsolete| | Attachment #174699|0 |1 is obsolete| | Attachment #174700|0 |1 is obsolete| | Attachment #174701|0 |1 is obsolete| | Attachment #174702|0 |1 is obsolete| | --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174721&action=edit Bug 38436: Do not try to build the table if tab is not there If we don't have the "other holdings" tab, no need to try to build the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174722&action=edit Bug 38436: Store bKohaColumnsUseNames in data instead of DT's settings DataTable's settings do no longer allow to store custom properties. Here we are passing bKohaColumnsUseNames to the constructor, but we cannot retrieve it later from DT's api. We need to store it in data(). Test plan: 0. Do not apply this patch 1. In _dt_visibility add console.log(settings.bKohaColumnsUseNames); where relevant 2. Open your browser, clear localStorage entries (we want to reach the set_default() code) 3. Hit http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that the value is true then false (displayed once per columns). This is because we are calling _dt_visibility twice: * with the 'settings' we passed to the constructor: 1044 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, this) * from set_default() where we pass the settings retrieved from DT's api 900 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, $("#"+settings.nTable.id)); 4. Apply this patch, console.log again and confirm that it's now true. Notice that everything is then buggy... Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174723&action=edit Bug 38436: Store loaded_from_state in data instead of DT's settings This has been introduced by bug 33484 as we needed to know if the state was loaded (from URL or localStorage). If the state is loaded then we need to: 1. not redirect if only one patron to display (to prevent a blocking situation) 2. display the table (ie. not defer loading) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174724&action=edit Bug 38436: Adjust column names for the holdings tables Removing the prefix holdings_ and otherholdings_ Could have been done at the code level but does not seem necessary to have different column names Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174725&action=edit Bug 38436: Rename columns_settings.columnname in DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #49 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174726&action=edit Bug 38436: Fix column visibility when bKohaColumnsUseNames is used When the columns displayed in the table can vary (depending on sysprefs) we use bKohaColumnsUseNames. This allows us to use the name of the columns instead of there order number. The code was totally wrong, and didn't retrieve the correct number. A good example to confirm that is to add: console.log("%s is at %s".format(this.columnname, used_id)); at the end of the `if ( use_names ) {` block of _dt_visibility. If at least one column is hidden by default and cannot be toggled (and so won't appear in the list of the columns of the "Column visibility" button), there will be a shift. This line was definitelly wrong: var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); We cannot rely on the order of the visible columns, we need to retrieve the list of the columns using DT's api. Now the columns are retrieved using their class names, and from DT's api. The code is way nicer and more inline with how we are supposed to play with DT. Look at those 2 lines to pass the list of columns to the colvis button: let included_columns = table_settings.columns.filter(c => !c.cannot_be_toggled); columns: included_columns.map(c => '.' + c.columnname).join(',') Test plan: Play intensively with the items table (detail.pl), but also with the other tables not using bKohaColumnsUseNames (eg. patrons search) You need to set column as hidden by default and/or cannot be toggled. You need to play with the "Columns" button. Note that you need to remove the localStorage keys starting with 'DataTables_' to retrieve the visibility settings from what is defined in the admin area. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174727&action=edit Bug 38436: Adjust columns_settings.inc for KohaTable Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174728&action=edit Bug 38436: Restore hide columns when empty If a column has no data on the items table we should hide the column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174729&action=edit Bug 38436: Do not hide all if none to hide Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174730&action=edit Bug 38436: Fix visibility when bKohaColumnsUseNames is not set Typically the patrons search. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174731&action=edit Bug 38436: Adjust Vue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174732&action=edit Bug 38436: Do not deal with 'Columns' button if no table settings If the table does not have table settings we should not deal with the column visibility and not display the 'Columns' button. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174733&action=edit Bug 38069: (follow-up) Fix jump to the correct table https://bugs.koha-community.org/show_bug.cgi?id=38436 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174734&action=edit Bug 38436: (follow-up) Adjust columns_settings.inc for KohaTable Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174735&action=edit Bug 38436: (follow-up) Fix visibility when bKohaColumnsUseNames is not set Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #59 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174736&action=edit Bug 38436: Fix patron categories Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs. Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174721|0 |1 is obsolete| | --- Comment #60 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174740&action=edit Bug 38436: Do not try to build the table if tab is not there If we don't have the "other holdings" tab, no need to try to build the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174722|0 |1 is obsolete| | --- Comment #61 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174741&action=edit Bug 38436: Store bKohaColumnsUseNames in data instead of DT's settings DataTable's settings do no longer allow to store custom properties. Here we are passing bKohaColumnsUseNames to the constructor, but we cannot retrieve it later from DT's api. We need to store it in data(). Test plan: 0. Do not apply this patch 1. In _dt_visibility add console.log(settings.bKohaColumnsUseNames); where relevant 2. Open your browser, clear localStorage entries (we want to reach the set_default() code) 3. Hit http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that the value is true then false (displayed once per columns). This is because we are calling _dt_visibility twice: * with the 'settings' we passed to the constructor: 1044 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, this) * from set_default() where we pass the settings retrieved from DT's api 900 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, $("#"+settings.nTable.id)); 4. Apply this patch, console.log again and confirm that it's now true. Notice that everything is then buggy... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174723|0 |1 is obsolete| | --- Comment #62 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174742&action=edit Bug 38436: Store loaded_from_state in data instead of DT's settings This has been introduced by bug 33484 as we needed to know if the state was loaded (from URL or localStorage). If the state is loaded then we need to: 1. not redirect if only one patron to display (to prevent a blocking situation) 2. display the table (ie. not defer loading) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174724|0 |1 is obsolete| | --- Comment #63 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174743&action=edit Bug 38436: Adjust column names for the holdings tables Removing the prefix holdings_ and otherholdings_ Could have been done at the code level but does not seem necessary to have different column names Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174725|0 |1 is obsolete| | --- Comment #64 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174744&action=edit Bug 38436: Rename columns_settings.columnname in DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174726|0 |1 is obsolete| | --- Comment #65 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174745&action=edit Bug 38436: Fix column visibility when bKohaColumnsUseNames is used When the columns displayed in the table can vary (depending on sysprefs) we use bKohaColumnsUseNames. This allows us to use the name of the columns instead of there order number. The code was totally wrong, and didn't retrieve the correct number. A good example to confirm that is to add: console.log("%s is at %s".format(this.columnname, used_id)); at the end of the `if ( use_names ) {` block of _dt_visibility. If at least one column is hidden by default and cannot be toggled (and so won't appear in the list of the columns of the "Column visibility" button), there will be a shift. This line was definitelly wrong: var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); We cannot rely on the order of the visible columns, we need to retrieve the list of the columns using DT's api. Now the columns are retrieved using their class names, and from DT's api. The code is way nicer and more inline with how we are supposed to play with DT. Look at those 2 lines to pass the list of columns to the colvis button: let included_columns = table_settings.columns.filter(c => !c.cannot_be_toggled); columns: included_columns.map(c => '.' + c.columnname).join(',') Test plan: Play intensively with the items table (detail.pl), but also with the other tables not using bKohaColumnsUseNames (eg. patrons search) You need to set column as hidden by default and/or cannot be toggled. You need to play with the "Columns" button. Note that you need to remove the localStorage keys starting with 'DataTables_' to retrieve the visibility settings from what is defined in the admin area. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174727|0 |1 is obsolete| | --- Comment #66 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174746&action=edit Bug 38436: Adjust columns_settings.inc for KohaTable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174728|0 |1 is obsolete| | --- Comment #67 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174747&action=edit Bug 38436: Restore hide columns when empty If a column has no data on the items table we should hide the column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174729|0 |1 is obsolete| | --- Comment #68 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174748&action=edit Bug 38436: Do not hide all if none to hide Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174730|0 |1 is obsolete| | --- Comment #69 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174749&action=edit Bug 38436: Fix visibility when bKohaColumnsUseNames is not set Typically the patrons search. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174731|0 |1 is obsolete| | --- Comment #70 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174750&action=edit Bug 38436: Adjust Vue Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174732|0 |1 is obsolete| | --- Comment #71 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174751&action=edit Bug 38436: Do not deal with 'Columns' button if no table settings If the table does not have table settings we should not deal with the column visibility and not display the 'Columns' button. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174733|0 |1 is obsolete| | --- Comment #72 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174752&action=edit Bug 38069: (follow-up) Fix jump to the correct table https://bugs.koha-community.org/show_bug.cgi?id=38436 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174734|0 |1 is obsolete| | --- Comment #73 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174753&action=edit Bug 38436: (follow-up) Adjust columns_settings.inc for KohaTable Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174735|0 |1 is obsolete| | --- Comment #74 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174754&action=edit Bug 38436: (follow-up) Fix visibility when bKohaColumnsUseNames is not set Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174736|0 |1 is obsolete| | --- Comment #75 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174755&action=edit Bug 38436: Fix patron categories Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs. Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #76 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174756&action=edit Bug 38436: (QA follow-up) Tidy atomicupdate file to satisfy qa script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | Status|Signed Off |Passed QA --- Comment #77 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I have thoroughly tested the tables. I think this is good to go but which such a big impact it's hard to be sure. Anyway, passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #78 from Michaela Sieber <michaela.sieber@kit.edu> --- Before you push this, please test this scenario : search for "Programming the Perl DBI" (= koha/catalogue/detail.pl?biblionumber=13 ) Check that the item has no itemcallnumber, that's why the column 'Call number' is not displayed Check that the itemcallnumber in the admin table settings is NOT hidden by default (checkbox is not active) Go back to biblionumber=13 and edit the item. Add an itemcallnumber in the editor (Field o - Full call number) save the item. Go again to the "Normal" detail view. Now I have the problem, that I still don't see the column Call number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michaela Sieber from comment #78)
Before you push this, please test this scenario :
search for "Programming the Perl DBI" (= koha/catalogue/detail.pl?biblionumber=13 )
Check that the item has no itemcallnumber, that's why the column 'Call number' is not displayed
Check that the itemcallnumber in the admin table settings is NOT hidden by default (checkbox is not active)
Go back to biblionumber=13 and edit the item. Add an itemcallnumber in the editor (Field o - Full call number)
save the item.
Go again to the "Normal" detail view.
Now I have the problem, that I still don't see the column Call number.
Jonathan, can you please have a look? Michaela, if you still have that sandbox: could you try un-checking the "save state" in the table configuration and re-test? My guess would be that when you first viewed the table it saved the "state" and that made the column not appear when the data was filled in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #80 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Testing this scenario. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #81 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi Michaela, I just tried to reproduce the problem you described in comment #78 but fortunately it's not an issue. As cait suggested this is remedied by disabling the 'Save state' checkbox in the table configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #82 from Paul Derscheid <paul.derscheid@lmscloud.de> --- There's something weird going on here. When doing QA, I resolved a merge conflict on Patch #8: Restore hide columns when empty. I'd assume that when reattaching the patches after QA, that this would've been resolved. It's still an issue, though. Maybe I am just to blind to spot it today. Any help welcome! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #83 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #82)
There's something weird going on here.
When doing QA, I resolved a merge conflict on Patch #8: Restore hide columns when empty.
Not sure what happened but my local branch still applies. I have added Owen and your's signed-off-by lines and push to my gitlab repo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #84 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Michaela Sieber from comment #78)
Before you push this, please test this scenario :
search for "Programming the Perl DBI" (= koha/catalogue/detail.pl?biblionumber=13 )
Check that the item has no itemcallnumber, that's why the column 'Call number' is not displayed
Check that the itemcallnumber in the admin table settings is NOT hidden by default (checkbox is not active)
Go back to biblionumber=13 and edit the item. Add an itemcallnumber in the editor (Field o - Full call number)
save the item.
Go again to the "Normal" detail view.
Now I have the problem, that I still don't see the column Call number.
Yes, this is a tricky one. I thought I could fix this behaviour here but failed. It's reported separately on bug 38433 (reopened now). If we are saving the state (column visibility), it is saved automatically when a visibility changes, manually or with this behaviour we have on this table (hide the column if empty). To distinguish them we need to store separately the state desired by the user, and the "automatic state" generated by this "hide if empty" behaviour. It should not be very hard, but this is too late for 24.11.00 If this is too confusing, maybe a solution for 24.11.00 could be to disable "save state" by default for this table, with a note in the setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #85 from Jonathan Druart <jonathan.druart@gmail.com> --- Another suggestion: have a "show not empty columns" link at the top of the table if at least one column has data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #86 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Jonathan Druart from comment #84)
(In reply to Michaela Sieber from comment #78)
Before you push this, please test this scenario :
search for "Programming the Perl DBI" (= koha/catalogue/detail.pl?biblionumber=13 )
Check that the item has no itemcallnumber, that's why the column 'Call number' is not displayed
Check that the itemcallnumber in the admin table settings is NOT hidden by default (checkbox is not active)
Go back to biblionumber=13 and edit the item. Add an itemcallnumber in the editor (Field o - Full call number)
save the item.
Go again to the "Normal" detail view.
Now I have the problem, that I still don't see the column Call number.
Yes, this is a tricky one. I thought I could fix this behaviour here but failed. It's reported separately on bug 38433 (reopened now).
Yes it is tricky. I read all your thoughts in this bug , thats why I tested it with the mentioned workflow And to add new data to an item record is not a "special" use case, this is daily business in a library
If we are saving the state (column visibility), it is saved automatically when a visibility changes, manually or with this behaviour we have on this table (hide the column if empty). To distinguish them we need to store separately the state desired by the user, and the "automatic state" generated by this "hide if empty" behaviour.
Exactly, that is the only solution.
It should not be very hard, but this is too late for 24.11.00
Unfortunately.
If this is too confusing, maybe a solution for 24.11.00 could be to disable "save state" by default for this table, with a note in the setting.
Yes, it definitly should be disabled because the feature makes no sense as it works not as an end-user would expect it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38482 --- Comment #87 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Michaela Sieber from comment #86)
(In reply to Jonathan Druart from comment #84)
If this is too confusing, maybe a solution for 24.11.00 could be to disable "save state" by default for this table, with a note in the setting.
Yes, it definitly should be disabled because the feature makes no sense as it works not as an end-user would expect it.
See bug 38482. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38482 [Bug 38482] Disable save state for items tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174740|0 |1 is obsolete| | --- Comment #88 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174766&action=edit Bug 38436: Do not try to build the table if tab is not there If we don't have the "other holdings" tab, no need to try to build the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174741|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174767&action=edit Bug 38436: Store bKohaColumnsUseNames in data instead of DT's settings DataTable's settings do no longer allow to store custom properties. Here we are passing bKohaColumnsUseNames to the constructor, but we cannot retrieve it later from DT's api. We need to store it in data(). Test plan: 0. Do not apply this patch 1. In _dt_visibility add console.log(settings.bKohaColumnsUseNames); where relevant 2. Open your browser, clear localStorage entries (we want to reach the set_default() code) 3. Hit http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that the value is true then false (displayed once per columns). This is because we are calling _dt_visibility twice: * with the 'settings' we passed to the constructor: 1044 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, this) * from set_default() where we pass the settings retrieved from DT's api 900 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, $("#"+settings.nTable.id)); 4. Apply this patch, console.log again and confirm that it's now true. Notice that everything is then buggy... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174742|0 |1 is obsolete| | Attachment #174743|0 |1 is obsolete| | Attachment #174744|0 |1 is obsolete| | Attachment #174745|0 |1 is obsolete| | Attachment #174746|0 |1 is obsolete| | Attachment #174747|0 |1 is obsolete| | Attachment #174748|0 |1 is obsolete| | Attachment #174749|0 |1 is obsolete| | Attachment #174750|0 |1 is obsolete| | Attachment #174751|0 |1 is obsolete| | Attachment #174752|0 |1 is obsolete| | Attachment #174753|0 |1 is obsolete| | Attachment #174754|0 |1 is obsolete| | Attachment #174755|0 |1 is obsolete| | Attachment #174756|0 |1 is obsolete| | Attachment #174766|0 |1 is obsolete| | Attachment #174767|0 |1 is obsolete| | --- Comment #90 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174768&action=edit Bug 38436: Do not try to build the table if tab is not there If we don't have the "other holdings" tab, no need to try to build the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #91 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174769&action=edit Bug 38436: Store bKohaColumnsUseNames in data instead of DT's settings DataTable's settings do no longer allow to store custom properties. Here we are passing bKohaColumnsUseNames to the constructor, but we cannot retrieve it later from DT's api. We need to store it in data(). Test plan: 0. Do not apply this patch 1. In _dt_visibility add console.log(settings.bKohaColumnsUseNames); where relevant 2. Open your browser, clear localStorage entries (we want to reach the set_default() code) 3. Hit http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that the value is true then false (displayed once per columns). This is because we are calling _dt_visibility twice: * with the 'settings' we passed to the constructor: 1044 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, this) * from set_default() where we pass the settings retrieved from DT's api 900 [hidden_ids, included_ids] = _dt_visibility(table_settings, settings, $("#"+settings.nTable.id)); 4. Apply this patch, console.log again and confirm that it's now true. Notice that everything is then buggy... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #92 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174770&action=edit Bug 38436: Store loaded_from_state in data instead of DT's settings This has been introduced by bug 33484 as we needed to know if the state was loaded (from URL or localStorage). If the state is loaded then we need to: 1. not redirect if only one patron to display (to prevent a blocking situation) 2. display the table (ie. not defer loading) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #93 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174771&action=edit Bug 38436: Adjust column names for the holdings tables Removing the prefix holdings_ and otherholdings_ Could have been done at the code level but does not seem necessary to have different column names Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #94 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174772&action=edit Bug 38436: Rename columns_settings.columnname in DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #95 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174773&action=edit Bug 38436: Fix column visibility when bKohaColumnsUseNames is used When the columns displayed in the table can vary (depending on sysprefs) we use bKohaColumnsUseNames. This allows us to use the name of the columns instead of there order number. The code was totally wrong, and didn't retrieve the correct number. A good example to confirm that is to add: console.log("%s is at %s".format(this.columnname, used_id)); at the end of the `if ( use_names ) {` block of _dt_visibility. If at least one column is hidden by default and cannot be toggled (and so won't appear in the list of the columns of the "Column visibility" button), there will be a shift. This line was definitelly wrong: var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); We cannot rely on the order of the visible columns, we need to retrieve the list of the columns using DT's api. Now the columns are retrieved using their class names, and from DT's api. The code is way nicer and more inline with how we are supposed to play with DT. Look at those 2 lines to pass the list of columns to the colvis button: let included_columns = table_settings.columns.filter(c => !c.cannot_be_toggled); columns: included_columns.map(c => '.' + c.columnname).join(',') Test plan: Play intensively with the items table (detail.pl), but also with the other tables not using bKohaColumnsUseNames (eg. patrons search) You need to set column as hidden by default and/or cannot be toggled. You need to play with the "Columns" button. Note that you need to remove the localStorage keys starting with 'DataTables_' to retrieve the visibility settings from what is defined in the admin area. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #96 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174774&action=edit Bug 38436: Adjust columns_settings.inc for KohaTable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #97 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174775&action=edit Bug 38436: Restore hide columns when empty If a column has no data on the items table we should hide the column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #98 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174776&action=edit Bug 38436: Do not hide all if none to hide Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #99 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174777&action=edit Bug 38436: Fix visibility when bKohaColumnsUseNames is not set Typically the patrons search. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #100 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174778&action=edit Bug 38436: Adjust Vue Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #101 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174779&action=edit Bug 38436: Do not deal with 'Columns' button if no table settings If the table does not have table settings we should not deal with the column visibility and not display the 'Columns' button. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #102 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174780&action=edit Bug 38436: (follow-up) Adjust columns_settings.inc for KohaTable Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #103 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174781&action=edit Bug 38436: (follow-up) Fix visibility when bKohaColumnsUseNames is not set Previous commit didn't adjust columns_settings.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #104 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174782&action=edit Bug 38436: Fix patron categories Make it use bKohaColumnsUseNames as we are building the columns depending on sysprefs. Note that the hard-coded list of columns to export is wrong exportColumns: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12], Must use .noExport instead. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 [Bug 38485] Update column visibility on holdings table correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unable to hide a column in |Adjust code for column |the holdings table in the |visibility (after |staff interface |DataTables upgrade) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #105 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174821&action=edit Bug 38436: Fix OPAC tables This patch sync columns_settings.inc for the OPAC-side It however removes 'api' from datatables.js as it is never used. 'api' was renamed 'kohaTable' on bug 29408 but OPAC was forgotten. Better to not have to deal with this unused code for now, we will reintroduce it if needed later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #106 from Jonathan Druart <jonathan.druart@gmail.com> --- Please test this last patch if you can. It fixes (at least) the holdings table at the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #107 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Going in... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #108 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #109 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #108)
Pushed for 24.11!
Well done everyone, thank you!
Will fix the database update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #110 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #109)
(In reply to Katrin Fischer from comment #108)
Pushed for 24.11!
Well done everyone, thank you!
Will fix the database update.
REGEXP_REPLACE was an issue with old versions of MySQL, but I think it's in the past now. (bug 29805) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #111 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Database update pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression, | |rel_24_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #112 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174967&action=edit Bug 38436: Adjust DB update output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #113 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked last follow-up "Adjust DB..." for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38595 [Bug 38595] table settings behaviour broken on some tables at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Bug 38436 depends on bug 38391, which changed state. Bug 38391 Summary: DT's add filters called too many times https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38391 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #114 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #113)
Picked last follow-up "Adjust DB..." for main.
Should I do the same for 24.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Wainui, this depends on the datatables update not in 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 --- Comment #116 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #115)
Hi Wainui, this depends on the datatables update not in 24.05
Ok thanks Katrin! Not backporting this to 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38906 [Bug 38906] REGEXP_REPLACE not in MySQL < 5.8 DB update 24.06.00.064 fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Bug 38436 depends on bug 36640, which changed state. Bug 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #117 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40006 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38436 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40006 [Bug 40006] Upgrading install.pl shows code vs HTML -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org