[Bug 30237] New: Rename and rephrase AutoEmailOpacUser system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Bug ID: 30237 Summary: Rename and rephrase AutoEmailOpacUser system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 27812, 29005, 30214 With the changes from bugs 27812, bug 29005, and bug 30214 we will have a much cleaner and secure feature than before that will work in a much more predictable way. So I think this would then be a good moment to add documentation to the pref: IS: AutoEmailOpacUser [Send|Don't send] an email to newly created patrons with their account details. COULD BE: AutoEmailNewUser (switch Opac with New) [Send|Don't send] an email to newly created patrons, including verified self registrations. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 [Bug 27812] Remove the ability to transmit a patron's plain text password over email https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 [Bug 30214] Send ACCTDETAILS notice for new patrons added via self registration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd also take the opportunity to replace the ACCDETAILS notice with a new reworded default called 'WELCOME' or something along those lines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27812 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 [Bug 27812] Remove the ability to transmit a patron's plain text password over email -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] 'Welcome mail' for new library users -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename and rephrase |Rename/rephrase |AutoEmailOpacUser system |AutoEmailOpacUser/ACCTDETAI |preference |LS feature to clarify | |intended use -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131489&action=edit Bug 30237: Replace ACCDETAILS notice with WELCOME notice This patch drops the ACCDETAILS notice in preference to a new WELCOME notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131490&action=edit Bug 30237: Reference new WELCOME notice This patch updates all references to the former ACCTDETAILS notice to use the new WELCOME email notice instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131491&action=edit Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131489|0 |1 is obsolete| | Attachment #131490|0 |1 is obsolete| | Attachment #131491|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132785&action=edit Bug 30237: Replace ACCDETAILS notice with WELCOME notice This patch drops the ACCDETAILS notice in preference to a new WELCOME notice. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132786&action=edit Bug 30237: Reference new WELCOME notice This patch updates all references to the former ACCTDETAILS notice to use the new WELCOME email notice instead. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132787&action=edit Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Should there be a db update to rename the syspref AutoEmailOpacUser to AutoEmailNewUser? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #8)
Should there be a db update to rename the syspref AutoEmailOpacUser to AutoEmailNewUser?
Definitely! It looks like it's in the second patch: + + # Update system preference + $dbh->do( q{ + UPDATE systempreferences SET variable = 'AutoEmailNewUser', explanation = 'Send an email to newly created patrons.' WHERE variable = 'AutoEmailOpacUser' + }); }, }; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 30442 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Keywords| |Manual, | |release-notes-needed --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi all, almost there! 1) This includes a database update to insert a new letter. I am not sure about this approach. I think it would be better if we changed the letter code on the existing ACCTDETAILS instead, because it will cause less surprising behaviour. The existing notice will kept to be sent for libraries using the feature instead of it suddently changing text and turning English. (blocker) 2) We could add a note to the system preference about the letter code, so people will be able to see the change a little better. (suggestion) 3) QA test tools: FAIL installer/data/mysql/atomicupdate/bug_30237.pl FAIL file permissions File must have the exec flag 4) New letter Thank you for doing this, I already had filed a separate bug before stumbling onto this here! Some small stuff and hopefully good suggestions: a) Tiny typo: Thank you + - "Thankyou for joining [% Koha.Preference('LibraryName') %]" b) Linking 'here' Never link "here", it's a known accessibility issue with screen readers, but also because we are all used to scan for links now and it doesn't give an useful clue on where it leads. "The library's catalog can be found <a href='[% Koha.Preference('OPACBaseURL') %]'>here</a>." Better to say something like: You can search for all our materials in our <a href='[% Koha.Preference('OPACBaseURL') %]'>catalog</a>." And patron's won't know that this is Koha or who the administrator is, better to ask them to get in touch with the library staff :) If you have any problems or questions regarding your account, please contact your Koha Administrator. Better: If you have any problems or questions regarding your account, please contact your library. 5) French installer As we don't know yet if the French installer will be gone in time for release, we should update the installer with the new notice: installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 6) While testing bug 9097 I noticed that the branch name is not resolved in the subject line: Welcome to We might want to remove the name there for now and fix the subject replacement for TT on a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132785|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133153&action=edit Bug 30237: Replace ACCDETAILS notice with WELCOME notice This patch drops the ACCDETAILS notice in preference to a new WELCOME notice. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132786|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133154&action=edit Bug 30237: Reference new WELCOME notice This patch updates all references to the former ACCTDETAILS notice to use the new WELCOME email notice instead. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132787|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133155&action=edit Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser This patch replaces the AutoEmailOpacUser system preference with a new AutoEmailNewUser preference. This makes the functionof the preference clearer. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133156&action=edit Bug 30237: (follow-up) Update Notice This patch updates the sample notice as suggested by Katrin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133157&action=edit Bug 30237: (follow-up) Add french sample notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133158&action=edit Bug 30237: Add a note about WELCOME notice to system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #11)
Hi all,
almost there!
1) This includes a database update to insert a new letter. I am not sure about this approach. I think it would be better if we changed the letter code on the existing ACCTDETAILS instead, because it will cause less surprising behaviour. The existing notice will kept to be sent for libraries using the feature instead of it suddenly changing text and turning English. (blocker)
This was actually a deliberate choice. The notice text is all changed, as you see below. By leaving the old notice there but no longer referencing it I felt users could use it as a reference when updating the new notice. With the password functionality having already been removed it makes a lot of sense to require users update this notice to reflect it's clarified use. I was intending to add such a comment in the release notes too.
2) We could add a note to the system preference about the letter code, so people will be able to see the change a little better. (suggestion)
Done in last follow-up.
3) QA test tools:
FAIL installer/data/mysql/atomicupdate/bug_30237.pl FAIL file permissions File must have the exec flag
Done
4) New letter
Thank you for doing this, I already had filed a separate bug before stumbling onto this here! Some small stuff and hopefully good suggestions:
a) Tiny typo: Thank you
+ - "Thankyou for joining [% Koha.Preference('LibraryName') %]"
b) Linking 'here'
Never link "here", it's a known accessibility issue with screen readers, but also because we are all used to scan for links now and it doesn't give an useful clue on where it leads.
"The library's catalog can be found <a href='[% Koha.Preference('OPACBaseURL') %]'>here</a>."
Better to say something like: You can search for all our materials in our <a href='[% Koha.Preference('OPACBaseURL') %]'>catalog</a>."
And patron's won't know that this is Koha or who the administrator is, better to ask them to get in touch with the library staff :)
If you have any problems or questions regarding your account, please contact your Koha Administrator.
Better: If you have any problems or questions regarding your account, please contact your library.
Done
5) French installer
As we don't know yet if the French installer will be gone in time for release, we should update the installer with the new notice:
installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
Done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #12)
6) While testing bug 9097 I noticed that the branch name is not resolved in the subject line:
Welcome to
We might want to remove the name there for now and fix the subject replacement for TT on a separate bug?
This actually works for me.. are you sure you have the relevant syspref set? I did wonder where we should check the pref is filled.. would you like me to add that follow-up too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133159&action=edit Bug 30237: (follow-up) Make LibraryName conditional It's easy to forget to set the LibraryName preference.. as such we can make this a conditional and fall back to a default of 'the library'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #21)
Created attachment 133159 [details] [review] Bug 30237: (follow-up) Make LibraryName conditional
It's easy to forget to set the LibraryName preference.. as such we can make this a conditional and fall back to a default of 'the library'.
Ah, I expected the name of the branch, should have read the notice template more carefully. It certainly was the missing pref then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133153|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133345&action=edit Bug 30237: Replace ACCDETAILS notice with WELCOME notice This patch drops the ACCDETAILS notice in preference to a new WELCOME notice. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133154|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133346&action=edit Bug 30237: Reference new WELCOME notice This patch updates all references to the former ACCTDETAILS notice to use the new WELCOME email notice instead. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133155|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133347&action=edit Bug 30237: Replace AutoEmailOpacUser with AutoEmailNewUser This patch replaces the AutoEmailOpacUser system preference with a new AutoEmailNewUser preference. This makes the functionof the preference clearer. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133156|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133348&action=edit Bug 30237: (follow-up) Update Notice This patch updates the sample notice as suggested by Katrin. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133157|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133349&action=edit Bug 30237: (follow-up) Add french sample notice Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133158|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133350&action=edit Bug 30237: Add a note about WELCOME notice to system preference Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133159|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133351&action=edit Bug 30237: (follow-up) Make LibraryName conditional It's easy to forget to set the LibraryName preference.. as such we can make this a conditional and fall back to a default of 'the library'. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133352&action=edit Bug 30237: (QA follow-up) Spelling Thankyou => Thank you No thanks ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Bug 30237 depends on bug 29005, which changed state. Bug 29005 Summary: Add option to send ACCTDETAILS notice for new patrons added via patron imports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Patrons CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With the removal of patron release notes| |plaintext passwords from | |the ACCTDETAILS notice in | |bug 27812 the feature | |effectively got repurposed | |to become a 'Welcome | |email'. | | | |This enhancement | |rephrases the system | |preference description and | |replaces the ACCTDETAILS | |notice with a new WELCOME | |notice. | | | |We keep the | |ACCTDETAILS notice for | |reference at upgrades, but | |it will not appear for new | |installations and it is not | |longer sent in any | |circumstances. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/589 Keywords|Manual, | |release-notes-needed | Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6847 [Bug 6847] Script to send ACCT_DETAILS like email to a group of patrons -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org