https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #11)
Hi all,
almost there!
1) This includes a database update to insert a new letter. I am not sure about this approach. I think it would be better if we changed the letter code on the existing ACCTDETAILS instead, because it will cause less surprising behaviour. The existing notice will kept to be sent for libraries using the feature instead of it suddenly changing text and turning English. (blocker)
This was actually a deliberate choice. The notice text is all changed, as you see below. By leaving the old notice there but no longer referencing it I felt users could use it as a reference when updating the new notice. With the password functionality having already been removed it makes a lot of sense to require users update this notice to reflect it's clarified use. I was intending to add such a comment in the release notes too.
2) We could add a note to the system preference about the letter code, so people will be able to see the change a little better. (suggestion)
Done in last follow-up.
3) QA test tools:
FAIL installer/data/mysql/atomicupdate/bug_30237.pl FAIL file permissions File must have the exec flag
Done
4) New letter
Thank you for doing this, I already had filed a separate bug before stumbling onto this here! Some small stuff and hopefully good suggestions:
a) Tiny typo: Thank you
+ - "Thankyou for joining [% Koha.Preference('LibraryName') %]"
b) Linking 'here'
Never link "here", it's a known accessibility issue with screen readers, but also because we are all used to scan for links now and it doesn't give an useful clue on where it leads.
"The library's catalog can be found <a href='[% Koha.Preference('OPACBaseURL') %]'>here</a>."
Better to say something like: You can search for all our materials in our <a href='[% Koha.Preference('OPACBaseURL') %]'>catalog</a>."
And patron's won't know that this is Koha or who the administrator is, better to ask them to get in touch with the library staff :)
If you have any problems or questions regarding your account, please contact your Koha Administrator.
Better: If you have any problems or questions regarding your account, please contact your library.
Done
5) French installer
As we don't know yet if the French installer will be gone in time for release, we should update the installer with the new notice:
installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
Done -- You are receiving this mail because: You are watching all bug changes.