[Bug 32038] New: Sidebar and footer style improvements on suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Bug ID: 32038 Summary: Sidebar and footer style improvements on suggestions page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I have some ideas for making the sidebar filter forms and the bulk action forms in the table footer more usable and more consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142783&action=edit Bug 32038: Sidebar and footer style improvements on suggestions page This patch makes some changes to the suggestions template in order to make the sidebar filter form and bulk action table footer forms more usable and readable. Some global changes to <fieldset class="brief"> style are made. To test, apply the patch and rebuild the staff interface CSS. - Go to Suggestions. - Confirm that the sidebar contains two sections: Organize by and Filter by. - Test that the links under "Filter by" work to expand and collapse the different sections (bibliographic, suggestion, and acquisition). - Below the table of existing suggestions you should see the section "Change selected suggestions." - Each form should look good, with labels in bold above each form field, with "primary" style submit buttons. - Because some global styles have been modified, check that fieldsets with the class "brief" are still displayed correctly in other areas: - In sidebar forms: Patrons, Acquisitions order and invoice searches, overdues and holds to pull in Circulation. - In other areas: The Quick spine label creator; the upload plugin form; the calendar's add holiday form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142783|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142789&action=edit Bug 32038: Sidebar and footer style improvements on suggestions page This patch makes some changes to the suggestions template in order to make the sidebar filter form and bulk action table footer forms more usable and readable. Some global changes to <fieldset class="brief"> style are made. To test, apply the patch and rebuild the staff interface CSS. - Go to Suggestions. - Confirm that the sidebar contains two sections: Organize by and Filter by. - Test that the links under "Filter by" work to expand and collapse the different sections (bibliographic, suggestion, and acquisition). - Below the table of existing suggestions you should see the section "Change selected suggestions." - Each form should look good, with labels in bold above each form field, with "primary" style submit buttons. - Because some global styles have been modified, check that fieldsets with the class "brief" are still displayed correctly in other areas: - In sidebar forms: Patrons, Acquisitions order and invoice searches, overdues and holds to pull in Circulation. - In other areas: The Quick spine label creator; the upload plugin form; the calendar's add holiday form. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It is certainly an improvement! Two things I am not completely sure about: 1) When you open up the filters there is a grey line on the side. I think that one is not really needed. 2) The update options look much better, but it feels like it would be nice to have some kind of separation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142789|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142806&action=edit Bug 32038: Sidebar and footer style improvements on suggestions page This patch makes some changes to the suggestions template in order to make the sidebar filter form and bulk action table footer forms more usable and readable. Some global changes to <fieldset class="brief"> style are made. To test, apply the patch and rebuild the staff interface CSS. - Go to Suggestions. - Confirm that the sidebar contains two sections: Organize by and Filter by. - Test that the links under "Filter by" work to expand and collapse the different sections (bibliographic, suggestion, and acquisition). - Below the table of existing suggestions you should see the section "Change selected suggestions." - Each form should look good, with labels in bold above each form field, with "primary" style submit buttons. - Because some global styles have been modified, check that fieldsets with the class "brief" are still displayed correctly in other areas: - In sidebar forms: Patrons, Acquisitions order and invoice searches, overdues and holds to pull in Circulation. - In other areas: The Quick spine label creator; the upload plugin form; the calendar's add holiday form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32038 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org