[Bug 32148] New: Buttons must inherit Bootstrap size classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Bug ID: 32148 Summary: Buttons must inherit Bootstrap size classes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32044 The global changes to button styles made by Bug 32044 created an issue with button styling: The default font size and padding changes have the side-effect of overriding Bootstrap's button size classes: btn-sm, btn-xs, etc. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 [Bug 32044] Yellow buttons are styled differently in different spots -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143517&action=edit Bug 32148: Buttons must inherit Bootstrap size classes This patch removes global font and padding settings which were overriding the Bootstrap classes we use to change the size of Bootstrap buttons. The font and padding settings are moved to the CSS which covers button which are not styled as Bootstrap buttons. To test, apply the patch and view pages where buttons are styled with different Bootstrap size classes: - Circulation -> Check out: - The "Check out" button, the "Show checkouts" button, Renew buttons in the footer. - Patrons -> Patron details -> Edit buttons in each section. - Patrons home -> Buttons in sidebar filter - Catalog -> Bibliographic details -> Item details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32071 [Bug 32071] Consistent classes for primary buttons: Catalog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143517|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143596&action=edit Bug 32148: Buttons must inherit Bootstrap size classes This patch removes global font and padding settings which were overriding the Bootstrap classes we use to change the size of Bootstrap buttons. The font and padding settings are moved to the CSS which covers button which are not styled as Bootstrap buttons. To test, apply the patch and view pages where buttons are styled with different Bootstrap size classes: - Circulation -> Check out: - The "Check out" button, the "Show checkouts" button, Renew buttons in the footer. - Patrons -> Patron details -> Edit buttons in each section. - Patrons home -> Buttons in sidebar filter - Catalog -> Bibliographic details -> Item details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143596|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143607&action=edit Bug 32148: Buttons must inherit Bootstrap size classes This patch removes global font and padding settings which were overriding the Bootstrap classes we use to change the size of Bootstrap buttons. The font and padding settings are moved to the CSS which covers button which are not styled as Bootstrap buttons. To test, apply the patch and view pages where buttons are styled with different Bootstrap size classes: - Circulation -> Check out: - The "Check out" button, the "Show checkouts" button, Renew buttons in the footer. - Patrons -> Patron details -> Edit buttons in each section. - Patrons home -> Buttons in sidebar filter - Catalog -> Bibliographic details -> Item details Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32148 Bug 32148 depends on bug 32044, which changed state. Bug 32044 Summary: Yellow buttons are styled differently in different spots https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32044 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org