[Bug 20347] New: Add missing classes to search results elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 Bug ID: 20347 Summary: Add missing classes to search results elements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 72497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72497&action=edit Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Sebastian Hierl <s.hierl@aarome.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72826&action=edit Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Sebastian Hierl <s.hierl@aarome.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72826|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73070&action=edit Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Sebastian Hierl <s.hierl@aarome.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20347 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org