[Bug 20321] New: C4:XISBN->get_biblionumber_from_isbn is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Bug ID: 20321 Summary: C4:XISBN->get_biblionumber_from_isbn is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Let remove it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72340&action=edit Bug 20321 - Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72340|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 72385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72385&action=edit Bug 20321 - Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |roch.damour@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72385|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72433&action=edit Bug 20321 - Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20321 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org