[Bug 13398] New: Perl files for rotating collections are missing in debian package
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Bug ID: 13398 Summary: Perl files for rotating collections are missing in debian package Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz In Koha 3.18 installed from Debian package are missing all 4 perl script for rotating collections. I've extracted the .deb file and these files are missing there too. Template files are OK. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one is quite bad - rotating collections is one of the main new features... and it's missing from the packages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 34327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34327&action=edit Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Perl files for rotating |Perl files for rotating |collections are missing in |collections are missing in |debian package |installations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34327|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34391&action=edit [SIGNED OFF] Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34391|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34449&action=edit [PASSED QA] Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected.. even built a package with it for the belt and braces approach. As a side note, this just highlights the need for better packages testing.. there been a few of these with this release.. Sorry Tomas, I'll try harder as one of the few package testers in the future. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|3.18 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- No string changes, pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to Chris Cormack from comment #7)
No string changes, pushed to 3.18.x will be in 3.18.2
skipping patch for 3.16.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org