[Bug 13470] New: pay fines with extended borrower attributes result in application error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Bug ID: 13470 Summary: pay fines with extended borrower attributes result in application error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dpavlin@rot13.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Can't call method "param" on an undefined value at /srv/koha_ffzg/members/paycollect.pl line 182. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |dpavlin@rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 34451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34451&action=edit Bug 13470 - pay fines with extended borrower attributes result in application error Test scenario: 1. ensure that extended patron attributes are turned on in system preferences 2. find borrower which has fine to pay, and click on pay button 3. verify application error 4. apply patch and verify that application error is gone -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to create the error case on master 3.19.00.000, but I could not get the error. I had no error neither using "Pay", nor using "Pay amount" nor using "Pay selected" buttons. For now I pass the patch to the "In Discussion" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I should clarify that this error exists only when running under plack, which makes $template go out of scope since it's not declared with our. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Dobrica Pavlinusic from comment #3)
I should clarify that this error exists only when running under plack, which makes $template go out of scope since it's not declared with our.
Thanks, Dobrica, for your kind explaination. I'm passing this bug back to "Needs Signoff" status. But I'm not going to test this bug, because I'd prefer not to install plack. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34451|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 34501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34501&action=edit Bug 13470 - pay fines with extended borrower attributes result in application error Test scenario: 1. ensure that extended patron attributes are turned on in system preferences 2. find borrower which has fine to pay, and click on pay button 3. verify application error 4. apply patch and verify that application error is gone Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34501|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34524&action=edit Bug 13470 - pay fines with extended borrower attributes result in application error Test scenario: 1. ensure that extended patron attributes are turned on in system preferences 2. find borrower which has fine to pay, and click on pay button 3. verify application error 4. apply patch and verify that application error is gone Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |12542 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Bug reproduced, I confirm this patch fixes the issue. No regression found. Bug introduced by bug 12542. Note that the pref value is not used by paycollect.tt (which uses circ-menu.tt, not circ-menu.inc). We could remove it, but to be consistent it is better to keep it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #7)
Bug reproduced, I confirm this patch fixes the issue. No regression found. Bug introduced by bug 12542.
skipping patch for 3.16.x - as bug 12542 is not in 3.16.x branch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org