[Bug 38466] New: Kbart import is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Bug ID: 38466 Summary: Kbart import is not working Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Created attachment 174646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174646&action=edit example of KBART file not imported Tested today in PTFS MARC21 Sandbox - eHoldings > Local > Packages: create a local package - eHoldings > Local > Titles > Import from KBART
import a kbart file (I tested with several from https://bacon.abes.fr/exporter.html site) To the following local package: select the local package created before Keep unchecked the checkbox "Create linked bibliographic record:" (the same issue is present if it checked)
Submit During a few second the message "Submitting" appears, and that is all, the records are not imported I can see this error in Console : EHoldingsLocalTitlesKBARTImport.vue:159 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'invalid_columns') at EHoldingsLocalTitles…RTImport.vue:159:42 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #1 from Mathieu Saby <mathsabypro@gmail.com> --- note that the file has an extra column "bestppn", but even if I remove this column the error persists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 [Bug 34788] Add the ability to import KBART files to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174680&action=edit Bug 38466: Fix error messages in KBART import Test plan: 1) Download the file attached to this bug and save it as a .txt file 2) In the ERM module, create a local package 3) Go to the local titles page and click Import from KBART file 4) Select your package and the saved file and click import 5) The import will fail with just a console error 6) Apply patch and run a restart_all and a yarn js:build 7) Repeat step 4, it should now display an error saying the file must be either TSV or CSV 8) Convert the file to either of those two formats and repeat step 4 9) The file should now import successfully, with a message saying that there is an additional column "bestppn" that will not be imported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #3 from Mathieu Saby <mathsabypro@gmail.com> --- ok, I thought the CSV or TSV filetype was checked against the structure of the file, not it's extension. I am testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- In bug 36831 there is some work to make the filetype irrelevant but it needs a bit more work done to be ready -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #5 from Mathieu Saby <mathsabypro@gmail.com> --- Indeed the import is working well if the file have an extension ".tsv". So the title of the bug is wrong. I suppose it should be something like "Missing warning if the import of a KBART file fails because of wrong extension" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Kbart import is not working |Kbart import fails silently | |is file extension is wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Kbart import fails silently |Kbart import fails silently |is file extension is wrong |if file extension is wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174680|0 |1 is obsolete| | --- Comment #6 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 174737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174737&action=edit Bug 38466: Fix error messages in KBART import Test plan: 1) Download the file attached to this bug and save it as a .txt file 2) In the ERM module, create a local package 3) Go to the local titles page and click Import from KBART file 4) Select your package and the saved file and click import 5) The import will fail with just a console error 6) Apply patch and run a restart_all and a yarn js:build 7) Repeat step 4, it should now display an error saying the file must be either TSV or CSV 8) Convert the file to either of those two formats and repeat step 4 9) The file should now import successfully, with a message saying that there is an additional column "bestppn" that will not be imported Signed-off-by: msaby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #7 from Mathieu Saby <mathsabypro@gmail.com> --- Thanks, I tested on a sandbox, everything is ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174737|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174920&action=edit Bug 38466: Fix error messages in KBART import Test plan: 1) Download the file attached to this bug and save it as a .txt file 2) In the ERM module, create a local package 3) Go to the local titles page and click Import from KBART file 4) Select your package and the saved file and click import 5) The import will fail with just a console error 6) Apply patch and run a restart_all and a yarn js:build 7) Repeat step 4, it should now display an error saying the file must be either TSV or CSV 8) Convert the file to either of those two formats and repeat step 4 9) The file should now import successfully, with a message saying that there is an additional column "bestppn" that will not be imported Signed-off-by: msaby <mathsabypro@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Kbart import fails silently |KBART import fails silently |if file extension is wrong |if file extension is wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- I cannot see an option in Local titles to import from a kbart file. I only see "New title" and "Import from list", -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Wainui Witika-Park from comment #11)
I cannot see an option in Local titles to import from a kbart file. I only see "New title" and "Import from list",
Not backporting to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes importing of release notes| |KBART files by adding an | |error message if the file | |extension is not a TSV or | |CSV file, instead of | |silently failing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes importing of |This fixes importing of release notes|KBART files by adding an |KBART files by adding an |error message if the file |error message if the file |extension is not a TSV or |extension is not .TSV or |CSV file, instead of |.CSV, instead of silently |silently failing. |failing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38466 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org