[Bug 38594] New: Table settings for courses reserves not working at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Bug ID: 38594 Summary: Table settings for courses reserves not working at the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175045&action=edit Bug 38594: Fix table settings on the course reserves tables - OPAC We are passing the columns settings, but KohaTable is expecting the table settings. Test plan: Hide some columns for the course reserves table at the OPAC Define a course, add 1+ items Go to the OPAC, "Course reserves" Notice that with this patch the columns are correctly hidden by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175046&action=edit Bug 38594: Remove unused TablesSettings.GetColumns This is no longer used, and should not. Test plan: git grep TablesSettings.GetColumns should not return any results git grep GetColumns should not return results related to this method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 [Bug 26553] Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175045|0 |1 is obsolete| | Attachment #175046|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175055&action=edit Bug 38594: Fix table settings on the course reserves tables - OPAC We are passing the columns settings, but KohaTable is expecting the table settings. Test plan: Hide some columns for the course reserves table at the OPAC Define a course, add 1+ items Go to the OPAC, "Course reserves" Notice that with this patch the columns are correctly hidden by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175056&action=edit Bug 38594: Remove unused TablesSettings.GetColumns This is no longer used, and should not. Test plan: git grep TablesSettings.GetColumns should not return any results git grep GetColumns should not return results related to this method Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175055|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175060&action=edit Bug 38594: Fix table settings on the course reserves tables - OPAC We are passing the columns settings, but KohaTable is expecting the table settings. Test plan: Hide some columns for the course reserves table at the OPAC Define a course, add 1+ items Go to the OPAC, "Course reserves" Notice that with this patch the columns are correctly hidden by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175056|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175061&action=edit Bug 38594: Remove unused TablesSettings.GetColumns This is no longer used, and should not. Test plan: git grep TablesSettings.GetColumns should not return any results git grep GetColumns should not return results related to this method Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Table settings for courses |Table settings for courses |reserves not working at the |reserves not working in he |OPAC |OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Could I please get a more detailed test plan for 24.05.x? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Wainui Witika-Park from comment #9)
Could I please get a more detailed test plan for 24.05.x? :)
You can ignore the second patch as it is only removing dead code (and maybe not dead in 24.05.x, I have not confirmed that). For the first patch try the following steps: Go to the Table settings administration page, under the "OPAC" tab you have the configuration for the course_items table (http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#course_items) Tick Title to make it hidden by default. Define a course and add at least one item At the OPAC, under "Course reserves" you should see the table with the column hidden by default. Without this patch the column is not hidden (ie. the settings are not taken into account) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #10)
(In reply to Wainui Witika-Park from comment #9)
Could I please get a more detailed test plan for 24.05.x? :)
You can ignore the second patch as it is only removing dead code (and maybe not dead in 24.05.x, I have not confirmed that).
For the first patch try the following steps:
Go to the Table settings administration page, under the "OPAC" tab you have the configuration for the course_items table (http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#course_items) Tick Title to make it hidden by default. Define a course and add at least one item At the OPAC, under "Course reserves" you should see the table with the column hidden by default.
Without this patch the column is not hidden (ie. the settings are not taken into account)
Thanks Jonathan! Unfortunately the columns are still not being hidden correctly by the settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the OPAC course release notes| |reserves table. The table | |settings were not taken | |into account when | |displaying the table, for | |example, hidden columns | |were still shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Table settings for courses |Table settings for courses |reserves not working in he |reserves not working in the |OPAC |OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38594 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org