[Bug 25151] New: Accessibility: The 'Your folder' page does not contain a level-one header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Bug ID: 25151 Summary: Accessibility: The 'Your folder' page does not contain a level-one header Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Blocks: 25150 Library Catalogue - OPAC 1/ Add items to your folder 2/ Once you have added some books, click on the 'Folder' at top of page to view selections. 3/ The ‘Your folder’ page does not contain a level-one heading. This means that users may not be able to accurately determine the structure of content on the page. Current Code: <h2>Your folder</h2> Solution: Ensure that all pages contain a heading level 1 to introduce the main content of the page followed by a logical hierarchy of subsequent headings. For example: <h1>Main heading</h1> <h2>Sub-heading of h1</h2> <h2>Sub-heading of h1</h2> <h3>Sub-heading of h2</h3> <h2>Sub-heading of h1</h2> <h3>Sub-heading of h2</h3> <h4>Sub-heading of h3</h4> <h2>Sub-heading of h1</h2> <h2>Sub-heading of h1</h2> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #1 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Hi Martin, Could you please clarify where I can find the 'Your folder' page? I thought maybe you meant Lists, but that page has correct headings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Ah it's en-GB for the cart! Got it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 105719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105719&action=edit Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for jumping on this Hayley.. sorry it wasn't as clear as it should have been.. I'm working through a massive report and missed the translation in this case. Testing now for SO :). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. well this certainly improves the situation for screen readers and is exactly what I asked for.. but it seems to highlight some slightly odd css rules.. though at the moment I'm struggling to track down which ones are causing it. The 'h2' seems to appear larger than the 'h1' on the page.. which feel semantically incorrect visually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: The 'Your |Accessibility: The 'Your |folder' page does not |cart' page does not contain |contain a level-one header |a level-one header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105719|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 105766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105766&action=edit Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105766|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106118&action=edit Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.14 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org