[Bug 25239] New: Accessibility: The 'Confirm reservation page' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Bug ID: 25239 Summary: Accessibility: The 'Confirm reservation page' contains semantically incorrect headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 25155 Blocks: 25150 Library Catalogue - OPAC The ‘Confirm reservations for: Person X (111000111)’ heading is not logical because it increases by more than one heading level. This means that screen reader users may not be able to determine the structure of content on the page. 1/ Search for an item and attempt to reserve it Current Code: <h3>Confirm reservations for: Person X (111000111)</h3> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25155 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105741&action=edit Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk, | |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: The 'Confirm |Accessibility: The 'Confirm |reservation page' contains |hold page' contains |semantically incorrect |semantically incorrect |headings |headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105741|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 105758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105758&action=edit Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works great - just a note for future testers, to make H3 (Hold levels) appear, do the following: 1/ Perform a search which yields some results in the OPAC 2/ Place a hold on an item 3/ Go back to the same record and attempt to place a second hold 4/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 5/ Apply this patch and reload the page 6/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 7/ Note the appearance of the box is still reasonable 8/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105758|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106116&action=edit Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- There are no <h5> headings on this page in 19.11.x. I'd like to backport this for accessibility, but need someone to write a patch that fixes the <h3>Confirm holds for:</h3> for 19.11.x only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- decided to rebase myself :) backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.14 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org