http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|gmcharlt@gmail.com |veron@veron.ch Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43218|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44008&action=edit [SIGNED-OFF] Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> NewsChanell pass for me before patch, no after. Followup follows :) Rest of tests pass -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44009|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 44010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44010&action=edit Bug 14977: followup to fix NewsChanell.t With this patch test pass. To test: Run without and with the patch Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The NewsChannels.t test fail for me, with and without the last patch: With: # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 90. # Structures begin differing at: # $got->{expirationdate} = '12/30/2999' # $expected->{expirationdate} = '30/12/2999' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 112. # Structures begin differing at: # $got->{expirationdate} = '12/31/2999' # $expected->{expirationdate} = '31/12/2999' # Looks like you failed 2 tests of 10. Without: # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 90. # Structures begin differing at: # $got->{expirationdate} = '30/12/2999' # $expected->{expirationdate} = '2999-12-30' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 112. # Structures begin differing at: # $got->{timestamp} = '01/01/2000' # $expected->{timestamp} = '2000-01-01' # Looks like you failed 2 tests of 10. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44010|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Comment on attachment 44010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44010 Bug 14977: followup to fix NewsChanell.t Thanks Bernardo for the trying to fix. It helped to find out what happens. New patch follows. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44008|0 |1 is obsolete| | Attachment #44100|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44121&action=edit Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> NewsChanell pass for me before patch, no after. Followup follows :) Rest of tests pass Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.