[Bug 14931] New: Remove C4::Dates from files admin/aq*.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Bug ID: 14931 Summary: Remove C4::Dates from files admin/aq*.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 42977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42977&action=edit Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Patch complexity|--- |Small patch Assignee|gmcharlt@gmail.com |veron@veron.ch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42977|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43302&action=edit [SIGNED-OFF]Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref Dates in planning by months not needed to be on iso format, aqplan.pl uses instead Date::Calc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I get a software error if the dates are not correctly formatted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 43427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43427&action=edit Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Marc Véron <veron@veron.ch> --- The Follow-up needs an other sign-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #6 from Marc Véron <veron@veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Sorry Marc, but fail me. This is the error message: DBIx::Class::ResultSet::find(): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= 'booksellerid' AND me.1 IS NULL AND me.2015-12-31 = 'contractname' AND me.Fict' at line 1 at /home/koha/kohaclone/C4/Contract.pm line 125 This happend me when modifing the contract and i've entered an invalid date 32/10/2015 (DD/MM/YY) This happen me when modifying the contract and entered an invalid date 32/10/2015 (DD/MM/YY) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43427|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 43956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43956&action=edit Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43956|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 44101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44101&action=edit [SIGNED OFF] Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv Signed-off-by: Jesse Weaver <pianohacker@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43302|0 |1 is obsolete| | Attachment #44101|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44103&action=edit Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with dateformat syspref Dates in planning by months not needed to be on iso format, aqplan.pl uses instead Date::Calc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44104&action=edit Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44105&action=edit Bug 14931: (qa followu-up) small improvements - Avoid 1 call to dt_from_string in some cases - Do not use $_ Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44107&action=edit Bug 14931: Fix test xt/author/valid_templates complaining on opac-topissues.tt undef error - Undefined subroutine &C4::Languages::getlanguage called at C4/Koha.pm line 250. Test plan: prove xt/author/valid-templates.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org