[Bug 18746] New: Text_CSV_Various.t parse failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Bug ID: 18746 Summary: Text_CSV_Various.t parse failure Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: ldjamison@marywood.edu QA Contact: gmcharlt@gmail.com Unit Test command 'prove -v xt/author/Text_CSV_Various.t' fails even with prerequisite modules installed According to the Koha Wiki signoff documentation, in order for 'prove xt/' to pass, the following modules must be installed: Test::Pod; Test::Pod::Spelling Text::CSV::Unicode however, even with these modules installed, running the prove command on Text_CSV_Various.t exits with the following outputs: not ok 10 - parse (Text::CSV) not ok 13 - parse (Text::CSV::Unicode) not ok 16 - parse (Text::CSV_XS) not ok 19 - parse (Text::CSV) not ok 22 - parse (Text::CSV::Unicode) not ok 25 - parse (Text::CSV_XS) ok 26 - parse (Text::CSV_XS (binary)) ok 27 - Number of fields (6 of 6) field 1: field1 field 2: second field field 3: field3 field 4: do_we_have_a_e_problem? (the _e_ appears to have a dot over it which appears - after researching - to be the 9th letter of the Lithuanian alphabet) field 5: f!fth field field 6: lastfield # For each of the above "not ok" and "ok" failures, it prints the following message: Failed test 'parse (Module::Name)' at xt/author/Text_CSV_Various.t line 57. Wide character in print at xt/author/Text_CSV_Various.t line 63. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems that the failures are expected. I'd suggest to remove this file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64091&action=edit Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Status|In Discussion |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Let's give it a try! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64091|0 |1 is obsolete| | --- Comment #4 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64110&action=edit Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Running 'prove xt/author/Text_CSV_Various.t' passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64110|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64130&action=edit Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Running 'prove xt/author/Text_CSV_Various.t' passes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64131&action=edit Bug 18746: Add license and remove diag Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org