[Bug 18690] New: Typos in Koha database description (Table "borrowers")
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Bug ID: 18690 Summary: Typos in Koha database description (Table "borrowers") Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: mik@adminkuhn.ch QA Contact: testopia@bugs.koha-community.org There are some typos in the SchemaSpy description of table "borrowers". * http://schema.koha-community.org/16_11/tables/borrowers.html 1. In the comment for field "debarred" (YYY-MM-DD) should by replaced by (YYYY-MM-DD) 2. In the comment for field "smsalertnumber" SNS should be replaced by SMS 3. In the comments of fields "contactname", "contacttitle", "guarantorid", "relationship" the term "guarentor" is used, but it should be "guarantor". 4. The comment for field "password" reads "patron/borrower's encrypted password". I think it could be more explicit by writing "patron/borrower's Bcrypt encrypted password". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Installation and upgrade |Database |(command-line installer) | Version|16.11 |master --- Comment #1 from Marc Véron <veron@veron.ch> --- Verified for current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63833&action=edit Bug 18690 - Typos in Koha database description (Table "borrowers") This string patch fixes typos in kohastructure.sql as described in initial comment. To test: - Carefully verify that string changes make sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|gmcharlt@gmail.com |veron@veron.ch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 --- Comment #3 from Michael Kuhn <mik@adminkuhn.ch> --- Strings are now correct as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #4 from Marc Véron <veron@veron.ch> --- Thanks, Michael, for testing and confirming that changes are OK. But sorry, to set a bug to Signed Off you have to apply the patch on your development environment, then sign off on the patch (that adds your sign off to the patch), and then attach the patch again. See https://wiki.koha-community.org/wiki/Sign_off_on_patches I use the git bz workflow mentioned there, see: https://wiki.koha-community.org/wiki/Git_bz_configuration Setting back to NSO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63833|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63997&action=edit Bug 18690 - Typos in Koha database description (Table "borrowers") This string patch fixes typos in kohastructure.sql as described in initial comment. To test: - Carefully verify that string changes make sense Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org