[Bug 34069] New: Add ability to restore a recently deleted borrower from deletedborrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Bug ID: 34069 Summary: Add ability to restore a recently deleted borrower from deletedborrowers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It would be awesome to have the ability to restore a deleted borrower from deletedborrowers. Of course, if the borrower you need has been purged from that table for whatever reason, it wouldn't work, but it feels like an essential missing feature since we keep the data for Reasons anyway. Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note that we keep some, but not all data. For example we delete the patron attributes, alerts etc. But it could still be helpful of course and some links remain. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188299&action=edit Bug 34069: Add restore_deleted_borrowers permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188302&action=edit Bug 34069: Implement tool for restoring deleted patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think we want both a permission and a system preference to control this feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188988&action=edit Bug 34069: Log patron restoration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188989&action=edit Bug 34069: Add a CannotRestore exception and throw when the userid, borrowernumber, or cardnumber is already in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188989|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188990&action=edit Bug 34069: Add a CannotRestore exception and throw when the userid, borrowernumber, or cardnumber is already in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189027&action=edit Bug 34069: Add restore_deleted_borrowers permission and new system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188302|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189028&action=edit Bug 34069: Implement tool for restoring deleted patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188988|0 |1 is obsolete| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189029&action=edit Bug 34069: Log patron restoration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188990|0 |1 is obsolete| | --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189030&action=edit Bug 34069: Add a CannotRestore exception and throw when the userid, borrowernumber, or cardnumber is already in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189037&action=edit Bug 34069: Add ability to search on updated_on dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189066&action=edit Bug 34069: Deal with view_borrower_infos_from_any_libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189067&action=edit Bug 34069: Add information about what can and cannot be restored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189027|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189370&action=edit Bug 34069: Add restore_deleted_borrowers permission and new system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189028|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189371&action=edit Bug 34069: Implement tool for restoring deleted patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189029|0 |1 is obsolete| | --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189372&action=edit Bug 34069: Log patron restoration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189030|0 |1 is obsolete| | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189373&action=edit Bug 34069: Add a CannotRestore exception and throw when the userid, borrowernumber, or cardnumber is already in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189037|0 |1 is obsolete| | --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189374&action=edit Bug 34069: Add ability to search on updated_on dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189066|0 |1 is obsolete| | --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189375&action=edit Bug 34069: Deal with view_borrower_infos_from_any_libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189067|0 |1 is obsolete| | --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189376&action=edit Bug 34069: Add information about what can and cannot be restored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189377&action=edit Bug 34069: Move permission from borrower to tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- I know this isn't done but I took a look and wanted to mention that you probably want <div class="alert alert-info"> instead of "dialog alert bg-info-subtle". I also think the heading inside the alert should be <h2> instead of <h3> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189642&action=edit Bug 34069: Fix HTML, Bootstrap classes, and QA complaints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189645&action=edit Bug 34069: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- A handful of small-ish things that should be addressed: - Deletin from patron record gives a message "this cannot be undone," but that won't be true anymore with these patches - Submitting a blank search in the Restore Borrowers tool returns no patrons. We should either disallow blank search OR give clear message that blank search doesn't work - Categorycode and branchcode are blank in deleted patron list (even though they have values in deletedborrowers) - After restoration, "View patron" should open in new tab - Restore Borrowers tool is not in the Tools sidebar - Search by date should only look at date portion of updated_on -- currently a search for date range 11/17/2025 - 11/18/2025 does not return patrons deleted on 11/18/2025, but a search 11/18 - 11/19 does - When user is limited to only see patrons in their library group they should be able to select "All libraries" and get only those they have access to -- currently such a user can restore borrowers for any library in their group, but only 1 library at a time - RESTORE action should not be all caps in action logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189718&action=edit Bug 34069: Fix categorycode/branch info, open in new tab, and other fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189773&action=edit Bug 34069: Adjust before and after date search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189774&action=edit Bug 34069: Prevent search if no search critrea -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189779&action=edit Bug 34069: Allow for multiselection of branch and category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189780&action=edit Bug 34069: Logaction should not be in all caps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189370|0 |1 is obsolete| | --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189781&action=edit Bug 34069: Add restore_deleted_borrowers permission and new system preference 1. APPLY PATCH, updatedatabase, restart_all 2. Now setup two users for testing, a superlibrarian and a limited permission user. The limited permission should have staff access and the restore_deleted_borrowers (tools) permission. /* SUPERLIBRARIAN */ 3. As superlibrarian, find the 'AllowDeletedPatronRestoration' system preference and enable it. Also make sure BorrowersLog is turned on. 4. Go to Tools -> Restore deleted patrons 5. Read the warning/information about what can and cannot be restored. Ensure it all makes sense. 6. Now we must delete some borrowers, either 1 by 1 or with the batch deletion tool. 7. Back to the deletion tool ( Tools -> Restore deleted patrons ) 8. Search for some of your deleted patrons by any of the critrea available. ( Cardnumber, borrowernumber, first name, surname, category, branch, or date ) 9. Ensure that searching works well. 10. Now bring up a deleted patron, check the checbox to the left and click "Restore deleted patrons" 11. Now you should be able to see the that the patron was restored. 12. Click "View patron" to look at the restored patron record. 13. Go to the action logs and make sure that the restoration was logged. /* LIMITED PERMISSION USER */ 14. Now log in as your limited permission user. 15. Go to Tools -> Restore deleted patrons 16. As a limited permssion user you should only be able to search for deleted borrowers from your branch, or branches in your library group. 17. Repeat all the steps to restore a patron, ensuring everything works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189371|0 |1 is obsolete| | --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189782&action=edit Bug 34069: Implement tool for restoring deleted patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189372|0 |1 is obsolete| | --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189783&action=edit Bug 34069: Log patron restoration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189373|0 |1 is obsolete| | --- Comment #35 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189784&action=edit Bug 34069: Add a CannotRestore exception and throw when the userid, borrowernumber, or cardnumber is already in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189374|0 |1 is obsolete| | --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189785&action=edit Bug 34069: Add ability to search on updated_on dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189375|0 |1 is obsolete| | --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189786&action=edit Bug 34069: Deal with view_borrower_infos_from_any_libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189376|0 |1 is obsolete| | --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189787&action=edit Bug 34069: Add information about what can and cannot be restored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189377|0 |1 is obsolete| | --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189788&action=edit Bug 34069: Move permission from borrower to tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189642|0 |1 is obsolete| | --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189789&action=edit Bug 34069: Fix HTML, Bootstrap classes, and QA complaints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189645|0 |1 is obsolete| | --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189790&action=edit Bug 34069: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189718|0 |1 is obsolete| | --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189791&action=edit Bug 34069: Fix categorycode/branch info, open in new tab, and other fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189773|0 |1 is obsolete| | --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189792&action=edit Bug 34069: Adjust before and after date search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189774|0 |1 is obsolete| | --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189793&action=edit Bug 34069: Prevent search if no search critrea -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189779|0 |1 is obsolete| | --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189794&action=edit Bug 34069: Allow for multiselection of branch and category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189780|0 |1 is obsolete| | --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189795&action=edit Bug 34069: Logaction should not be in all caps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #47 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Hi! Here are a few remarks: I'm wondering if we should add "from the deletedborrowers table" in the syspref and tool description. It sounds more like a developer thing than a user one. It's okay to have it in the tool itself with the explanation of why not everything is restored though. It could be useful to say in the syspref description that the option will be available on the tools page once it is enabled. In members-home.pl, searching without any criteria brings all the patrons. I would expect the same behavior here (return all the deleted patrons instead of the "Please fill out at least one search field." message). It should not be an issue since the search results are paginated. Otherwise, it works as expected and I'd be happy to sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189781|0 |1 is obsolete| | --- Comment #48 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189940&action=edit Bug 34069: Add restore_deleted_borrowers permission and new system preference 1. APPLY PATCH, updatedatabase, restart_all 2. Now setup two users for testing, a superlibrarian and a limited permission user. The limited permission should have staff access and the restore_deleted_borrowers (tools) permission. /* SUPERLIBRARIAN */ 3. As superlibrarian, find the 'AllowDeletedPatronRestoration' system preference and enable it. Also make sure BorrowersLog is turned on. 4. Go to Tools -> Restore deleted patrons 5. Read the warning/information about what can and cannot be restored. Ensure it all makes sense. 6. Now we must delete some borrowers, either 1 by 1 or with the batch deletion tool. 7. Back to the deletion tool ( Tools -> Restore deleted patrons ) 8. Search for some of your deleted patrons by any of the critrea available. ( Cardnumber, borrowernumber, first name, surname, category, branch, or date ) 9. Ensure that searching works well. 10. Now bring up a deleted patron, check the checbox to the left and click "Restore deleted patrons" 11. Now you should be able to see the that the patron was restored. 12. Click "View patron" to look at the restored patron record. 13. Go to the action logs and make sure that the restoration was logged. /* LIMITED PERMISSION USER */ 14. Now log in as your limited permission user. 15. Go to Tools -> Restore deleted patrons 16. As a limited permssion user you should only be able to search for deleted borrowers from your branch, or branches in your library group. 17. Repeat all the steps to restore a patron, ensuring everything works. Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189782|0 |1 is obsolete| | --- Comment #49 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189941&action=edit Bug 34069: Implement tool for restoring deleted patrons Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189783|0 |1 is obsolete| | --- Comment #50 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189942&action=edit Bug 34069: Log patron restoration Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189784|0 |1 is obsolete| | --- Comment #51 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189943&action=edit Bug 34069: Add a CannotRestore exception and throw when the userid, borrowernumber, or cardnumber is already in use Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189785|0 |1 is obsolete| | --- Comment #52 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189944&action=edit Bug 34069: Add ability to search on updated_on dates Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189786|0 |1 is obsolete| | --- Comment #53 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189945&action=edit Bug 34069: Deal with view_borrower_infos_from_any_libraries Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189787|0 |1 is obsolete| | --- Comment #54 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189946&action=edit Bug 34069: Add information about what can and cannot be restored Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189788|0 |1 is obsolete| | --- Comment #55 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189947&action=edit Bug 34069: Move permission from borrower to tools Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189789|0 |1 is obsolete| | --- Comment #56 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189948&action=edit Bug 34069: Fix HTML, Bootstrap classes, and QA complaints Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189790|0 |1 is obsolete| | --- Comment #57 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189949&action=edit Bug 34069: Add unit tests Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189791|0 |1 is obsolete| | --- Comment #58 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189950&action=edit Bug 34069: Fix categorycode/branch info, open in new tab, and other fixes Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189792|0 |1 is obsolete| | --- Comment #59 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189951&action=edit Bug 34069: Adjust before and after date search Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189793|0 |1 is obsolete| | --- Comment #60 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189952&action=edit Bug 34069: Prevent search if no search critrea Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189794|0 |1 is obsolete| | --- Comment #61 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189953&action=edit Bug 34069: Allow for multiselection of branch and category Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189795|0 |1 is obsolete| | --- Comment #62 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189954&action=edit Bug 34069: Logaction should not be in all caps Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189945|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189946|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189948|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189949|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197877&action=edit Bug 34069: Add restore_deleted_borrowers permission and new system preference 1. APPLY PATCH, updatedatabase, restart_all 2. Now setup two users for testing, a superlibrarian and a limited permission user. The limited permission should have staff access and the restore_deleted_borrowers (tools) permission. /* SUPERLIBRARIAN */ 3. As superlibrarian, find the 'AllowDeletedPatronRestoration' system preference and enable it. Also make sure BorrowersLog is turned on. 4. Go to Tools -> Restore deleted patrons 5. Read the warning/information about what can and cannot be restored. Ensure it all makes sense. 6. Now we must delete some borrowers, either 1 by 1 or with the batch deletion tool. 7. Back to the deletion tool ( Tools -> Restore deleted patrons ) 8. Search for some of your deleted patrons by any of the critrea available. ( Cardnumber, borrowernumber, first name, surname, category, branch, or date ) 9. Ensure that searching works well. 10. Now bring up a deleted patron, check the checbox to the left and click "Restore deleted patrons" 11. Now you should be able to see the that the patron was restored. 12. Click "View patron" to look at the restored patron record. 13. Go to the action logs and make sure that the restoration was logged. /* LIMITED PERMISSION USER */ 14. Now log in as your limited permission user. 15. Go to Tools -> Restore deleted patrons 16. As a limited permssion user you should only be able to search for deleted borrowers from your branch, or branches in your library group. 17. Repeat all the steps to restore a patron, ensuring everything works. Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197878&action=edit Bug 34069: Implement tool for restoring deleted patrons Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197879&action=edit Bug 34069: Log patron restoration Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #66 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197880&action=edit Bug 34069: Add a CannotRestore exception and throw when the userid, borrowernumber, or cardnumber is already in use Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197881&action=edit Bug 34069: Add ability to search on updated_on dates Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #68 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197882&action=edit Bug 34069: Deal with view_borrower_infos_from_any_libraries Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #69 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197883&action=edit Bug 34069: Add information about what can and cannot be restored Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #70 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197884&action=edit Bug 34069: Move permission from borrower to tools Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #71 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197885&action=edit Bug 34069: Fix HTML, Bootstrap classes, and QA complaints Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197886&action=edit Bug 34069: Add unit tests Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197887&action=edit Bug 34069: Fix categorycode/branch info, open in new tab, and other fixes Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197888&action=edit Bug 34069: Adjust before and after date search Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197889&action=edit Bug 34069: Prevent search if no search critrea Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197890&action=edit Bug 34069: Allow for multiselection of branch and category Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #77 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197891&action=edit Bug 34069: Logaction should not be in all caps Signed-off-by: Katie Bliss <kebliss@dmpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #78 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197892&action=edit Bug 34069: (follow-up) Add Koha.CSPNonce Patch from commit c9f0174 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #79 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased and small QA follow-up, setting back to Signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jacob.omara@openfifth.co.uk |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #80 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206115&action=edit Bug 34069: (QA follow-up) Remove duplicate Security pref heading was causing some preferences to be hidden from the UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #81 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206116&action=edit Bug 34069: (QA follow-up) Enforce branch limits server-side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #82 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206117&action=edit Bug 34069: (QA follow-up) Make syspref protect the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #83 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206118&action=edit Bug 34069: (QA follow-up) Skip cardnumber check when NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #84 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206119&action=edit Bug 34069: (QA follow-up) Add missing USE Koha for Koha.CSPNonce -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #85 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206120&action=edit Bug 34069: (QA follow-up) Keep delete warning when pref is off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #86 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206121&action=edit Bug 34069: (QA follow-up) Add email input to the search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #87 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206122&action=edit Bug 34069: (QA follow-up) Show when results are truncated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #88 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206123&action=edit Bug 34069: (QA follow-up) Fix missing and unused imports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #89 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206124&action=edit Bug 34069: (QA follow-up) Replace Bootstrap 3 grid classes with Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #90 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206125&action=edit Bug 34069: (QA follow-up) Make alert translatable and fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #91 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206126&action=edit Bug 34069: (QA follow-up) Use current alert classes for dialogs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #92 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206127&action=edit Bug 34069: (QA follow-up) Rename restore_deleted_borrower to restore Matching to restore biblios/items work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #93 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206128&action=edit Bug 34069: (QA follow-up) Say patrons, not borrowers for front facing ui -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #94 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206129&action=edit Bug 34069: (QA follow-up) Show the restore tool in the tools sidebar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #95 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206130&action=edit Bug 34069: (QA follow-up) Add tests for restore conflicts and clearing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #96 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206131&action=edit Bug 34069: Add to_api_mapping to Koha::Old::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #97 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206132&action=edit Bug 34069: Add /deleted/patrons REST endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #98 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206133&action=edit Bug 34069: Add API tests for /deleted/patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #99 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206134&action=edit Bug 34069: Use API-backed table in restore deleted patrons tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #100 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206135&action=edit Bug 34069: Require list_borrowers to view deleted patron PII -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #101 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206136&action=edit Bug 34069: Gate the deleted patrons list on the system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #102 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206137&action=edit Bug 34069: Add API tests for library limits and query filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #103 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206138&action=edit Bug 34069: Simplify the library list in the restore patrons tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #104 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206139&action=edit Bug 34069: Share the restore page message helper -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34069 --- Comment #105 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206140&action=edit Bug 34069: Rework deleted patron table filters and restore messages -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org