[Bug 42102] New: Z39.50 ISBN sometimes fails when right truncation provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 Bug ID: 42102 Summary: Z39.50 ISBN sometimes fails when right truncation provided Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl I've noticed that the Z39.50 search for ISBN no longer works for the Library of Congress. It appears that their support for the @attr 5=1 right truncation has changed. If you provide the full ISBN, it will fail. If you provide a partial, it will succeed. The way to work around this is to try both with and without truncation. (Note that places like the National Library of Medicine in the USA will let you provide @attr 5=1 but it doesn't actually perform the right truncation on your ISBN search.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 195381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195381&action=edit Bug 42102: Try with and without right truncation for ISBN This change widens the ISBN search to try with and without right truncation as different Z39.50 servers appear to handle this differently. Some will ignore it and others will fail to return a result if a full ISBN is provided (like with the Library of Congress currently) Test plan: 0. Do not apply the patch yet 1. Log into koha-testing-docker 2. Do a ISBN search for 9780879933913 for the Library of Congress (Note to use the Z39.50 and NOT the SRU) 3. Note that it doesn't return any results 4. Apply the patch and koha-plack --restart kohadev 5. Do a ISBN search for 9780879933913 for the Library of Congress (Note to use the Z39.50 and NOT the SRU) 6. Note that you get a result 7. Do a ISBN search for 978087993391 for the Library of Congress 8. Note that you get a result with the partial ISBN -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 195382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195382&action=edit Bug 42102: Try with and without right truncation for ISBN This change widens the ISBN search to try with and without right truncation as different Z39.50 servers appear to handle this differently. Some will ignore it and others will fail to return a result if a full ISBN is provided (like with the Library of Congress currently) Test plan: 0. Do not apply the patch yet 1. Log into koha-testing-docker 2. Do a ISBN search for 9780879933913 for the Library of Congress (Note to use the Z39.50 and NOT the SRU) 3. Note that it doesn't return any results 4. Apply the patch and koha-plack --restart kohadev 5. Do a ISBN search for 9780879933913 for the Library of Congress (Note to use the Z39.50 and NOT the SRU) 6. Note that you get a result 7. Do a ISBN search for 978087993391 for the Library of Congress 8. Note that you get a result with the partial ISBN Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Occasionally getting this error after the patch: - Present request out of range (ref. 13) for LIBRARY OF CONGRESS result 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #3)
Occasionally getting this error after the patch:
- Present request out of range (ref. 13) for LIBRARY OF CONGRESS result 1
Technically, you'd get that error before the patch too on a successful search. That's an outstanding issue I've found with the Library of Congress Z39.50 MetaProxy implementation. I'm waiting to hear back from the Library of Congress networking team. At the moment, I suspect that there's 1+ bad nodes behind their proxy which cause intermittent failures. Very annoying... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195382|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 195827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195827&action=edit Bug 42102: Try with and without right truncation for ISBN This change widens the ISBN search to try with and without right truncation as different Z39.50 servers appear to handle this differently. Some will ignore it and others will fail to return a result if a full ISBN is provided (like with the Library of Congress currently) Test plan: 0. Do not apply the patch yet 1. Log into koha-testing-docker 2. Do a ISBN search for 9780879933913 for the Library of Congress (Note to use the Z39.50 and NOT the SRU) 3. Note that it doesn't return any results 4. Apply the patch and koha-plack --restart kohadev 5. Do a ISBN search for 9780879933913 for the Library of Congress (Note to use the Z39.50 and NOT the SRU) 6. Note that you get a result 7. Do a ISBN search for 978087993391 for the Library of Congress 8. Note that you get a result with the partial ISBN Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- GIT URL| |42321 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This seems to be related to bug 42321 which is also triggered by LOC failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The LOC SRU server does return a result without this patch. And the Z39.50 one does not. The problem seems to be on their side. Do we want this for all searches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #7)
The LOC SRU server does return a result without this patch. And the Z39.50 one does not. The problem seems to be on their side.
Yeah, the LOC Z39.50 server is awful.
Do we want this for all searches?
No, just ones with right truncation. At a glance, ISSN would need it as well. Possibly some others if they use @attr 5=1 as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jacob.omara@openfifth.co.uk |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I was going to mark this FQA due to missing POD in the _bib_build_query sub, but then I saw your discussion on Bug 43391 and at https://gitlab.com/koha-community/qa-test-tools/-/work_items/103#note_316781... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- But otherwise this makes sense and works well, happy to QA it and let Jacob worry about something more complicated :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jacob.omara@openfifth.co.uk |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42102 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Based on further conversation, I am marking this FQA for missing POD on private subroutines. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org