https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 With mulitple instances on one server I'd really love that. Turning things off for just one instance is painful otherwise if you are using for-each. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Duplicate of "Bug 7972 - GUI for Crons"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Magnus Enger from comment #4)

Duplicate of "Bug 7972 - GUI for Crons"?

Hmm possibly. That bug seems to want to have full crontab access from the web, especially in regards to time scheduling, which sounds terrible to me as a vendor. But maybe I was misinterpreting the comments there. Nick's suggestion seems to be more about just enabling/disabling and configuring scheduled tasks, which sounds good to me. It wouldn't actually affect cron's operation. Rather, it would affect the scripts executed by cron. Much more reasonable. I suppose an easy way to bolt this on would be to expand Koha::Script (or a Koha::Script::* module). There could be an "is_enabled" function, and a "get_script_config" function. (Regarding Bug 7972, you could perhaps have some config that prevents the script from running during certain times. I think process_message_queue.pl runs every 15 minutes, but we've hard-coded our crontab to only run between 8:00-20:00 so emails don't go out late at night. With this feature, a library could designate their own "do not run" hours. Of course, this would only work if the cronjob is ordinarily set to run during those "do not run" hours, if that makes sense.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- I'm bumping into this with "/usr/share/koha/bin/cronjobs/membership_expiry.pl" where 1 library wants to send notices to only some categories. In the past, we added a --category option, but that only worked when we set up cronjobs per-library instead of using koha-foreach. I think that I'm just going to use a local system preference here and a local code customization, but it would be useful for libraries to be able to define their own parameters via the web UI for this cronjob... Really this is a "scheduled task" issue. Not just "cronjobs". In the future, we may have other schedulers in addition to the cron daemon. So whatever solution we come up with... it should be fairly extensible. Scheduled Task: Name: MembershipExpiry Args: Categories: ['Staff','Students','Administrators'] Branches: ['CPL','MPL','QPL'] Letter: A cronjob could fetch using my $task = ScheduledTask->GetByName('MembershipExpiry'); You could even arguably add "Min time interval" (maybe the cronjob runs every 15 minutes but you only want the job to run no faster than 1 time per hour) and "Last run" to try to control timing a bit... Anyway, just some thoughts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #6)

Really this is a "scheduled task" issue. Not just "cronjobs". In the future, we may have other schedulers in addition to the cron daemon. So whatever solution we come up with... it should be fairly extensible.

Scheduled Task: Name: MembershipExpiry Args: Categories: ['Staff','Students','Administrators'] Branches: ['CPL','MPL','QPL'] Letter:

If we're going to use system preference though, it makes sense to group them in with their relevant areas... like "Self Registration". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd forgotten about this bug.. I'd love to see this move forward.. no idea if/when I'll have time to work on it.. but still think it's a great idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Thinking a bit about this at the end of the hackfest... Question: Do we want the sysprefs or the command line options to "have the last word"? One of the arguments for having sysprefs is that we could run the cronjob with koha-foreach, and still have different choices for different libraries. So that would indicate that sysprefs should "have the last word". Then there is the question of how to implement this. We could have one syspref per command line option, and do something like this: exit unless C4::Context->preference('CronAutomaticRenewalsActivate'); my ( $help, $send_notices, $verbose, $confirm, $digest_per_branch ); GetOptions( 'h|help' => \$help, 's|send-notices' => \$send_notices, 'v|verbose' => \$verbose, 'c|confirm' => \$confirm, 'b|digest-per-branch' => \$digest_per_branch, ) || pod2usage(1); $send_notices = C4::Context->preference('CronAutomaticRenewalsSendNotices'); $verbose = C4::Context->preference('CronAutomaticRenewalsVerbose'); $confirm = C4::Context->preference('CronAutomaticRenewalsConfirm'); $digest_per_branch = C4::Context->preference('CronAutomaticRenewalDigestPerBranch'); This would introduce a lot of new sysprefs, and we would have to add a new syspref when a new command line switch was added. On the other hand it would be easy to add descriptions for each setting, and link to related sysprefs. Another approach could be to have two sysprefs per cronjob, one to turn it on and off, and one to do the configuration. This could be done with YAML: send_notices: 1 verbose: 0 confirm: 1 digest_per_branch: 0 Then we could perhaps do something like this: $send_notices = get_cronjob_setting( 'CronAutomaticRenewals', 'send_notices' ); This way we could add new command line options without adding a new syspref, but editing YAML in a text field might not be the most user friendly interface. Are there other syntaxes that would be as flexible, but more user friendly? There there is of course the possibilty of some whole new tool to edit the options, but that is not something to think about at the end of a hackfest... So just some thoughts to get the ball rolling and try and provoke folks to come up with better ideas than mine. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Syspref controls for |Add system preference |cronjobs |controls for cronjobs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Chris Rowlands <chris.rowlands6@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.rowlands6@nhs.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- More work required still as it's an unfunded piece.. but I do have the beginnings of a plugin for a "crontab manager" over at https://github.com/PTFS-Europe/koha-plugin-crontab I still think making our cron scripts all use preferences for their option rather than requiring lots of options be passed in the command line is a good thing though too -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.