https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Export all petron related |Export all patron related |personal data in one |personal data in one |package |package -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- We discussed it on GDPR meeting and agreed it could be done as API endpoint with access via a button in staff client and opac. By the GDPR, the data should be in commonly used machine readable format. So JSON from REST API is OK. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #3 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Note that my patch above is just the scaffolding to support this - it needs the APIs to extract all the data to be available and then call those. The alternative is to write a new script to gather all the patron data in a single data structure and then return that as JSON. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75622|0 |1 is obsolete| | --- Comment #5 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 78095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78095&action=edit Bug 20028: Export all patron related personal data in one package Modifies the readingrec.pl script to give the option to generate a JSON encoded version of the data held about the patron. Currently exports basic patron (borrower table) data, patron image, holds (reserves), old holds, checkouts (issues), old checkouts and accounting information. Test plan: Turn on the syspref, select a patron from the staff intranet, and then choose "Export patron's GDPR data" from the "More..." menu. You should then get a JSON file downloaded to the machine running your web browser. Compare the data in that file with the data shown on the intranet displays for that patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |J.P.Knight@lboro.ac.uk |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75622|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75622|0 |1 is obsolete| | Attachment #78095|0 |1 is obsolete| | --- Comment #6 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 79376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79376&action=edit Bug 20028: Export all patron related personal data in one package Add a system preference to determine whether patron data export is permitted, and if it is an extra option in the staff UI to initiate the export. At this stage the API for patron data isn't ready so as a placeholder it just goes to the readingrec.pl script. Testing plan: * Apply patch. * Turn the AllowGDPRPatronExport in the administration sysprefs * Search for a patron (eg Mabel in the standard test data) and then click on the "More" button on the right hand side of the button bar. You should see "Export patron's GDPR data" option. Selecting that will generate and download a JSON file containing the patron's data to your client machine. * Turn off AllowGDPRPatronExport in the administration sysprefs * The "Export patron's GDPR data" option should no long be visible from the "More" button in the patron page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79376|0 |1 is obsolete| | --- Comment #7 from Michal Denar <black23@gmail.com> --- Created attachment 79381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79381&action=edit Bug 20028: Export all patron related personal data in one package Add a system preference to determine whether patron data export is permitted, and if it is an extra option in the staff UI to initiate the export. At this stage the API for patron data isn't ready so as a placeholder it just goes to the readingrec.pl script. Testing plan: * Apply patch. * Turn the AllowGDPRPatronExport in the administration sysprefs * Search for a patron (eg Mabel in the standard test data) and then click on the "More" button on the right hand side of the button bar. You should see "Export patron's GDPR data" option. Selecting that will generate and download a JSON file containing the patron's data to your client machine. * Turn off AllowGDPRPatronExport in the administration sysprefs * The "Export patron's GDPR data" option should no long be visible from the "More" button in the patron page. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #9 from Michal Denar <black23@gmail.com> --- Jon, sorry ... forgota my last comment. I tried export data from devbox with limited circulation history. So export contains limitex range of data, ofcourse. We talked about with Josef and debate around Your code. All relevant date are in export. Good work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #10)

IMO it's not conceivable to push this code as it. We cannot have such code in .pl, without tests, etc.

Why not just a $patron->unblessed then use columns.def instead of listing of the patron's attributes?

Hm, i am just thinking about using $RESULTSET_PATRON_ID_MAPPING from Koha::Patron and define the method Koha::Patron->takeout - does it make sense?

Also found a typo: + 'dateoffbirth' => $patron->dateofbirth,

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)

IMO it's not conceivable to push this code as it. We cannot have such code in .pl, without tests, etc.

Why not just a $patron->unblessed then use columns.def instead of listing of the patron's attributes?

Also found a typo: + 'dateoffbirth' => $patron->dateofbirth,

Please adjust status if something fails qa ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #14)

Please move code to module. Makes it easier to test too.

I wanted to get other opinions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #17 from Magnus Enger <magnus@libriotech.no> --- (In reply to Jon Knight from comment #16)

I'm not sure what is now expected for me to take this forward? Were there other opinions? Is there a particular module this should be going in? Is it even wanted?

I think the "verdict" from the QA-team is that the code needs to be moved to a module in the Koha namespace, with tests. I wonder if it would make sense to implement this as a plugin? Not to bypass QA, but because the functionality will only be of interest to a subset of those libraries that do have patrons. It would also decouple the development from the release cycles of Koha itself. Thoughts? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|J.P.Knight@lboro.ac.uk |lari.taskula@hypernova.fi --- Comment #19 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #18)

I can try to rescue this Bug. Jon kindly agreed to this. Setting myself as assignee.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #21 from Lari Taskula <lari.taskula@hypernova.fi> --- What about using DBIx to determine the chain of relations to the borrowers-table? This way we could keep it dynamic, only relying on the foreign keys in our database schema. The issue then is to format this data in a nice way, suitable for REST API output. But I believe this is an issue with any approach we take. Of course some Koha::Schema::Result::* already correspond to a Koha::Object that may have a database.column <=> API-terminology mapping, but I would imagine a lot of them do not. Should we first implement something that simply returns all the data related to a patron, and if someone wants to focus on formatting it nicely, then solve that issue in another Bug? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630 [Bug 27630] TestBuilder real number precision to use column's size -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #24 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #21)

What about using DBIx to determine the chain of relations to the borrowers-table? This way we could keep it dynamic, only relying on the foreign keys in our database schema. Example of this in comment #23. I have also created an RFC for the endpoint, see https://wiki.koha-community.org/wiki/Public_patrons_export_endpoint_RFC

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #25 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Lari Taskula from comment #22)

Another issue is how far do we want to expand the results? As an example, a patron has checked out items, do we return just the itemnumbers or should we expand the item object such that eventually we have the biblio itself (it might be interesting to know, say, the biblio.title)? I suppose expanding it all the way to biblio_metadata.metadata would be pretty hardcore?

If we return only itemnumbers then the item data have to be fetched from items-endpoint. It is not very efficient to have hundreds of API calls to get rest of the data. I think it is better to have at least an expanded endpoint for more information. Pagination options are mandatory since the return data be massive. -- You are receiving this mail because: You are watching all bug changes.

If we return only itemnumbers then the item data have to be fetched from items-endpoint. It is not very efficient to have hundreds of API calls to get rest of the data. I think it is better to have at least an expanded endpoint for more information. Good point. While one could argue that since item data is not directly part of

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #26 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Johanna Räisä from comment #25) patron related data and should not be returned, I can see use cases where it makes sense to expand. Expanded objects contain a lot unwanted data, so we would have to select which columns to expand. By the way, there are 52 tables that are directly related to a patron via DBIx relationship (meaning foreign keys in borrowers table, or foreign keys in other tables pointing to borrowers). These are: 3 belongs_to relationship (borrowers refer to primary key in other table): branches categories sms_providers (the three tables above have a lot of data that should probably be left out?) 49 has_many relationship (tables that refer to borrowers): accountlines advanced_editor_macros alert api_keys aqbasketusers aqbudgetborrowers aqorder_users aqorders article_requests borrower_attributes borrower_debarments borrower_files borrower_message_preferences borrower_relationships cash_register_actions club_enrollments club_holds_to_patron_holds course_instructors creator_batches discharges hold_fill_targets housebound_profile housebound_role housebound_visit illcomments illrequests issues items_last_borrower message_queue messages old_issues old_reserves opac_news patron_consent patron_list_patrons patron_lists patronimage problem_reports ratings reserves return_claims reviews subscriptionroutinglist tags_all tags_approval user_permissions virtualshelfcontents virtualshelfshares virtualshelves (most of the ones above could be fully included?)

Pagination options are mandatory since the return data be massive. It's a costly operation to get all of that data in the first place. Especially if we expand it. If we paginate it (it's a good idea), should we cache the result for some time? Performance tests will come in handy.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116604|0 |1 is obsolete| | --- Comment #28 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 117106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117106&action=edit Bug 20028: Add Koha::Patron->export The logic behind gathering related data relies on DBIx relationships to Borrower source. This patch does not care about terminology - it returns related data in a hashref containing keys of DBIx source class names, such as Borrower. To test: 1. prove t/db_dependent/Koha/Patron.t 2. Observe success Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #30 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 117108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117108&action=edit Bug 20028: Add OpenAPI spec Includes a test that validates the existence of all related properties. To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #32 from Lari Taskula <lari.taskula@hypernova.fi> --- Added four patches containing a very basic functionality for exporting patron related data. It iterates DBIx Borrower relationships and returns a huge hashref in the following format:

{ "Accountline": [ { "accountline_id": 1, "borrowernumber": 1481, ... }, { "accountline_id": 2, "borrowernumber": 1481, ... } ], "Borrower": { "borrowernumber": 1481, "firstname": "Export", ... }, ..., "Virtualshelve": [ { "shelfnumber": 1, "owner": 1481, ... }, { "shelfnumber": 2, "owner": 1481, ... } ] }

Returns the same thing from REST API, from these two endpoints: GET /api/v1/patrons/123/export (privileged) GET /api/v1/public/patrons/123/export (unprivileged) So it does not yet follow our terminology rules nor add any pagination. Anyway, thoughts about the DBIx relationship approach? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #33 from Michal Denar <black23@gmail.com> --- Lari, is this patch ready to testing? Because status is still In Discussion. Thank you. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117106|0 |1 is obsolete| | --- Comment #35 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 119968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119968&action=edit Bug 20028: Add Koha::Patron->export The logic behind gathering related data relies on DBIx relationships to Borrower source. This patch does not care about object name terminology - it returns related data in a hashref containing keys of DBIx source class names, such as Borrower. Return example: { "Borrower" => Koha::Patron, "BorrowerMessagePreference" => DBIx::Class::ResultSet, "ReturnClaim" => Koha::Checkouts::ReturnClaims } This has the benefit of giving caller the ability to format response as they want. For example, you can then easily use the "unblessed" or "to_api" representation of the object. To test: 1. prove t/db_dependent/Koha/Patron.t 2. Observe success Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117108|0 |1 is obsolete| | --- Comment #37 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 119970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119970&action=edit Bug 20028: Add OpenAPI spec Includes a test that validates the existence of all related properties. To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #41 from Michal Denar <black23@gmail.com> --- Created attachment 119975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119975&action=edit Bug 20028: Add a system preference for patron data export Add a system preference to determine whether patron data export is permitted. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #43 from Michal Denar <black23@gmail.com> --- Created attachment 119977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119977&action=edit Bug 20028: Add Patron Export REST controller This patch adds a REST controller for patron data exporting. GET /api/v1/patrons/51/export GET /api/v1/public/patrons/51/export Supports pagination parameters "_per_page" and "_page". Response is an array that contains "_per_page" amount of objects, each with the following format: { "data": {the object, e.g. patron} "type": DBIx source name, e.g. "Borrower" } Example response: [ { "data":{ "address":null, ..., "patron_id":1, ... }, "type":"Borrower" }, { "data":{ "borrower_message_preference_id":24, "borrowernumber":1, ..., "wants_digest":1 }, "type":"BorrowerMessagePreference" }, { "data":{ "auto_renew":false, ..., "checkout_id":97, "due_date":"2021-02-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"Issue" }, { "data":{ "auto_renew":false, ..., "checkout_id":42, "due_date":"2021-01-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"OldIssue" } ] To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119975|0 |1 is obsolete| | --- Comment #45 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 120845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120845&action=edit Bug 20028: Add a system preference for patron data export Add a system preference to determine whether patron data export is permitted. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119977|0 |1 is obsolete| | --- Comment #47 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 120847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120847&action=edit Bug 20028: Add Patron Export REST controller This patch adds a REST controller for patron data exporting. GET /api/v1/patrons/51/export GET /api/v1/public/patrons/51/export Supports pagination parameters "_per_page" and "_page". Response is an array that contains "_per_page" amount of objects, each with the following format: { "data": {the object, e.g. patron} "type": DBIx source name, e.g. "Borrower" } Example response: [ { "data":{ "address":null, ..., "patron_id":1, ... }, "type":"Borrower" }, { "data":{ "borrower_message_preference_id":24, "borrowernumber":1, ..., "wants_digest":1 }, "type":"BorrowerMessagePreference" }, { "data":{ "auto_renew":false, ..., "checkout_id":97, "due_date":"2021-02-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"Issue" }, { "data":{ "auto_renew":false, ..., "checkout_id":42, "due_date":"2021-01-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"OldIssue" } ] To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120845|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124157&action=edit Bug 20028: Add a system preference for patron data export Add a system preference to determine whether patron data export is permitted. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120847|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124159&action=edit Bug 20028: Add Patron Export REST controller This patch adds a REST controller for patron data exporting. GET /api/v1/patrons/51/export GET /api/v1/public/patrons/51/export Supports pagination parameters "_per_page" and "_page". Response is an array that contains "_per_page" amount of objects, each with the following format: { "data": {the object, e.g. patron} "type": DBIx source name, e.g. "Borrower" } Example response: [ { "data":{ "address":null, ..., "patron_id":1, ... }, "type":"Borrower" }, { "data":{ "borrower_message_preference_id":24, "borrowernumber":1, ..., "wants_digest":1 }, "type":"BorrowerMessagePreference" }, { "data":{ "auto_renew":false, ..., "checkout_id":97, "due_date":"2021-02-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"Issue" }, { "data":{ "auto_renew":false, ..., "checkout_id":42, "due_date":"2021-01-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"OldIssue" } ] To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124161&action=edit Bug 20028: (QA follow-up) Add atomic update for new pref Setting the initial value to 0 just to be on the safe side. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #58 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Marcel de Rooy from comment #50)

You removed the signoff lines of Michal?

Good spot, I'm pretty sure this happened by accident. I probably didn't pull Michal's signed-off patches before rebasing. Shall I add it back? Also I agree with setting syspref default to 0. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124156|0 |1 is obsolete| | --- Comment #60 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 124164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124164&action=edit Bug 20028: Add Koha::Patron->export The logic behind gathering related data relies on DBIx relationships to Borrower source. This patch does not care about object name terminology - it returns related data in a hashref containing keys of DBIx source class names, such as Borrower. Return example: { "Borrower" => Koha::Patron, "BorrowerMessagePreference" => DBIx::Class::ResultSet, "ReturnClaim" => Koha::Checkouts::ReturnClaims } This has the benefit of giving caller the ability to format response as they want. For example, you can then easily use the "unblessed" or "to_api" representation of the object. To test: 1. prove t/db_dependent/Koha/Patron.t 2. Observe success Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124159|0 |1 is obsolete| | --- Comment #62 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 124166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124166&action=edit Bug 20028: Add Patron Export REST controller This patch adds a REST controller for patron data exporting. GET /api/v1/patrons/51/export GET /api/v1/public/patrons/51/export Supports pagination parameters "_per_page" and "_page". Response is an array that contains "_per_page" amount of objects, each with the following format: { "data": {the object, e.g. patron} "type": DBIx source name, e.g. "Borrower" } Example response: [ { "data":{ "address":null, ..., "patron_id":1, ... }, "type":"Borrower" }, { "data":{ "borrower_message_preference_id":24, "borrowernumber":1, ..., "wants_digest":1 }, "type":"BorrowerMessagePreference" }, { "data":{ "auto_renew":false, ..., "checkout_id":97, "due_date":"2021-02-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"Issue" }, { "data":{ "auto_renew":false, ..., "checkout_id":42, "due_date":"2021-01-19T23:59:00+00:00", ..., "patron_id":1, ... }, "type":"OldIssue" } ] To test: 1. prove t/db_dependent/api/v1/patrons_export.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124161|0 |1 is obsolete| | --- Comment #64 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 124168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124168&action=edit Bug 20028: (QA follow-up) Add atomic update for new pref Setting the initial value to 0 just to be on the safe side. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #66 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm looking at it. It is quite a complex code scrapping DBIx datas. I my opinion it should not send "type":"Borrower". The database names are not the current terminology for objects. Better use module name Koha::Patron, so it is easy to guess one must call API on route '/api/v1/patron' I will try to gather feedback at hackfest next week. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com --- Comment #68 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, As a librarian, I'm interested in this feature but I thought a SQL report or a slip (with Template Toolkit) could do the job. I'm really naïve ^^. After reading this BZ, I understand it's a bit more complicated than this. Is there any chance to make that BZ alive again ? -- You are receiving this mail because: You are watching all bug changes.