[Bug 9525] New: group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Bug ID: 9525 Summary: group floating rules Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It would be handy if you could create groups for floating rules. Right now you can set an item type to float in the circ and fine rules, but there is no way to specific which branches it floats between. This would be a development for consortia so that nearby libraries can have floating collections but not necessarily the entire system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- We need the same thing ASAP. We just added a few bookmobiles which need floating between their parent libraries and are shifting priorities to try to solve this issue ASAP. This is an awkward pending issue for us and hopefully I can deliver an acceptable solution soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 40077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40077&action=edit Bug 9525 - group floating rules Cucumber integration tests included. run t/Cucumber/runCucumberTests.pl --tags @floatingMatrix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14188, 14187, 13995, 13096 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13096 |13906 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, nice feature! Can you please add a test plan? Also some files need a Licence and others need an updated one (from 2 -> 3) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Hi Bernardo. Sorry I must focus on other things. I am happy I even managed to rebase and push all things to bugzilla. If you like it, you can write a test plan. Tho I am 100% sure the dependencies will go stale in 1 week and then nobody but a programmer can test this :) And that kind of testing implies a code review. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- But it is a nice feature and works remarkably well for us. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Olli-Antti Kivilahti from comment #5)
But it is a nice feature and works remarkably well for us.
Great :) Is it possible a short description of the use case scenario? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 40102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40102&action=edit Admin menu screenshot, how to navigate to the control panel -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 40103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40103&action=edit The floating matrix control panel where you configure the 4 types of floating between routes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- This screenshot: The floating matrix control panel where you configure the 4 types of floating between routes. Explains how to use this feature. Then just check-in Items and they float based on the rules. If you don't want to use this feature, don't set any floating routes and it is completely unintrusive. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Thanks for pushing Bernardo. I hope images are worth more than 100 words ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- In production for ~3 weeks. Working fine and helping a lot! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- Would test if it had a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- +-----------------------------+ | USAGE TIPS (sorry didn't document these in the GUI | +-----------------------------+ When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule. The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression. +-----------------------------+ | SETTING UP THE TEST CONTEXT | +-----------------------------+ -2. Set syspref "HomeOrHoldingBranchReturn" to homebranch. -1. Find an Item, which can be circulated freely, and has homebranch B and any holdingbranch. 0. Read the instructions at admin/floating-matrix.pl. +-----------+ | TEST PLAN: Disabled floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Disabled" and vice versa (B -> A). 1. Set your current library to A. 2. Check-in the Item. 3. Observe the started transport to branch B. 4. Set your current library to B. 5. Check-in to receive the transfer. +-----------+ | TEST PLAN: Always floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Allowed". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is not transport prompt to branch B and the Item is not "in-transit" -state. +-----------+ | TEST PLAN: Possibly floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Possible". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is a transport prompt to branch B. You can decide if you want to transfer or no. +-----------+ | TEST PLAN: Conditional floating: +-----------+ 0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #14 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 44754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44754&action=edit Bug 9525 - group floating rules, floating rule tester :) Implemented a tester to floating-matrix.pl to more easily test the changes in the floating rules matrix "FloMax". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44754|0 |1 is obsolete| | --- Comment #15 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 44756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44756&action=edit Bug 9525 - group floating rules, floating rule tester :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #16 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 44760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44760&action=edit Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. instead of DELETE we GET the delete request so CGI works with it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- 40077 - Bug 9525 - group floating rules 44756 - Bug 9525 - group floating rules, floating rule tester :) 44760 - Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9525 - group floating rules fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9525 - group floating rules When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9525---group-floating-rules-MxbdS8.patch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org