[Bug 13624] New: Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Bug ID: 13624 Summary: Remove columns branchcode, categorytype from table overduerules_transport_types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: charles.farmer@inlibro.com QA Contact: testopia@bugs.koha-community.org Sponsored by Halland County Library This patch is a requirement to Bug #12771. Instead of keeping 'branchcode' and 'categorytype' in the table overduerules_transport_types, a foreign key named 'overduerules_fk' now references the appropriate entry in the table overduerules. This will be necessary once we start managing more than 3 levels of overdue notice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #1 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 35561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35561&action=edit Remove columns branchcode, categorytype from table overduerules_transport_types Sponsored by Halland County Library This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice In the database : - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport_types' In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' TEST PLAN --------- 1) Apply the patch 2) Run the script installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl - It will create new tables and migrate the data 3) Run Overdues.t. Tests should be successful -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |charles.farmer@inlibro.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Quick note: 1/ You should add the DB changes to the kohastructure.sql file 2/ This patch should not be pushed as it, it will break tools/overduerules.pl If I am not wrong, could you confirm that and explain how you would like to see the patches integrated into master? You have just said "this patch is a requirement to bug 12771". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35561|0 |1 is obsolete| | --- Comment #3 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 35587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35587&action=edit [PATCH] Bug #13624: Remove columns branchcode, categorytype from table overduerules_transport_types Sponsored by Halland County Library This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice In installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' TEST PLAN --------- 1) Apply the patch 2) Run the script installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl - It will create new tables and migrate the data 3) Run Overdues.t. Tests should be successful modified: C4/Overdues.pm new file: installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl modified: installer/data/mysql/kohastructure.sql modified: t/db_dependent/Overdues.t modified: tools/overduerules.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #4 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Jonathan Druart from comment #2)
Quick note: 1/ You should add the DB changes to the kohastructure.sql file 2/ This patch should not be pushed as it, it will break tools/overduerules.pl If I am not wrong, could you confirm that and explain how you would like to see the patches integrated into master? You have just said "this patch is a requirement to bug 12771".
1) The changes to kohastructure.sql were added in the newest patch 2) Indeed, tools/overduerules.pl had to be slightly changed in order to make things work. The new patch should fix any issues with that file. I'm submitting #13624 separate from #12771 in order to make 12771's patch a little lighter. The patch I just submitted can be applied as is. Does it answer your question? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Charles Farmer from comment #4)
(In reply to Jonathan Druart from comment #2)
Quick note: 1/ You should add the DB changes to the kohastructure.sql file 2/ This patch should not be pushed as it, it will break tools/overduerules.pl If I am not wrong, could you confirm that and explain how you would like to see the patches integrated into master? You have just said "this patch is a requirement to bug 12771".
1) The changes to kohastructure.sql were added in the newest patch 2) Indeed, tools/overduerules.pl had to be slightly changed in order to make things work. The new patch should fix any issues with that file.
I'm submitting #13624 separate from #12771 in order to make 12771's patch a little lighter. The patch I just submitted can be applied as is. Does it answer your question?
Perfect, thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12771 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- $ mysql MariaDB [koha]> drop database koha; MariaDB [koha]> create database koha CHARACTER SET utf8 COLLATE utf8_unicode_ci; $ git checkout master $ mysql < installer/data/mysql/kohastructure.sql $ git bz apply 13624 $ perl installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl DBD::mysql::db do failed: Duplicate foreign key constraint name 'koha/overduerules_fk' at installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl line 33. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #7 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Jonathan Druart from comment #6)
DBD::mysql::db do failed: Duplicate foreign key constraint name 'koha/overduerules_fk' at installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl line 33.
I changed the foreign key name and placed the changes in updatedatabase.pl instead of a stand alone file. I hope this solves the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35587|0 |1 is obsolete| | --- Comment #8 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 36122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36122&action=edit [PATCH] Bug #13624: Remove columns branchcode, categorytype from table overduerules_transport_types Sponsored by Halland County Library This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice In installer/data/mysql/updatedatabase.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' TEST PLAN --------- 1) Apply the patch 2) Run the script installer/data/mysql/updatedatabase.pl - It will create new tables and migrate the data 3) Run Overdues.t. Tests should be successful -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jesse@bywatersolutions.com --- Comment #9 from Jesse Maseto <jesse@bywatersolutions.com> --- I received a CONFLICT while trying to apply this patch. -Jesse CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug #13624: Remove columns branchcode, categorytype from table overduerules_transport_types -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36122|0 |1 is obsolete| | --- Comment #10 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 36494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36494&action=edit Bug #13624: Remove columns branchcode, categorytype from table overduerules_transport_types Sponsored by Halland County Library This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice In installer/data/mysql/updatedatabase.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' TEST PLAN --------- 1) Apply the patch 2) Run the script installer/data/mysql/updatedatabase.pl - It will create new tables and migrate the data 3) Run Overdues.t. Tests should be successful -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36494|0 |1 is obsolete| | --- Comment #11 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 36497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36497&action=edit Bug #13624: Remove columns branchcode, categorytype from table overduerules_transport_types Sponsored by Halland County Library This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice In installer/data/mysql/updatedatabase.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' TEST PLAN --------- 1) Apply the patch 2) Run the script installer/data/mysql/updatedatabase.pl - It will create new tables and migrate the data 3) Run Overdues.t. Tests should be successful Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Medium patch CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- 1/ On updating the overdue rules (overduerules.pl), I got: overduerules.pl: DBD::mysql::st execute failed: Column count doesn't match value count at row 1 at /home/koha/src/tools/overduerules.pl line 188. 2/ Provide a complete test plan 3/ The new DB column has to be inserted at the same place as in the kohastructure.sql file. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #13 from Blou <philippe.blouin@inlibro.com> --- Created attachment 37074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37074&action=edit Bugs 13624 - Test plan and fixes db scripts for overduerules migrations TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/updatedatabase.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate This patch also - simplifies (somewhat) updatedatabase.pl - modifies kohastructure.sql to match updatedatabase.pl (because I couldn't 'insert after' with a KEY constraint) - fixes database call -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36497|0 |1 is obsolete| | Attachment #37074|0 |1 is obsolete| | --- Comment #14 from Blou <philippe.blouin@inlibro.com> --- Created attachment 38288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38288&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #15 from Blou <philippe.blouin@inlibro.com> --- Created attachment 38289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38289&action=edit Bug 13624 - Correcting the atomicupdate/ file. Dev-only patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #16 from Blou <philippe.blouin@inlibro.com> --- There was merging issues with updatedatabase.pl. Now replaced by new method using atomicupdate/ directory. I hope it all works well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38288|0 |1 is obsolete| | --- Comment #17 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 38290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38290&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 38290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38290 Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types Review of attachment 38290: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13624&attachment=38290) ----------------------------------------------------------------- Could you please tidy the atomicupdate file a bit? (trailing space, uppercase the mysql kw, etc.) ::: installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl @@ +10,5 @@
+#if ( CheckVersion($DBversion) ) { + $dbh->do("SET FOREIGN_KEY_CHECKS=0"); + $dbh->do("ALTER TABLE overduerules RENAME old_overduerules"); + $dbh->do("CREATE TABLE overduerules ( + `overduerules_id` mediumint NOT NULL AUTO_INCREMENT,
Why mediumint? @@ +25,5 @@
+ `debarred3` int(1) DEFAULT '0', + PRIMARY KEY (`overduerules_id`) + ) ENGINE=InnoDB DEFAULT CHARSET=utf8;"); + $dbh->do("INSERT INTO overduerules(branchcode, categorycode, delay1, letter1, debarred1, delay2, debarred2, letter2, delay3, letter3, debarred3) SELECT * FROM old_overduerules"); + $dbh->do("DROP TABLE old_overduerules");
Is not possible to just add the primary key to the existing table? ::: installer/data/mysql/kohastructure.sql @@ -1713,4 @@
`delay3` int(4) default NULL, -- number of days after the item is overdue that the third notice is sent `letter3` varchar(20) default NULL, -- foreign key from the letter table to define which notice should be sent as the third notice `debarred3` int(1) default 0, -- is the patron restricted when the third notice is sent (1 for yes, 0 for no) - PRIMARY KEY (`branchcode`,`categorycode`)
I think we should keep this constraint too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #18)
::: installer/data/mysql/kohastructure.sql @@ -1713,4 @@
`delay3` int(4) default NULL, -- number of days after the item is overdue that the third notice is sent `letter3` varchar(20) default NULL, -- foreign key from the letter table to define which notice should be sent as the third notice `debarred3` int(1) default 0, -- is the patron restricted when the third notice is sent (1 for yes, 0 for no) - PRIMARY KEY (`branchcode`,`categorycode`)
I think we should keep this constraint too.
This is not clear. I meant we should keep branchcode and categorycode as a unique key. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #20 from Blou <philippe.blouin@inlibro.com> --- Hi Jonathan, I'll try to reply to these to the best of my knowledge 1) tidying : I'm on it, but I couldn't find much beside 3-4 keywords. No extra space, as this code had been through qa-test before. 2) mediumint : no valid reason whatsoever, reasoning prb lost in time, along with the initial coder. I'll change to int(11) 3) simple ALTER ADD : Well, I remembered trying, so I tried again and could not. The existing constraints, the relation to OTT, the auto_increment... Whatever I tried failed. I won't say it's "simpler this way", but I just couldn't make it work otherwise. 4) Took me a while to remember WHY we want it out. I guess it's premature, but this is the first step to allow for unlimited "steps", and as such that combo cannot be unique. BUT this being the first step, I cannot justify removing it yet, only that it will be more complicated to remove later. I WILL LEAVE IT IN, you being QA and all ;) Mini Patch coming... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #21 from Blou <philippe.blouin@inlibro.com> --- Created attachment 39920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39920&action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38289|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Applying: Bug 13624 - Tidying the atomicupdate file and kohastructure.sql fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl). Please rebase. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mtompset@hotmail.com --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- This applies just fine for me off of master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sorry but: % git fetch origin % git checkout -b bug_13624 origin/master % git clean -f -d % git bz apply 13624 Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 38290 - Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 39920 - Bug 13624 - Tidying the atomicupdate file and kohastructure.sql Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types Applying: Bug 13624 - Tidying the atomicupdate file and kohastructure.sql fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Please reupload the patches if they apply for you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38290|0 |1 is obsolete| | --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40329&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39920|0 |1 is obsolete| | --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40330&action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #27 from M. Tompsett <mtompset@hotmail.com> --- Except for Jonathan's comments, I've uploaded my patches, and they are identical. I don't see any differences. Not sure what status it should be, but I'll throw it to needs sign off instead of "Patch doesn't apply". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9296 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12772 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 [Bug 12772] Overdue Notice/Status triggers tool -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40329|0 |1 is obsolete| | --- Comment #28 from Martin Persson <xarragon@gmail.com> --- Created attachment 41684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41684&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Martin Persson <xarragon@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40330|0 |1 is obsolete| | --- Comment #29 from Martin Persson <xarragon@gmail.com> --- Created attachment 41685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41685&action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql Signed-off-by: Martin Persson <xarragon@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |xarragon@gmail.com --- Comment #30 from Martin Persson <xarragon@gmail.com> --- Tested these patches against origin/master commit 75d123d760d86f0e0d9f58d65874b40f6816008d. Both patches merged perfectly and both manual and automated tests passed. Tested with 3 categories and all tabs filled with complex, unique combinations of rules. Verified by screenshot before and after. Code looks good to me but I am unfamiliar with some SQL details. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Blou from comment #20)
4) Took me a while to remember WHY we want it out. I guess it's premature, but this is the first step to allow for unlimited "steps", and as such that combo cannot be unique. BUT this being the first step, I cannot justify removing it yet, only that it will be more complicated to remove later. I WILL LEAVE IT IN, you being QA and all ;)
Sorry, but I think that the constraint should not be removed in this patchset. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #32 from Charles Farmer <charles.farmer@inlibro.com> ---
From what I see, the last patch *did* keep branchode and category code as a unique key for table overduerules. Unless there are more things to change, this does not warrant any more discussion.
Since both available patches have been signed off by Marting Persson, I'm putting this to "Signed off". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Charles Farmer from comment #32)
From what I see, the last patch *did* keep branchode and category code as a unique key for table overduerules. Unless there are more things to change, this does not warrant any more discussion.
Since both available patches have been signed off by Marting Persson, I'm putting this to "Signed off".
Do you confirm that the QA concerns have been taken into account, the patches work as advertised and you have tested them? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #34 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Jonathan Druart from comment #33) To better make progress, I would need to know precisely what you mean by "QA concerns". After reading this thread through and through and opening the most recent patches, I think the only concern that wasn't explicitly addressed, about the UNIQUE key, was covered by the patch. Also, prove was run against t/db_dependant/Overdues.t without errors. There is, however, one odd thing: atomicupdates are only considered by updatedatabase.pl if the file extension is .perl or .sql, not .pl. I'll follow up this post with a new patch that fixes this problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #35 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 43524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43524&action=edit Bug 13624 - renaming atomicupdate from .pl to .perl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43524|0 |1 is obsolete| | --- Comment #36 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 43571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43571&action=edit Bug 13624 - renaming atomicupdate from .pl to .perl I have not tested this very thoroughly e.g. understood the SQL changes etc. since the patch has been signed off twice before. But it seems to me like this patch is OK. Applied, ran automatic tests and saved some values in the overduerules matrix/tabs OK. Signed-off-by: Eivin Giske Skaaren <eivin@sysmystic.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eivin@sysmystic.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41684|0 |1 is obsolete| | Attachment #41685|0 |1 is obsolete| | Attachment #43571|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43583&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Martin Persson <xarragon@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43584&action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql Signed-off-by: Martin Persson <xarragon@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43585&action=edit Bug 13624 - renaming atomicupdate from .pl to .perl I have not tested this very thoroughly e.g. understood the SQL changes etc. since the patch has been signed off twice before. But it seems to me like this patch is OK. Applied, ran automatic tests and saved some values in the overduerules matrix/tabs OK. Signed-off-by: Eivin Giske Skaaren <eivin@sysmystic.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Philippe! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #40)
Pushed to master, thanks Philippe!
Please regenerate the Schema files, some tests are failing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15601 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 [Bug 15601] TestBuilder tests are failing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #42 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Jonathan Druart from comment #41)
(In reply to Kyle M Hall from comment #40)
Pushed to master, thanks Philippe!
Please regenerate the Schema files, some tests are failing.
Which tests? I ran update_dbix_class_files.pl and nothing changed in my index... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org