[Bug 35037] New: Revise the appearance of the last patron button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Bug ID: 35037 Summary: Revise the appearance of the last patron button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 21246 I think the last patron button looks too big following the changes made in Bug 21246. I would like to propose a less obtrusive version. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21246 [Bug 21246] Extend the 'Last patron' navigation feature to 'Last X patrons' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156872&action=edit Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- This looks pretty good! I think it could use a bit of whitespace between the arrow and the help link to avoid accidental clicks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156872|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 156880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156880&action=edit Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- It looks great to me! I like that the name + card number are now aligned properly and aren't cut off. Maybe some more space between the dropdown list and the Help link, but a great improvement! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can you add more space please? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156936&action=edit Bug 35037: (follow-up) Minor adjustments to margins and padding -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156880|0 |1 is obsolete| | Attachment #156936|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 157085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157085&action=edit Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 157086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157086&action=edit Bug 35037: (follow-up) Minor adjustments to margins and padding Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157085|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157130&action=edit Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157086|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157131&action=edit Bug 35037: (follow-up) Minor adjustments to margins and padding Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35037 Bug 35037 depends on bug 21246, which changed state. Bug 21246 Summary: Extend the 'Last patron' navigation feature to 'Last X patrons' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21246 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org