[Bug 34042] New: Item search broken by FontAwesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Bug ID: 34042 Summary: Item search broken by FontAwesome upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 32910 A minor regression snuck in with the FontAwesome upgrade (Bug 32910), probably from multiple rebases. We went back to "can_edit_item()" where we should have kept "can_edit_items_from( item.homebranch )". This causes an error when trying to do an item search in the staff interface: "Template process failed: undef error - The method Koha::Patron->can_edit_item is not covered by tests!" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152449&action=edit Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152449|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 152452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152452&action=edit Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152452|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152483&action=edit Bug 34042: Item search broken by FontAwesome upgrade This patch corrects a small regression in one of the templates for outputting item search results. The template lost the change made to it by Bug 33070: "Remove use of can_edit_items." The error meant that item searching wasn't working at all. To test, apply the patch and perform an item search in the staff interface. Results should be returned as expected. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 32910 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not required for 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34042 Bug 34042 depends on bug 32910, which changed state. Bug 32910 Summary: Upgrade fontawesome icons to V6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org