[Bug 40333] New: When EDIFACT is enabled, one should be able to get from a Koha Invoice to the EDI INVOICE message easily
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Bug ID: 40333 Summary: When EDIFACT is enabled, one should be able to get from a Koha Invoice to the EDI INVOICE message easily Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Right now, there's not link back to display the edifact invoice message associated with a Koha invoice.. it would be helpful to have a quick link back from the Invoice display page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183902&action=edit Bug 40333: Add EDIFACT message link to invoice display page This enhancement adds a link from the invoice display page back to the EDIFACT message that was used to create the invoice, improving workflow and traceability for acquisitions staff. Changes include: - Display EDIFACT message information on invoice page when available - Show message type, transfer date, status, and filename - Add "View EDIFACT message" button that opens modal with raw message - Display EDIFACT processing errors directly on invoice page - Create reusable modal components for EDIFACT message display The implementation checks if the EDIFACT system is enabled and if the invoice has an associated message_id before displaying the EDIFACT section. Processing errors are highlighted in a warning box with clear formatting. To test: 1. Enable EDIFACT system preference 2. Create an invoice linked to an EDIFACT message 3. View the invoice - EDIFACT section should appear after vendor info 4. Click "View EDIFACT message" to see the raw EDIFACT data in a modal 5. If there are processing errors, they should be displayed clearly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When EDIFACT is enabled, |When EDIFACT is enabled, |one should be able to get |one should be able view the |from a Koha Invoice to the |corresponding EDIFACT |EDI INVOICE message easily |INVOICE message on the Koha | |Invoice page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183903&action=edit Example display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40334 [Bug 40334] When EDIFACT is enabled, one should be able view the corresponding EDIFACT QUOTE and ORDER messages on the Koha Basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #3 from Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> --- Oh, I like this idea... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183941&action=edit Bug 40333: Add EDIFACT message view to invoice display page This enhancement adds an EDIFACT message section to the invoice display page. If there's a linked EDI Message for this invice, we display the basic details along with any parsing errors that may have been recorded and we add a button to trigger the display of the raw message in a modal. Changes include: - Display EDIFACT message information on invoice page when available - Show message type, transfer date, status, and filename - Add "View EDIFACT message" button that opens modal with raw message - Display EDIFACT processing errors directly on invoice page - Create reusable modal components for EDIFACT message display The implementation checks if the EDIFACT system is enabled and if the invoice has an associated message_id before displaying the EDIFACT section. Processing errors are highlighted in a warning box with clear formatting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183942&action=edit Bug 40333: Tidy commit The commit hook was deliverately disabled for the previous commit and this commit added distinctly to ensure clarity between the functional code change and the massive tidy that the hook created. In that last commit we remove the last remaining TT variable from the <script> block in that template and as such we unlock the JS tidying on that block.. nice, except it hides the functional change in the mass commit of whitespace, quoting and newline changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183902|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183941|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184385&action=edit Bug 40333: Add EDIFACT message view to invoice display page This enhancement adds an EDIFACT message section to the invoice display page. If there's a linked EDI Message for this invice, we display the basic details along with any parsing errors that may have been recorded and we add a button to trigger the display of the raw message in a modal. Changes include: - Display EDIFACT message information on invoice page when available - Show message type, transfer date, status, and filename - Add "View EDIFACT message" button that opens modal with raw message - Display EDIFACT processing errors directly on invoice page - Create reusable modal components for EDIFACT message display The implementation checks if the EDIFACT system is enabled and if the invoice has an associated message_id before displaying the EDIFACT section. Processing errors are highlighted in a warning box with clear formatting. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183942|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184386&action=edit Bug 40333: Tidy commit The commit hook was deliverately disabled for the previous commit and this commit added distinctly to ensure clarity between the functional code change and the massive tidy that the hook created. In that last commit we remove the last remaining TT variable from the <script> block in that template and as such we unlock the JS tidying on that block.. nice, except it hides the functional change in the mass commit of whitespace, quoting and newline changes. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184387&action=edit Bug 40333: (follow-up) Terminology The envelope level of EDIFACT is called an 'Interchange'. This patch updates our UI terminology to match the official protocol terminology as what we're actually displaying here is the Interchange file that contains the related message for the Invoice. The interchange file will often contain other messages of the same type that came through at the same time of the this invoice generation. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #9 from Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> --- This is a fantastic feature and saves our library systems team time when supporting queries as we don't need to spend extra time combing the edi messages area for the corresponding file to check for the edifact included regarding a particular invoice. It is working as expected and so far and we are grateful for it's inclusion in our instance of Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187539&action=edit Bug 40333: (follow-up) Terminology The envelope level of EDIFACT is called an 'Interchange'. This patch updates our UI terminology to match the official protocol terminology as what we're actually displaying here is the Interchange file that contains the related message for the Invoice. The interchange file will often contain other messages of the same type that came through at the same time of the this invoice generation. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #11 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187540&action=edit Bug 40333: Tidy commit The commit hook was deliverately disabled for the previous commit and this commit added distinctly to ensure clarity between the functional code change and the massive tidy that the hook created. In that last commit we remove the last remaining TT variable from the <script> block in that template and as such we unlock the JS tidying on that block.. nice, except it hides the functional change in the mass commit of whitespace, quoting and newline changes. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #12 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187541&action=edit Bug 40333: Add EDIFACT message view to invoice display page This enhancement adds an EDIFACT message section to the invoice display page. If there's a linked EDI Message for this invice, we display the basic details along with any parsing errors that may have been recorded and we add a button to trigger the display of the raw message in a modal. Changes include: - Display EDIFACT message information on invoice page when available - Show message type, transfer date, status, and filename - Add "View EDIFACT message" button that opens modal with raw message - Display EDIFACT processing errors directly on invoice page - Create reusable modal components for EDIFACT message display The implementation checks if the EDIFACT system is enabled and if the invoice has an associated message_id before displaying the EDIFACT section. Processing errors are highlighted in a warning box with clear formatting. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- The envelope level of EDIFACT is called an 'Interchange'. This patch updates our UI terminology to match the official protocol terminology as what we're actually displaying here is the Interchange file that contains the related message for the Invoice. The interchange file will often contain other messages of the same type that came through at the same time of the this invoice generation. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184385|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184386|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184387|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187539|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187548&action=edit Bug 40333: (follow-up) Terminology The envelope level of EDIFACT is called an 'Interchange'. This patch updates our UI terminology to match the official protocol terminology as what we're actually displaying here is the Interchange file that contains the related message for the Invoice. The interchange file will often contain other messages of the same type that came through at the same time of the this invoice generation. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187540|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187549&action=edit Bug 40333: Tidy commit The commit hook was deliverately disabled for the previous commit and this commit added distinctly to ensure clarity between the functional code change and the massive tidy that the hook created. In that last commit we remove the last remaining TT variable from the <script> block in that template and as such we unlock the JS tidying on that block.. nice, except it hides the functional change in the mass commit of whitespace, quoting and newline changes. Sponsored-by: Open Fifth <https://openfith.co.uk> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for the QA's Kyle, this will end up one of the biggest releases for EDI improvements in some time I feel :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The invoice display page release notes| |now includes a section | |showing information about | |the EDIFACT interchange | |file that was used to | |create the invoice, with | |the ability to view the raw | |EDIFACT message data. | | | |Previously, when | |troubleshooting EDIFACT | |invoices or verifying | |invoice data against the | |original EDIFACT message, | |staff had to navigate | |separately to the EDIFACT | |messages administration | |page and search for the | |corresponding message file. | |This enhancement provides | |direct access from the | |invoice page, improving | |workflow efficiency and | |traceability. | | | |**Key features:** | | | |- **EDIFACT interchange | |information**: Display of | |message type, transfer | |date, status, and filename | |directly on the invoice | |page | |- **Raw message viewer**: | |"View EDIFACT interchange" | |button opens a modal | |displaying the complete raw | |EDIFACT data | |- **Error visibility**: Any | |EDIFACT processing errors | |are displayed prominently | |on the invoice page in a | |warning box | |- **Smart display**: The | |EDIFACT section only | |appears when the EDIFACT | |system is enabled and the | |invoice has an associated | |message | | | |**For acquisitions staff:** | | | |When viewing an invoice | |that was created from an | |EDIFACT message, you'll now | |see an "EDIFACT | |interchange" section after | |the vendor information. | |This section shows: | |- The interchange filename | |- Message type (e.g., | |INVOIC) | |- Transfer date and status | |- Any errors that occurred | |during processing | |- A button to view the | |complete raw EDIFACT data | | | |This enhancement is | |particularly useful for: | |- Troubleshooting invoice | |discrepancies | |- Verifying that EDIFACT | |data was parsed correctly | |- Supporting queries about | |invoice details | |- Training staff on EDIFACT | |processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40333 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #18 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org