[Bug 40453] New: Allow newly-added item type translations to be edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Bug ID: 40453 Summary: Allow newly-added item type translations to be edited Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, gmcharlt@gmail.com, jonathan.druart@gmail.com, testopia@bugs.koha-community.org Depends on: 40418 When a new item type translation is added, a new table row is added to the table. The markup of the added row doesn't match the existing rows, and the JS event listeners aren't correctly configured to target the new row. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 [Bug 40418] Update the item type translation process to avoid Greybox modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184408&action=edit Bug 40453: Allow newly-added item type translations to be edited This patch updates the item type translation page so that newly-added rows are editable. To test you must more than one installed translation. - Apply the patch and go to Administration -> Item types. - Edit an item type and click "Translate into other languages." - If you already have translations for your installed languages, delete them. - Add a new translation. - In the newly added table row, click the value in the "Language" column. A dropdown should appear and changing the language should work. - Cliking away from the table cell should replace the dropdown with the language code you selected. - Click the value in the "Translation" column. The table cell should become editable. Edit the text and tab out of the field. Your edit should be saved. - Reload the page to confirm that everything looks correct. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184408|0 |1 is obsolete| | --- Comment #2 from David Flater <flaterdavid@gmail.com> --- Created attachment 185106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185106&action=edit Bug 40453: Allow newly-added item type translations to be edited This patch updates the item type translation page so that newly-added rows are editable. To test you must more than one installed translation. - Apply the patch and go to Administration -> Item types. - Edit an item type and click "Translate into other languages." - If you already have translations for your installed languages, delete them. - Add a new translation. - In the newly added table row, click the value in the "Language" column. A dropdown should appear and changing the language should work. - Cliking away from the table cell should replace the dropdown with the language code you selected. - Click the value in the "Translation" column. The table cell should become editable. Edit the text and tab out of the field. Your edit should be saved. - Reload the page to confirm that everything looks correct. Sponsored-by: Athens County Public Libraries Signed-off-by: David Flater <flaterdavid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flaterdavid@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185106|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186126&action=edit Bug 40453: Allow newly-added item type translations to be edited This patch updates the item type translation page so that newly-added rows are editable. To test you must more than one installed translation. - Apply the patch and go to Administration -> Item types. - Edit an item type and click "Translate into other languages." - If you already have translations for your installed languages, delete them. - Add a new translation. - In the newly added table row, click the value in the "Language" column. A dropdown should appear and changing the language should work. - Cliking away from the table cell should replace the dropdown with the language code you selected. - Click the value in the "Translation" column. The table cell should become editable. Edit the text and tab out of the field. Your edit should be saved. - Reload the page to confirm that everything looks correct. Sponsored-by: Athens County Public Libraries Signed-off-by: David Flater <flaterdavid@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186127&action=edit Bug 40453: Do not rely on hardcoded index Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40453 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org