[Bug 30243] New: When OPACSuggestionMandatoryFields includes branchcode the dropdown should default to an empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Bug ID: 30243 Summary: When OPACSuggestionMandatoryFields includes branchcode the dropdown should default to an empty value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When OPACSuggestionMandatoryFields includes branchcode the dropdown should default to an empty value which will force the user to make a choice regarding branchcode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131525&action=edit Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch https://bugs.koha-community.org/show_bug.cgi?id=29795 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Creates an empty value and release notes| |defaults to it when | |OPACSuggestionMandatoryFiel | |ds includes branchcode. | |This forces users to make a | |choice regarding branch. Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131525|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131526&action=edit Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131526|0 |1 is obsolete| | --- Comment #3 from shi-yao.wang@inLibro.com --- Created attachment 131580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131580&action=edit Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch Signed-off-by: shiyao <shiyao@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |shi-yao.wang@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131580|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132615&action=edit Bug 30243: When branccode is required on OPAC suggestion page default to empty value To test: 1. Apply patch 2. Go the purchase suggestion page and see that branchcode defaults to the first option in the list. 3. Go to OPACSuggestionMandatoryFields and mark branchcode as required 4. BAck on the OPAC suggestion page notice that the branchcode defaults to an empty value 5. Try to submit the form without changing it, you cannot. You must choose a branch Signed-off-by: shiyao <shiyao@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243 --- Comment #6 from Catrina Berka <catrina@bywatersolutions.com> --- Filed bug 32249, reporting that this doesn't work as anticipated. The dropdown defaults to patron home branch, not an empty value. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org