[Bug 27035] New: Shows the number of results in a facet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Bug ID: 27035 Summary: Shows the number of results in a facet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: ivan.dziuba@inlibro.com QA Contact: testopia@bugs.koha-community.org After searching, the number of results for facets is not displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shows the number of results |Shows the number of results |in a facet |in a facets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 --- Comment #1 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 113670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113670&action=edit Bug 27035: Shows the number of results in a facets. Test: 1. Apply the patch. 2. The number of results is displayed for each facet after searching. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ivan.dziuba@inlibro.com |ity.org | CC| |eric.begin@inLibro.com, | |ivan.dziuba@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 --- Comment #2 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 113675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113675&action=edit Bug 27035: Shows the number of results in a facets. Test: 1. Apply the patch. 2. The number of results is displayed for each facet after searching. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 --- Comment #3 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Comment on attachment 113670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113670 Bug 27035: Shows the number of results in a facets. Test: 1. Apply the patch. 2. The number of results is displayed for each facet after searching. obsolete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 --- Comment #4 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Comment on attachment 113670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113670 Bug 27035: Shows the number of results in a facets. Test: 1. Apply the patch. 2. The number of results is displayed for each facet after searching. Review of attachment 113670: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27035&attachment=113670) ----------------------------------------------------------------- obsolete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113670|0 |1 is obsolete| | Attachment #113670|1 |0 is patch| | --- Comment #5 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Comment on attachment 113670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113670 Bug 27035: Shows the number of results in a facets. Test: 1. Apply the patch. 2. The number of results is displayed for each facet after searching.
From 959186a3bb4fc82f49e703a107f636007217000b Mon Sep 17 00:00:00 2001 From: Ivan Dziuba <ivan.dziuba@inlibro.com> Date: Mon, 16 Nov 2020 11:26:29 -0500 Subject: [PATCH] Bug 27035: Shows the number of results in a facets. Test: 1. Apply the patch. 2. The number of results is displayed for each facet after searching.
--- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc index dad168a4ef..0f20cb37fa 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc @@ -52,11 +52,11 @@ [% END %] [% IF facet.active %] [% local_url = BLOCK %][% url | $raw %][% "&nolimit=" _ facet.type_link_value _ ":" _ facet.facet_link_value | url %][% END %] - <span class="facet-label">[% facet.facet_label_value | html %]</span> + <span class="facet-label">[% facet.facet_label_value | html %]</span> <strong>([% facet.facet_count | html %])</strong> [<a href="[% local_url | $raw %]" title="Remove facet [% facet.facet_link_value | html %]">x</a>] [% ELSE %] [% local_url = BLOCK %][% url | $raw %][% "&limit=" _ facet.type_link_value _ ":" _ facet.facet_link_value | url %][% END %] - <span class="facet-label"><a href="[% local_url | $raw %]" title="[% facet.facet_title_value | html %]">[% facet.facet_label_value | html %]</a></span> + <span class="facet-label"><a href="[% local_url | $raw %]" title="[% facet.facet_title_value | html %]">[% facet.facet_label_value | html %] <strong>([% facet.facet_count | html %])</strong></a></span> [% IF ( displayFacetCount ) %] <span class="facet-count"> ([% facet.facet_count | html %])</span> [% END %] -- 2.17.1
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113675|0 |1 is obsolete| | Attachment #113675|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shows the number of results |Shows the number of results |in a facets |in a facets after facet | |selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 --- Comment #6 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 113678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113678&action=edit Bug 27035: Shows the number of results in a facets after facet selection System preferences: displayFacetCount - Show; Before, When we select a facet the number of results is not displayed, after searching Ex. Marriage -- Fiction [x] After, When we select a facet the number of results is displayed, after searching Ex. Marriage -- Fiction (2) [x] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113678|0 |1 is obsolete| | --- Comment #7 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 113680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113680&action=edit Bug 27035: Shows the number of results in a facets after facet selection System preferences: displayFacetCount - Show; 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Opposite the selected facets, the number of results is not displayed Ex. Marriage Fiction [x] Apply the patch 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Now, opposite the selected facets, the number of results is displayed Ex. Marriage Fiction (2) [x] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Hi Ivan, This works for me but it is a bit confusing when you attempt to apply 2 or more filters at a time. -I apply your patch and do an OPAC search. -Then I filter to only show Centerville results. (210 results) -I see 210 appear in bold next to the Centerville filter -Now I filter to only show Non-Fiction results, while maintaining the Centerville filter. -There are 4 results that are Non-Fiction items from Centerville. -Now both filters (Centerville and Non-fiction) show the number 4 in bold. I understand this might be correct as we now have 4 search results but it is confusing to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Indeed, number of results are useful before selecting a facet. After, it may be confusing and not really useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Blou <philippe.blouin@inlibro.com> --- Would you have suggestion on how this could be improved? This is an upgrade to the current status, as such it could move forward. Your points are valid, though, so if you have an idea on how the logic should work, we're very much listening. I put it back in Need Signoff to wake things up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Blou from comment #10)
Would you have suggestion on how this could be improved?
This is an upgrade to the current status, as such it could move forward. Your points are valid, though, so if you have an idea on how the logic should work, we're very much listening.
I put it back in Need Signoff to wake things up.
I am assuming many libraries are going to want to hide this from display. Can we get a distinct class the number wrapped in parenthesis? I know we could hide it by targeting the <strong> element but I would much rather see a distinct class here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 shi-yao.wang@inLibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113680|0 |1 is obsolete| | --- Comment #12 from shi-yao.wang@inLibro.com --- Created attachment 132077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132077&action=edit Bug 27035: Shows the number of results in a facets after facet selection System preferences: displayFacetCount - Show; 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Opposite the selected facets, the number of results is not displayed Ex. Marriage Fiction [x] Apply the patch 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Now, opposite the selected facets, the number of results is displayed Ex. Marriage Fiction (2) [x] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |shi-yao.wang@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132077|0 |1 is obsolete| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 132195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132195&action=edit Bug 27035: Shows the number of results in a facets after facet selection System preferences: displayFacetCount - Show; 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Opposite the selected facets, the number of results is not displayed Ex. Marriage Fiction [x] Apply the patch 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Now, opposite the selected facets, the number of results is displayed Ex. Marriage Fiction (2) [x] Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132195|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132807&action=edit Bug 27035: Shows the number of results in a facets after facet selection System preferences: displayFacetCount - Show; 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Opposite the selected facets, the number of results is not displayed Ex. Marriage Fiction [x] Apply the patch 1. Let's search 2. Near to each of the facets, we see the number of results (n) 3. Click on any of the facets and filter the result 4. Now, opposite the selected facets, the number of results is displayed Ex. Marriage Fiction (2) [x] Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shows the number of results |Shows the number of results |in a facets after facet |in a facet after facet |selection |selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m --- Comment #16 from Catrina Berka <catrina@bywatersolutions.com> --- Filed bug 32252 - this does not appear to be resolved in 22.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org