[Bug 15310] New: Fix duplicate fines issue when changing date or time format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Bug ID: 15310 Summary: Fix duplicate fines issue when changing date or time format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Changing the sysprefs 'dateformat' and/or 'TimeFormat' on a production server with overdue items that are accruing fines can result in duplicate fines. It happens when the system has to decide wether to update an existing fine or to add a new fine. It is related to C4/Overdues.pm line 538 that parses the fines description for a date in the current syspref date format ($due_qr). if ($rec->{itemnumber} == $itemnum && $rec->{description} =~ /$due_qr/) If the dateformat is changed, parsing will not find the date in previous fines and an extra fine will be applied. It is not possible to automatically parse for all date formats since dd/mm/yyyy and mm/dd/yyyy can be ambiguous. The system needs an information about what the previous date format was (if it changed). To bridge the issue until we have a rewrite of the accounts system ready, the previous date- / and time format can be indicated in additional sysprefs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, not sure about the system prefernece idea - what if someone changes it multiple times? forgets to keep track of the changes? It would also need the date it was changed etc. It's tricky. Could we do a global switch to the db date format and fix it for display maybe? I think a big warning and a script to fix the entries in the accountlines table to the new dateformat would be ok for me until we can move the date totally out of the description. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 --- Comment #2 from Marc Véron <veron@veron.ch> --- Thanks for the comment, Katrin. You are right, it is very tricky and errorprone to fix the issue. We have the script fix_accountlines_date.pl. However, the current version handles only 'us' and 'metric' as previous date formats. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it might be worth fixing the script - what do you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15312 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org