[Bug 7411] New: remove diacritics when automatically generating userid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Bug #: 7411 Summary: remove diacritics when automatically generating userid Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: sophie.meynieux@biblibre.com QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com When userid is automatically generated from firstname and surname, diacritics should be removed because login with diacritics may results in failure -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2012-01-06 10:42:59 UTC --- Created attachment 7064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7064 Bug 7411 : remove diacritics from userid when generated automatically -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff AssignedTo|kyle.m.hall@gmail.com |sophie.meynieux@biblibre.co | |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 --- Comment #2 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2012-01-06 10:46:47 UTC --- http://mantis.biblibre.com/view.php?id=7744 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> 2012-01-06 11:15:06 UTC --- I'm wondering why it's using Text::Undiacritic instead of Text::Unaccent which is more popular and already packaged in Debian. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #4 from Magnus Enger <magnus@enger.priv.no> 2012-01-06 11:38:33 UTC --- Using a module that is packaged for Debian would be a good idea. If this is changed, please remember to add the package to these files: install_misc/debian.packages debian/control -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 14:39:13 UTC --- The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply". The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix. If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script. If the patch applies does not apply as I think, please rebase and resubmit, thanks -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|sophie.meynieux@biblibre.co |katrin.fischer@bsz-bw.de |m | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I talked to Sophie and will try writing a patch using the module suggested by Dobrica. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7064|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10048&action=edit Bug 7411: Remove diacritics from generated userid Patch introduces a new module Text::Unaccent. To test: 1) Add a new patron with diacritics in surname and first name, leave userid empty. 2) Save user and check the created userid has only the base characters and diacritics have been removed correctly. 3) Create another user with the same surname and first name, check userid is generated correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10048|0 |1 is obsolete| | --- Comment #8 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 10049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10049&action=edit Bug 7411: Remove diacritics from generated userid Patch introduces a new module Text::Unaccent. To test: 1) Add a new patron with diacritics in surname and first name, leave userid empty. 2) Save user and check the created userid has only the base characters and diacritics have been removed correctly. 3) Create another user with the same surname and first name, check userid is generated correctly. Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|rel_3_6 |rel_3_10 QA Contact|koha.sekjal@gmail.com |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: Tiny patch that adds a dependency, but this dep could be used in other places. also adds packages dependencies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- This patch introduces a new dependency to fix a bug that happens rarely, I think it should be for 3.10 only, but chris, you decide -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add to C4::Installer::PerlDependencies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10735&action=edit Bug 7411: Follop-up: Add Text::Unaccent to PerlDependencies.pm Adds new dependency Text::Unaccent to PerlDependencies.pm Module is used currently to remove diacricits from automatically created userid (<first name>.<surname>) in the patron module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10735|0 |1 is obsolete| | --- Comment #13 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 10800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10800&action=edit Bug 7411: Follop-up: Add Text::Unaccent to PerlDependencies.pm Adds new dependency Text::Unaccent to PerlDependencies.pm Module is used currently to remove diacricits from automatically created userid (<first name>.<surname>) in the patron module. Test scenario: 1. open About Koha > Perl modules 2. verify that Text::Unaccent is there Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Follow-up pushed (on master branch, does not apply anymore on new/bug_7411) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14759 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org