http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37367|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37368&action=edit Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There should be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37397|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 37398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37398&action=edit Bug 9120: Prevent form submission on adding tags - OPAC At the OPAC, if the user adds tags pressing 'Enter', the page is reloaded and the tags are not added. To prevent that, this patch suggests to block the "press enter" event on the inputs. Test plan: 0/ Confirm the bad behavior, without this patch. 1/ Apply this patch and confirm nothing happen on pressing enter when the focus is on the add tag input (At the opac, on the result view). Patch works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> http://bugs.koha-community.org/show_bug.cgi?id=13882 Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37398|0 |1 is obsolete| | Attachment #37398|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37565|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 37586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37586&action=edit Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There should be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.