http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 --- Comment #1 from Julian FIOL <julian.fiol@biblibre.com> --- Created attachment 37054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37054&action=edit Bug 13882 : Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37054|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37366&action=edit Bug 13882 : Adding new unit tests in t/Borrower.t This adds testing for all the 'borrower' database fields. TEST PLAN --------- 1) apply patch 2) prove -v t/Borrowers.t -- All 67 subtests for both the setter and accessor should run successfully. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 37394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37394&action=edit Bug 9120: Prevent form submission on adding tags - OPAC At the OPAC, if the user adds tags pressing 'Enter', the page is reloaded and the tags are not added. To prevent that, this patch suggests to block the "press enter" event on the inputs. Test plan: 0/ Confirm the bad behavior, without this patch. 1/ Apply this patch and confirm nothing happen on pressing enter when the focus is on the add tag input (At the opac, on the result view). Patch works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- All tests pass, signing off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37366|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37470&action=edit [PASSED QA] Bug 13882 : Adding new unit tests in t/Borrower.t This adds testing for all the 'borrower' database fields. TEST PLAN --------- 1) apply patch 2) prove -v t/Borrowers.t -- All 67 subtests for both the setter and accessor should run successfully. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Julian! Note: I rebased it on top of bug 13928, no big deal. -- You are receiving this mail because: You are watching all bug changes.