[Bug 30399] New: Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Bug ID: 30399 Summary: Patron.t fails when there is a patron attribute that is mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org I noticed this while testing another bug and this is happening to me while using koha-testing-docker. To recreate: 1. sudo koha-shell kohadev 2. prove t/db_dependent/Koha/Patron.t 3. Tests pass. 4. Add a new patron attribute type and make it Mandatory by clicking the checkbox. 5. prove t/db_dependent/Koha/Patron.t # Failed test 'extended_attributes' # at t/db_dependent/Koha/Patron.t line 686. Missing mandatory extended attribute (type=TEST)# Looks like your test exited with 255 just after 7. t/db_dependent/Koha/Patron.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/16 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patron.t (Wstat: 65280 Tests: 7 Failed: 1) Failed test: 7 Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 7. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135791&action=edit Bug 30399: Make Patron.t pass even if mandatory attributes exist t/db_dependent/Koha/Patron.t is failing if mandatory attributes already exist in the DB. We can make it pass easily by deleting all the attributes before we run the tests. Test plan: prove t/db_dependent/Koha/Patron.t must return green even if one mandatory patron attribute exists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135791|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135824&action=edit Bug 30399: Make Patron.t pass even if mandatory attributes exist t/db_dependent/Koha/Patron.t is failing if mandatory attributes already exist in the DB. We can make it pass easily by deleting all the attributes before we run the tests. Test plan: prove t/db_dependent/Koha/Patron.t must return green even if one mandatory patron attribute exists. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- y -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135824|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135968&action=edit Bug 30399: Make Patron.t pass even if mandatory attributes exist t/db_dependent/Koha/Patron.t is failing if mandatory attributes already exist in the DB. We can make it pass easily by deleting all the attributes before we run the tests. Test plan: prove t/db_dependent/Koha/Patron.t must return green even if one mandatory patron attribute exists. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org