[Bug 30924] New: Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Bug ID: 30924 Summary: Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I am getting several errors and issues when testing bug 30823 - BEFORE applying the patch. I thought these were fixed with some of the recent recalls bugs that were pushed to master. I'm not sure whether separate bugs are required, or just one to look at what is causing these. In the interim, I've created this bug. Scenario/settings using koha-testing-docker (up-to-date with master): - UseRecalls system preference: set to 'Use'. - RecallsLog system preference: set to 'Log'. - Circulation and fines rules: . Recalls allowed (total) = 5 . Recalls per record (count) = 2 . On shelf recalls allowed = 'If any unavailable' . Recall due date interval (day) = 3 . Recall overdue fine amount = 5 . Recall pickup period (day) = 2 - Patron B: Mary Burton (Midway) - Patron A: Henry Acevedo (Midway) - Record used to place recalls on: Programming Perl (biblionumber = 262, one item = 39999000011418, home library = Centerville) TLDR: - Log viewer: Error on log viewer for recalls once there is are logged recalls transactions - Transfers for recalls: error on transfers to receive - After check in and waiting for pickup: actions to cancel recall on several pages do not work Error 1: Setup and place a recall - log viewer error ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I get this error using the log viewer limited to the recalls module - recall placed, no other actions. Template process failed: undef error - The method Koha::Recall->item_level_recall is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55d076a68a48)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 379 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 379 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 409 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 18 Template::Provider::__ANON__('Template::Context=HASH(0x55d074a2b5f0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161 .... Error 2: Viewing the check out page > checkouts tab for Mary - after recall placed ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ No checkouts are listed, sits on "Loading... you may continue scanning" in a floating box at the bottom of the page, with "Loading..." showing in the center of the table. Does not show other items checked out. The details page > checkouts tab is the same. Error 3: If a transfer is required ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Step 1: Check in the item (39999000011418) > Transfer to Midway required > Confirm recall and transfer. - Mary: checkouts list is now displaying - Henry: recalls tab showing "In transit to Midway" - Circulation > Recalls > Recalls queue: showing "In transit to Midway" - Circulation > Recalls > Recalls to pull: listed with button to "Cancel recall and return to: Centerville Step 2: Transfer to Midway - Change library to Midway - Ciculation > Transfers > Transfers to receive: get this error: Template process failed: undef error - The method Koha::Recall->borrowernumber is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x559d07b59d00)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 108 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 112 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 18 .... Step 3: Check in item (with library set to Midway) - Modal window with "Recall at Midway + Confirm recall" - Circulation > Recalls > Recalls awaiting pickup: listed - Circulation > Transfers > Transfers to receive: no errors - Record detail page in staff interface: showing as "Waiting at Midway since..." - Henry: recalls tab on patron page for check out and details sections - shows as "Ready for pickup" - Mary: nothing shown (as expected) Step 4: Checkout item - works as expected, But wait, there's more! 1. Once a recall is made, and checked in: a. On the staff interface item details page > recalls section - selecting from the Actions drop down list/button "Cancel recall and return to Centerville" does nothing. b. However, selecting the tick box and selecting "Cancel selected recalls" works. c. In addition, after you press "Cancel...": - the URL changes to http://127.0.0.1:8081/cgi-bin/koha/recalls/request.pl - clicking on normal (or any other tab gives you the message "The record you requested does not exist ()." - URL is http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber= 2. Once a recall is made, and checked in: . From Circulation > Recalls > Recalls queue: same as 1a and 1b. 3. Once a recall is made, and checked in: . From Circulation > Recalls > Recalls to pull: select "Cancel recall and return to: Centerville: generates this error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'reason' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 ..... 4. On the patron details > recalls tab page for Henry, selecting Actions > "Cancel recall and return to: Cenetrville" does nothing (same as 1a). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30907 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Template process failed: undef error - The method Koha::Recall->item_level_recall is not covered by tests! See Bug 30907
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |30907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30907 [Bug 30907] List of checkouts won't load if item is recalled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Error 1: Solved on bug 30907 Error 2: Solved on bug 30907 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Working on Error 3. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135884&action=edit Bug 30924: Fix transferstoreceive.pl explosion on recalls Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135902&action=edit Bug 30924: Add missing branchtransfers.reason value for recall cancellation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135903&action=edit Bug 30924: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|Recalls workflow - errors |Fix recalls-related errors |and issues: log viewer, |in log viewer, patron |patron details, transfers, |details, transfers, |cancelling once checked in |cancelling |(waiting for pickup) | Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- David, you mention some workflow issues, besides explosions. I dealt with explosions on the patches, please file specific bugs for the workflow issues you might encounter, and make sure Aleisha notices them, perhaps assign them to her. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix recalls-related errors |Fix recalls-related errors |in log viewer, patron |in transfers and cancelling |details, transfers, |actions |cancelling | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135884|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 135947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135947&action=edit Bug 30924: Fix transferstoreceive.pl explosion on recalls Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135902|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 135948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135948&action=edit Bug 30924: Add missing branchtransfers.reason value for recall cancellation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135903|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 135949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135949&action=edit Bug 30924: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #11 from David Nind <david@davidnind.com> --- Testing notes (sing koha-testing-docker): 1. Enable recalls: set UseRecalls system preference to 'Use'. 2. Setup rcalls circulation and fines rules: . Recalls allowed (total) = 5 . Recalls per record (count) = 2 . On shelf recalls allowed = 'If any unavailable' . Recall due date interval (day) = 3 . Recall overdue fine amount = 5 . Recall pickup period (day) = 2 3. Checkout an item to a patron: - Patron used: Mary Burton (Midway) - Record used: Programming Perl (biblionumber = 262, one item = 39999000011418, home library = Centerville) 4. Change username/password for a patron, login to the OPAC, and place a recall for the item in step 4. - Patron used: Henry Acevedo (Midway) 5. Check in item for recall with library set to Centerville - confirm recall and transfer. 6. Change library to Midway. 7. Go to Circulation > Transfers > Transfers to receive - error generated: Template process failed: undef error - The method Koha::Recall->borrowernumber is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55da4737e158)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 93 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 108 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt line 112 .. 7. Apply patch, updatedatabase, dbic, flush_memcached, restart_all. 8. Refresh transfers to receive page - it should now display as expected without errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30944 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Tomás Cohen Arazi from comment #7)
David, you mention some workflow issues, besides explosions.
I dealt with explosions on the patches, please file specific bugs for the workflow issues you might encounter, and make sure Aleisha notices them, perhaps assign them to her.
Thanks Tomás! I have created bug 30944 for the workflow issues - where the cancel action buttons don't appear to work. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135947|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135994&action=edit Bug 30924: Fix transferstoreceive.pl explosion on recalls Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135948|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135995&action=edit Bug 30924: Add missing branchtransfers.reason value for recall cancellation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135949|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135996&action=edit Bug 30924: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Code all reads well, fix works and QA scripts are happy. Passing QA PS: Thanks for the test plan David, I was struggling to get it set up on my environment, your plan was very helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org