[Bug 25130] New: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 Bug ID: 25130 Summary: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When viewing a suggestion, the reason given by the library for accepting/rejecting the suggestion is not displayed. It shows, when the suggestion is edited: /cgi-bin/koha/suggestion/suggestion.pl?suggestionid=29&op=edit (shows) //cgi-bin/koha/suggestion/suggestion.pl?suggestionid=34&op=show (doesn't show) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104320&action=edit Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104320|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 104321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104321&action=edit Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104321|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104633&action=edit Bug 25130: Reason for accepting/rejecting a suggestion is not visible when viewing (not editing) The patch adds the suggestion management reason to the display when viewing a suggestion. To test: 1) Edit a suggestion and assign a reason for accepting it. 2) View the suggestion (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=XX&op=show, replacing XX with your suggestion ID) 3) Under suggestion management, the reason you've just assigned does not display. 4) Apply the patch 5) Check the display again - the Reason should now be visible directly under the status. Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx David and Abbey! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25130 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply clean to 19.05.x, please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org