[Bug 17853] New: MARC21: Don't remove () from link text for 780
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Bug ID: 17853 Summary: MARC21: Don't remove () from link text for 780 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. - Verify that the () are not shown in the link text and are not part of the URL. Problem: It's correct to remove () from the link, but the link text should still include them. Problem exists in staff and OPAC.
From the detail page XSLT, problem is in lines 1149 and 1154:
1146 <xsl:choose> 1147 <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']"> 1148 <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute> 1149 <xsl:value-of select="translate($f780, '()', '')"/> 1150 </a> 1151 </xsl:when> 1152 <xsl:otherwise> 1153 <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=ti,phr:<xsl:value-of select="translate($f780, '()', '')"/></xsl:attribute> 1154 <xsl:value-of select="translate($f780, '()', '')"/> 1155 </a> 1156 </xsl:otherwise> 1157 </xsl:choose> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, same problem appears to exist for 785. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC21: Don't remove () |MARC21: Don't remove () |from link text for 780 |from link text for 780/785 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #2 from Gracie <grace.mcky@gmail.com> --- Created attachment 59190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59190&action=edit Bug 17853 - Don't remove () from link text I have followed your test plan, applied the patch and have noticed that there are now brackets around the link text. Is this what you were looking for? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59190|0 |1 is obsolete| | --- Comment #3 from Gracie <grace.mcky@gmail.com> --- Created attachment 59198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59198&action=edit Bug 17853 - Don't remove () from link text I have followed your test plan, applied the patch and have noticed that there are now brackets around the link text. Is this what you were looking for? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Gracie: Yes, they should be around the link text, but not part of the URL. If that is what you see you should sign off. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |grace.mcky@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se --- Comment #5 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- I've tested this and get the same result with or without this patch - no parenthesis is displayed in the link text (or url for that matter, but it should not display there?). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Felix Hemme <felix.hemme@thulb.uni-jena.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61877&action=edit Bug 17853 - Don't remove () from link text I have followed your test plan, applied the patch and have noticed that there are now brackets around the link text. Is this what you were looking for? Signed-off-by: Felix Hemme <felix.hemme@thulb.uni-jena.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61877|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62078&action=edit Bug 17853 - Don't remove () from link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme <felix.hemme@thulb.uni-jena.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62079&action=edit Bug 17853 - Don't remove () from field 785 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Fixed commit messages - added new patch for 785 field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62078|0 |1 is obsolete| | Attachment #62079|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63325&action=edit [SIGNED-OFF] Bug 17853 - Don't remove () from link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme <felix.hemme@thulb.uni-jena.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63326&action=edit [SIGNED-OFF] Bug 17853 - Don't remove () from field 785 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- For both 780 and 785 fields a and t are put into variable f780/5. Since you replace this variable by subfield a, we loose information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|grace.mcky@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63325|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103044&action=edit Bug 17853 - Don't remove () from 780 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme <felix.hemme@thulb.uni-jena.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103045&action=edit Bug 17853: Don't remove () from 785 link text and restore link value of 780 The only thing we change for 780 and 785 is, that if the display text contains (), they are no longer removed. To test: - Catalogue a record with 785$a some text (including) parenthesis e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12678 [Bug 12678] Link 780 & 785 fields to another records using $w -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12678 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12678 [Bug 12678] Link 780 & 785 fields to another records using $w -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103044|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 103219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103219&action=edit Bug 17853 - Don't remove () from 780 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme <felix.hemme@thulb.uni-jena.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103045|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 103220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103220&action=edit Bug 17853: Don't remove () from 785 link text and restore link value of 780 The only thing we change for 780 and 785 is, that if the display text contains (), they are no longer removed. To test: - Catalogue a record with 785$a some text (including) parenthesis e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103219|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 104573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104573&action=edit Bug 17853 - Don't remove () from 780 link text To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Felix Hemme <felix.hemme@thulb.uni-jena.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Bug 17853: Don't remove () from 785 link text and restore link value of 780 The only thing we change for 780 and 785 is, that if the display text contains (), they are no longer removed. To test: - Catalogue a record with 785$a some text (including) parenthesis e.g. Hospitals (Chicago, Ill. : 1936) - Verify that the () are not shown in the link text and are not part of the URL. - Apply patch - Verify that the () are shown in the link text and are not part of the URL. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Patches are squashed. Makes changes more clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, and we lose authorship - I intentionally saved the authorship of the Academy student to keep her contribution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd prefer if the separate patches could be restored - seeing the diff is easy with git, 2 patches or 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #21)
Yes, and we lose authorship - I intentionally saved the authorship of the Academy student to keep her contribution.
I still see her name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But it's no longer what she wrote. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #26 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org