https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98684&action=edit Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply tThiss he patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98684|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 98919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98919&action=edit Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply this patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98919|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98955&action=edit Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply the patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24621 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.