[Bug 13544] New: admin/auth_subfields_structure.pl does not compile in older perls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Bug ID: 13544 Summary: admin/auth_subfields_structure.pl does not compile in older perls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13522 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35088&action=edit Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not sure how to test this, my system uses perl 5.18, but I found no regressions in editing the authority frameworks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- You can use sandboxes, they use perl 5.10.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35088|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35419&action=edit [SIGNED OFF] Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed problem and tested patch on a sandbox, signed off locally. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 35570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35570&action=edit Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed problem and tested patch on a sandbox, signed off locally. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA on this.. simple patch that fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35570|Bug 13544: Make it explicit |[PASSED QA] Bug 13544: Make description|that getauthtypes returns a |it explicit that |hash ref |getauthtypes returns a hash | |ref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org