[Bug 13570] New: koha-conf.xml mentions win32
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Bug ID: 13570 Summary: koha-conf.xml mentions win32 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The koha-conf.xml template in /etc/ still bears mention of MSWin32 systems. Unless we're ever thinking of suporting windows.. again? We should tidy up this file to remove mention of it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13571 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13571 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 the.invinnysible.one@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |the.invinnysible.one@gmail. | |com --- Comment #1 from the.invinnysible.one@gmail.com --- I will attempt to remove the section in the koha-conf.xml file that mentions this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 the.invinnysible.one@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from the.invinnysible.one@gmail.com --- Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Needs sign-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 --- Comment #3 from the.invinnysible.one@gmail.com --- Created attachment 35169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35169&action=edit Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Rochelle Healy <rochellehealy.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rochellehealy.student@wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Rochelle Healy <rochellehealy.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35169|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 35173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35173&action=edit Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35173|Bug 13570 - koha-conf.xml |[SIGNED OFF] Bug 13570 - description|mentions win32 |koha-conf.xml mentions | |win32 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 35173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35173 [SIGNED OFF] Bug 13570 - koha-conf.xml mentions win32 Nice simple patch to tidy up the koha-conf file a little... No negative affects found, singing off. Thanks Morag -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we remove the bits about Windows from Makefile.PL as well? (git grep MSWin32): Makefile.PL:if ( $^O eq 'MSWin32' ) { ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35173|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35283&action=edit [PASSED QA] Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: <!-- uncomment these lines and comment out the above if running on MSWin32 --> <!-- <listen id="biblioserver" >tcp:localhost:9998/bibliosocket</listen> <listen id="authorityserver" >tcp:localhost:9999/authoritysocket</listen> --> This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #6)
Should we remove the bits about Windows from Makefile.PL as well? (git grep MSWin32): Makefile.PL:if ( $^O eq 'MSWin32' ) { ...
Well spotted Katrin.. not sure how I missed those when I spotted these ;).. I'll open another bug for it, save this one going backwards ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13586 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Morag! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org