https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 187044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187044&action=edit Bug 40896: Disable run report buttons upon click This patch will disable the run report button found on both the list page, and the individual operation pages (e.g. run, edit, saved successfully). This will stop librarians from unintentionally crashing their Koha system, by pressing the run report button repeatedly when there is no need to re-request it. TO TEST: a) go to /cgi-bin/koha/reports/guided_reports.pl?op=list b) create three new sql test reports: *) Name: Test report #1, SQL: SELECT count(*) FROM biblio *) Name: Test report #2, SQL: SELECT count(*) FROM items *) Name: Test report #3, SQL: SELECT * FROM items WHERE items.dateaccessioned = <<Date accessioned|date>> c) run all of the above test reports, noticing how the run report button can be activated repeatedly APPLY PATCH d) redo step a e) run test report #1 from the table, notice how now the button can only be activated once before it is greyed out and the play button is replaced with a spinner f) return to the list, edit test report #2 from the table, click run report from the edit page, and notice how this run report button exhibits the same behaviour as the button in step e g) return to the list, run test report #3, select a date, click run report from this page, and notice again how the run report button exhibits the same behaviour as the buttons in steps e and f SIGN OFF -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187044|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187193&action=edit Bug 40896: Disable run report buttons upon click This patch will disable the run report button found on both the list page, and the individual operation pages (e.g. run, edit, saved successfully). This will stop librarians from unintentionally crashing their Koha system, by pressing the run report button repeatedly when there is no need to re-request it. TO TEST: a) go to /cgi-bin/koha/reports/guided_reports.pl?op=list b) create three new sql test reports: *) Name: Test report #1, SQL: SELECT count(*) FROM biblio *) Name: Test report #2, SQL: SELECT count(*) FROM items *) Name: Test report #3, SQL: SELECT * FROM items WHERE items.dateaccessioned = <<Date accessioned|date>> c) run all of the above test reports, noticing how the run report button can be activated repeatedly APPLY PATCH d) redo step a e) run test report #1 from the table, notice how now the button can only be activated once before it is greyed out and the play button is replaced with a spinner f) return to the list, edit test report #2 from the table, click run report from the edit page, and notice how this run report button exhibits the same behaviour as the button in step e g) return to the list, run test report #3, select a date, click run report from this page, and notice again how the run report button exhibits the same behaviour as the buttons in steps e and f SIGN OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi Jake, was looking to QA this. Could you make one change? Could you replace the match on i.fa-{spinner,play} with usage of ids or data attributes instead? Just to decouple the logic from the icon classes so that we don't have to touch it if we change icon libraries. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 --- Comment #6 from Jake Deery <jake.deery@openfifth.co.uk> --- Hi Paul, Take a look at that patch. We're just looking for any FontAwesome class within the element targeted, now. There is still a line that will `replaceWith` the HTML after 120 seconds, but to be honest I can't think of another sane way of doing this, without any easily usable ID or data attribute on the FontAwesome icon itself? If it looks good, I'll merge it down into one patchfile for pushing. Ta, Jake -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187512|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188106&action=edit Bug 40896: (follow-up) Use icon wrapper elements and visibility toggling - Wrap icons in semantic container elements for visibility toggling - Create throttled-button.inc with Template Toolkit BLOCKs to reduce duplication - Extract throttle logic to throttledButton.js with event delegation - Make timeout configurable via data-throttle-timeout attribute - Replace string-based modal generation with template element to support SSR To test: 1) Follow the test plan from the previous commit 2) Additionally verify the throttled button behavior works in all locations: - Reports list table: "Run" button for each saved report - Report toolbar: "Run report" button (when viewing/editing a report) - Parameters form: "Run the report" button - Edit SQL form: "Update and run SQL" button - Preview SQL modal: "Run report" button (click "Preview SQL" in dropdown) 3) For each location, confirm: - Button shows play icon initially - Upon click, button becomes disabled with spinner icon - Button has aria-busy="true" when disabled - After navigation/submission, button state is handled correctly 4) Test the modal button specifically: - Open Preview SQL modal from any report dropdown - Click "Run report" in the modal - Verify throttle behavior works for this dynamically created button 5) Verify that the set timeout works well, I thought 120 seconds is too long if you go back via bfcache (back button in the browser). You'd have to either reload or wait 2 minutes for the button to become interactive again. 6) Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188106|0 |1 is obsolete| | --- Comment #9 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 190457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190457&action=edit Bug 40896: (follow-up) Use icon wrapper elements and visibility toggling - Wrap icons in semantic container elements for visibility toggling - Create throttled-button.inc with Template Toolkit BLOCKs to reduce duplication - Extract throttle logic to throttledButton.js with event delegation - Make timeout configurable via data-throttle-timeout attribute - Replace string-based modal generation with template element to support SSR To test: 1) Follow the test plan from the previous commit 2) Additionally verify the throttled button behavior works in all locations: - Reports list table: "Run" button for each saved report - Report toolbar: "Run report" button (when viewing/editing a report) - Parameters form: "Run the report" button - Edit SQL form: "Update and run SQL" button - Preview SQL modal: "Run report" button (click "Preview SQL" in dropdown) 3) For each location, confirm: - Button shows play icon initially - Upon click, button becomes disabled with spinner icon - Button has aria-busy="true" when disabled - After navigation/submission, button state is handled correctly 4) Test the modal button specifically: - Open Preview SQL modal from any report dropdown - Click "Run report" in the modal - Verify throttle behavior works for this dynamically created button 5) Verify that the set timeout works well, I thought 120 seconds is too long if you go back via bfcache (back button in the browser). You'd have to either reload or wait 2 minutes for the button to become interactive again. 6) Sign off Signed-off-by: Jake Deery <jake.deery@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 --- Comment #10 from Jake Deery <jake.deery@openfifth.co.uk> --- Hi Paul, Sorry, been busy here too. Took a play with the patch today, had to put some effort in to get it to apply cleanly to main, but with that done, I ran through your test plan, and it seems to work for me! I'll run the QA tools against it, but I am happy to sign it off. A shame it didn't make it to 25.11, but it will be amazing to get this into 26.05! Ta, Jake -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi Jake, thanks. Wondered whether I overdid it here a bit, but since this is now an include, it's probably justifiable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Great find from blawlor on that last patch, thanks. The issue was that button elements could be double-toggled when bfcache was involved, the submit handler sets a setTimeout to re-enable the button, and when the page is restored from bfcache both the pageshow handler and the resumed timeout fire, flipping the state twice and leaving the button stuck as disabled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190458|0 |1 is obsolete| | --- Comment #16 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 193008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193008&action=edit Bug 40896: (follow-up) Use icon wrapper elements and visibility toggling - Wrap icons in semantic container elements for visibility toggling - Create throttled-button.inc with Template Toolkit BLOCKs to reduce duplication - Extract throttle logic to throttledButton.js with event delegation - Make timeout configurable via data-throttle-timeout attribute - Replace string-based modal generation with template element to support SSR To test: 1) Follow the test plan from the previous commit 2) Additionally verify the throttled button behavior works in all locations: - Reports list table: "Run" button for each saved report - Report toolbar: "Run report" button (when viewing/editing a report) - Parameters form: "Run the report" button - Edit SQL form: "Update and run SQL" button - Preview SQL modal: "Run report" button (click "Preview SQL" in dropdown) 3) For each location, confirm: - Button shows play icon initially - Upon click, button becomes disabled with spinner icon - Button has aria-busy="true" when disabled - After navigation/submission, button state is handled correctly 4) Test the modal button specifically: - Open Preview SQL modal from any report dropdown - Click "Run report" in the modal - Verify throttle behavior works for this dynamically created button 5) Verify that the set timeout works well, I thought 120 seconds is too long if you go back via bfcache (back button in the browser). You'd have to either reload or wait 2 minutes for the button to become interactive again. 6) Sign off Signed-off-by: Jake Deery <jake.deery@openfifth.co.uk> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #18 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for the quick follow up Paul! This works perfectly now. Testing note: - Button has aria-busy="true" when disabled This is only possible to see if you use Event Listener Breakpoints for beforeunload and unload so you can look at the element before the page refreshes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193007|0 |1 is obsolete| | --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193114&action=edit Bug 40896: Disable run report buttons upon click This patch will disable the run report button found on both the list page, and the individual operation pages (e.g. run, edit, saved successfully). This will stop librarians from unintentionally crashing their Koha system, by pressing the run report button repeatedly when there is no need to re-request it. TO TEST: a) go to /cgi-bin/koha/reports/guided_reports.pl?op=list b) create three new sql test reports: *) Name: Test report #1, SQL: SELECT count(*) FROM biblio *) Name: Test report #2, SQL: SELECT count(*) FROM items *) Name: Test report #3, SQL: SELECT * FROM items WHERE items.dateaccessioned = <<Date accessioned|date>> c) run all of the above test reports, noticing how the run report button can be activated repeatedly APPLY PATCH d) redo step a e) run test report #1 from the table, notice how now the button can only be activated once before it is greyed out and the play button is replaced with a spinner f) return to the list, edit test report #2 from the table, click run report from the edit page, and notice how this run report button exhibits the same behaviour as the button in step e g) return to the list, run test report #3, select a date, click run report from this page, and notice again how the run report button exhibits the same behaviour as the buttons in steps e and f SIGN OFF Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193009|0 |1 is obsolete| | --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193116&action=edit Bug 40896: (follow-up) Fix bfcache double-toggle on form button elements - Track pending reset timeouts in a WeakMap keyed by element - Clear any pending timeout in the pageshow handler before re-enabling - Prevents the resumed setTimeout from re-disabling the button after bfcache restoration Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please add release notes for this one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43016 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43016 [Bug 43016] [OMNIBUS] Server resource protection -- You are receiving this mail because: You are watching all bug changes.