https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40896 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193008|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 193115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193115&action=edit Bug 40896: (follow-up) Use icon wrapper elements and visibility toggling - Wrap icons in semantic container elements for visibility toggling - Create throttled-button.inc with Template Toolkit BLOCKs to reduce duplication - Extract throttle logic to throttledButton.js with event delegation - Make timeout configurable via data-throttle-timeout attribute - Replace string-based modal generation with template element to support SSR To test: 1) Follow the test plan from the previous commit 2) Additionally verify the throttled button behavior works in all locations: - Reports list table: "Run" button for each saved report - Report toolbar: "Run report" button (when viewing/editing a report) - Parameters form: "Run the report" button - Edit SQL form: "Update and run SQL" button - Preview SQL modal: "Run report" button (click "Preview SQL" in dropdown) 3) For each location, confirm: - Button shows play icon initially - Upon click, button becomes disabled with spinner icon - Button has aria-busy="true" when disabled - After navigation/submission, button state is handled correctly 4) Test the modal button specifically: - Open Preview SQL modal from any report dropdown - Click "Run report" in the modal - Verify throttle behavior works for this dynamically created button 5) Verify that the set timeout works well, I thought 120 seconds is too long if you go back via bfcache (back button in the browser). You'd have to either reload or wait 2 minutes for the button to become interactive again. 6) Sign off Signed-off-by: Jake Deery <jake.deery@openfifth.co.uk> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.