[Bug 25624] New: Update patrons category script should allow finding null and not null and wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Bug ID: 25624 Summary: Update patrons category script should allow finding null and not null and wildcards Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The script does not allow to find empty fields or use wildcards It would be helpful to find patrons where a field has been set, or a field not matching, or similar fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105439&action=edit Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category To test: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try running with various fields, matching and not matching 3 - Test null values 4 - Test like values with wildcards 5 - Test like with the word null to find fields containing the word rather than being unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105439|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605&action=edit Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category To test: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try running with various fields, matching and not matching 3 - Test null values 4 - Test like values with wildcards 5 - Test like with the word null to find fields containing the word rather than being unset Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |alex.arnaud@biblibre.com |y.org | CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- Comment on attachment 105605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605 Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category Review of attachment 105605: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25624&attachment=105605) ----------------------------------------------------------------- Can you add pod items for likefield and notlikefield options ? ::: misc/cronjobs/update_patrons_category.pl @@ +135,5 @@
+Use this flag to specify a column in the borrowers table and update only patrons whose value in that column does not equal the value supplied (repeatable) + +e.g. +--notfield email=NULL +will update all patrons with no value for email
all patrons with null email field ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- No a blocker but a concern: not* options work with empty and non-empty values but not with null values. perl misc/cronjobs/update_patrons_category.pl -f S -t B -dn email=foo -v => matches all patrons with email different from "foo" or email eq ''. But not the null ones. Is it the wanted behavior ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Alex Arnaud from comment #3)
+will update all patrons with no value for email
all patrons with null email field ?
I mean: all patron with email different from null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 105605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605 Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category Review of attachment 105605: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25624&attachment=105605) ----------------------------------------------------------------- ::: misc/cronjobs/update_patrons_category.pl @@ +57,5 @@
-ra=date --regafter update if registration date is after a given date -d --dbfield name=value where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value> + -dn --notfield name=value where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value> + -dl --likefield name=value where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value> + -dnl --notlikefield name=value where <name> is a column in the borrowers table, patrons will be updated if the field is equal to given <value>
All three descriptions here match.. can you clarify the descriptions, please.. replacing 'equal' with the relevant comparison? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106965&action=edit Bug 25624: Update documentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Alex Arnaud from comment #5)
(In reply to Alex Arnaud from comment #3)
+will update all patrons with no value for email
all patrons with null email field ?
I mean: all patron with email different from null
=> matches all patrons with email different from "foo" or email eq ''. But not the null ones. Is it the wanted behavior ?
-dn email=null will find all not null -d email=null will find all null I think specifically targeting null differently than blank makes sense as it can have different meanings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105605|0 |1 is obsolete| | --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 107291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107291&action=edit Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category To test: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try running with various fields, matching and not matching 3 - Test null values 4 - Test like values with wildcards 5 - Test like with the word null to find fields containing the word rather than being unset Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106965|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 107292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107292&action=edit Bug 25624: Update documentation Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sorry but I don't think it's ideal. What will happen if we want <, <=, >, <=? Cannot we imagine a parameter that takes the operator? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107291|0 |1 is obsolete| | Attachment #107292|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109116&action=edit Bug 25624: Add 'operator' option to allow for different comparisons This patch adds the option to specify the operators fper field specified in the script We also add support for testing 'null' fields To test: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Add a patron in category PT (or your choice) with email 'a@b.com' 3 - Add a patron in category PT (or as above) with email 'c@d.com' 4 - Try running with options perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=a@b.com (first patron returned) perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=a@b.com -o email=e (first patron returned) perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=a@b.com -o email=gt (both patrons returned) perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=a@b.com -o email=gte (second patron returned) perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=a@b% -o email=l (first patron returned) perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=a@b% -o email=nl (second patron returned) perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=null -o email=e (neither patron returned) perl misc/cronjobs/update_patrons_category.pl -f PT -t s --field email=null -o email=ne (both patrons returned) 5 - Test other combination 6 - Test with --confirm and ensure updates suceed as before patches https://bugs.koha-community.org/show_bug.cgi?id=25264 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107291|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107292|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #11)
I am sorry but I don't think it's ideal. What will happen if we want <, <=, >, <=? Cannot we imagine a parameter that takes the operator?
Running this by our educators and others, they do not like the newer patch. The borrowers table does not have numeric fields where the greater than or less than operators are necessary. The feeling was that offering too many operators added complexity and confusion and would lead to more support issues rather than less. The patches as submitted here cover the use cases requested by the library sponsor and offer flexibility and ease of understanding for setup. Putting this back as passed QA for consideration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109370&action=edit Bug 25624: Add more flexibily with --where and literal search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, can you have a look at this approach and let me know what you think about it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14)
Created attachment 109370 [details] [review] Bug 25624: Add more flexibily with --where and literal search
Looks great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107292|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107291|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109370|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109421&action=edit Bug 25624: Add more flexibily with --where and literal search Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |andrew@bywatersolutions.com --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I get a SQL error whenever I run this without a --where defined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107291|0 |1 is obsolete| | Attachment #107292|0 |1 is obsolete| | Attachment #109421|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109427&action=edit Bug 25624: Add --where option to update_patrons_category.pl The script did not allow to find empty fields or use wildcards With this new option we will now have the ability to filter patrons by some of their attributes. Test plan: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try the script with one or more --where parameters, like: --where "firstname='koha'" 3 - Test null values --where "firstname IS NULL" 4 - Test like values with wildcards --where "firstname LIKE '%a%' 5 - Test like with the word null to find fields containing the word rather than being unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|alex.arnaud@biblibre.com | Assignee|nick@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Now I'm getting a different SQL error when running this with a --where, a --field, or neither: perl misc/cronjobs/update_patrons_category.pl -f PT -t B --where "firstname='koha'" -v No actions will be taken (test mode) Will update patrons from PT to B with conditions below (if any) DBD::mysql::st execute failed: Unknown column 'me.exclude_from_local_holds_priority' in 'field list' [for Statement "SELECT `me`.`categorycode`, `me`.`description`, `me`.`enrolmentperiod`, `me`.`enrolmentperioddate`, `me`.`upperagelimit`, `me`.`dateofbirthrequired`, `me`.`finetype`, `me`.`bulk`, `me`.`enrolmentfee`, `me`.`overduenoticerequired`, `me`.`issuelimit`, `me`.`reservefee`, `me`.`hidelostitems`, `me`.`category_type`, `me`.`BlockExpiredPatronOpacActions`, `me`.`default_privacy`, `me`.`checkprevcheckout`, `me`.`reset_password`, `me`.`change_password`, `me`.`exclude_from_local_holds_priority` FROM `categories` `me` WHERE ( `me`.`categorycode` = ? )" with ParamValues: 0='PT'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.exclude_from_local_holds_priority' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 96 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think you are missing a DB update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109427|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 109440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109440&action=edit Bug 25624: Add --where option to update_patrons_category.pl The script did not allow to find empty fields or use wildcards With this new option we will now have the ability to filter patrons by some of their attributes. Test plan: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try the script with one or more --where parameters, like: --where "firstname='koha'" 3 - Test null values --where "firstname IS NULL" 4 - Test like values with wildcards --where "firstname LIKE '%a%' 5 - Test like with the word null to find fields containing the word rather than being unset Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Whoops, yes. Sorry about that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Fuerste-Henry from comment #23)
Whoops, yes. Sorry about that!
haha, no worries. Thanks Andrew! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109440|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110747&action=edit Bug 25624: Add --where option to update_patrons_category.pl The script did not allow to find empty fields or use wildcards With this new option we will now have the ability to filter patrons by some of their attributes. Test plan: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try the script with one or more --where parameters, like: --where "firstname='koha'" 3 - Test null values --where "firstname IS NULL" 4 - Test like values with wildcards --where "firstname LIKE '%a%' 5 - Test like with the word null to find fields containing the word rather than being unset Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice enhancement, works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Severity|normal |enhancement --- Comment #29 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org