[Bug 26249] New: keep_text class not set inconsistently in cat-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Bug ID: 26249 Summary: keep_text class not set inconsistently in cat-search.inc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In cat-search.inc, the keep_text class should be set on the A elements but the "Search the catalog" is set on the LI element. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 [Bug 26248] Simplify keep_text Javascript function -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 108570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108570&action=edit Bug 26249: Set keep_text class correctly in cat-search.inc This patch sets the keep_text class correctly in cat-search.inc for the "Search the catalog" tab To test: 1) Apply the patch 2) Go to /cgi-bin/koha/catalogue/search.pl 3) Type "A" into the search box for "Search the catalog" 4) Click on the "Check out" tab 5) Note that "A" appears in search box 6) Change "A" to "B" in search box 7) Click on the "Search the catalog" box 8) Note that "B" appears in the search box 9) Note no Javascript errors in the console -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108570|0 |1 is obsolete| | --- Comment #2 from didier <didier.gautheron@biblibre.com> --- Created attachment 110648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110648&action=edit Bug 26249: Set keep_text class correctly in cat-search.inc This patch sets the keep_text class correctly in cat-search.inc for the "Search the catalog" tab To test: 1) Apply the patch 2) Go to /cgi-bin/koha/catalogue/search.pl 3) Type "A" into the search box for "Search the catalog" 4) Click on the "Check out" tab 5) Note that "A" appears in search box 6) Change "A" to "B" in search box 7) Click on the "Search the catalog" box 8) Note that "B" appears in the search box 9) Note no Javascript errors in the console Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110648|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110690&action=edit Bug 26249: Set keep_text class correctly in cat-search.inc This patch sets the keep_text class correctly in cat-search.inc for the "Search the catalog" tab To test: 1) Apply the patch 2) Go to /cgi-bin/koha/catalogue/search.pl 3) Type "A" into the search box for "Search the catalog" 4) Click on the "Check out" tab 5) Note that "A" appears in search box 6) Change "A" to "B" in search box 7) Click on the "Search the catalog" box 8) Note that "B" appears in the search box 9) Note no Javascript errors in the console Signed-off-by: Didier Gautheron <didier.gautheron@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- minor bug/enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org