[Bug 21892] New: Robin Sheat is not a typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Bug ID: 21892 Summary: Robin Sheat is not a typo Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: QA tools Assignee: jonathan.druart@bugs.koha-community.org Reporter: mtompset@hotmail.com While testing a bug, I changed a file with "Robin Sheat" in the comments to a .pl file, and the qa test tools flagged Sheat as a typo. It is unlikely that Sheat as a typo will be used in general comments, so the proposal is to ignore Sheat in the codespell call. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 82680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82680&action=edit Bug 21892: Robin Sheat is not a typo [DON'T PUSH] This adds a a comment to Koha.pm which should: 1) apply this patch 2) run the qa test tools -- it should fail, because it thinks Sheat is not spelled correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 82681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82681&action=edit Bug 21892: Purposeful typo [DO NOT PUSH] This combined with the former patch gives an intentionally set of words incorrectly spelled. 1) apply the first two patches 2) run qa test tools -- Yes, it should find the bad spellings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 82682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82682&action=edit Bug 21892: Ignore Sheat when checking spelling 1) without this patch applied to your qa-test-tools run the test plans for the first two patches -- both should fail, with just 1 applied, and both applied to your kohaclone. 2) apply this patch to your qa-test-tools 3) rerun the test plans for the first two patches -- just 1 applied should now pass, but both applied should still fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |mtompset@hotmail.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Robin Sheat <robin@kallisti.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@kallisti.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just ignore false messages? We might end up adding all names.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marcel de Rooy from comment #4)
Just ignore false messages? We might end up adding all names..
If there are more names, then we could change it to -I filename. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #6 from Robin Sheat <robin@kallisti.net.nz> --- (In reply to Marcel de Rooy from comment #4)
Just ignore false messages? We might end up adding all names..
There aren't cases as special as me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed, note that I did not get the complain with "abbout" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #7)
Pushed, note that I did not get the complain with "abbout"
If you look at the default dictionary for codespell, there is a sheat entry. There is no abbout entry. Hence the lack of noise. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests are failing, -L does not exist in 1.6 (jessie) and 1.8 (stretch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #9)
Tests are failing, -L does not exist in 1.6 (jessie) and 1.8 (stretch)
Even after a: pip install codespell ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #9)
Tests are failing, -L does not exist in 1.6 (jessie) and 1.8 (stretch)
Had similar issues with -L not existing in my base Ubuntu Bionic. sudo apt remove codespell sudo pip uninstall codespell sudo pip install codespell All seems good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #9)
Tests are failing, -L does not exist in 1.6 (jessie) and 1.8 (stretch)
Confirmed that tests are falsely passing spelling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 85571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85571&action=edit Bug 21892: Purposefully update codespell This detects if codespell has -L option, and if not, it purposefully uninstalls it, and then installs the version it needs via 'pip install'. It also tweaks the detection of codespell installation. Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would not expect a script to remove/install packages without asking anything. I warning message with the detailed steps sounds better to me. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 86572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86572&action=edit Bug 21892: Add prompt for CodeSpell update TEST PLAN --------- Now you can say no, get the spelling error. Say yes, and the spelling error goes away. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is just complexifying everything for... what exactly? I am ok with "Sheat" being a typo, really. I am sure Robin will not mind much. I still think that display 3 lines to explain what's need to update to the new version is the best and easiest way to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch reverted. commit db31f7e3380b43ce09798b50ddc5ffd1b17b8836 Revert "Bug 21892: Ignore Sheat when checking spelling" This reverts commit 4e076f26417827494c87677b1d4f3e36ed2f2369. Tests were failing, see also bug 21892 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no Status|Needs Signoff |Failed QA --- Comment #18 from Magnus Enger <magnus@libriotech.no> --- Looks like the main patch here was pushed, then reverted. If that is correct, the status should probably not be NSO. Resetting to FQA. Feel free to correct me. :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Too much time spent on this, won't fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #20 from Robin Sheat <robin@kallisti.net.nz> --- :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #21 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #4)
Just ignore false messages? We might end up adding all names..
Ignoring false messages sounds reasonable to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Robin Sheat from comment #20)
:(
Note that I did not mark it "invalid" ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #22)
(In reply to Robin Sheat from comment #20)
:(
Note that I did not mark it "invalid" ;)
😂 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org