[Bug 23281] New: Add Koha::Objects::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Bug ID: 23281 Summary: Add Koha::Objects::Limit::Library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Add a generic class that can be used to add ->search_with_library_limits method to classes that already rely on Koha::Object::Limit::Library, but handle searching with limits manually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17755 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91415&action=edit Bug 23281: Add Koha::Objects::Limit::Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91416&action=edit Bug 23281: Implement ->search_with_library_limits in Koha::Patron::Attribute::Types This patch makes Koha::Patron::Attribute::Types inherit from Koha::Objects::Limit::Library so it now has the ->search_with_library_limits method. Tests are adjusted so it is clear that there is no behaviour change compared to the (previsouly) called ->search To test: - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests still pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91417&action=edit Bug 23281: Cleanup Koha::Patron::Attribute::Types->search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com Blocks| |23272, 23271 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Note to testers: Koha::Patron::Attribute::Tyes->search is not actually used in the code. It should be used for getting rid of C4::AttributeTypes. Once we have a clear idea about this patchset, this tasks could be done easily during this release cycle. I have already filed bug 23272 and bug 23271, that would benefit from this dev. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91415|0 |1 is obsolete| | Attachment #91416|0 |1 is obsolete| | Attachment #91417|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91459&action=edit Bug 23281: Add Koha::Objects::Limit::Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91460&action=edit Bug 23281: Implement ->search_with_library_limits in Koha::Patron::Attribute::Types This patch makes Koha::Patron::Attribute::Types inherit from Koha::Objects::Limit::Library so it now has the ->search_with_library_limits method. Tests are adjusted so it is clear that there is no behaviour change compared to the (previsouly) called ->search To test: - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91461&action=edit Bug 23281: Cleanup Koha::Patron::Attribute::Types->search Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91459|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92337&action=edit Bug 23281: Add Koha::Objects::Limit::Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91460|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92338&action=edit Bug 23281: Implement ->search_with_library_limits in Koha::Patron::Attribute::Types This patch makes Koha::Patron::Attribute::Types inherit from Koha::Objects::Limit::Library so it now has the ->search_with_library_limits method. Tests are adjusted so it is clear that there is no behaviour change compared to the (previsouly) called ->search To test: - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91461|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92339&action=edit Bug 23281: Cleanup Koha::Patron::Attribute::Types->search Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 [Bug 15497] Limit Item Types by Branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15497 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 [Bug 15497] Limit Item Types by Branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 [Bug 15497] Limit Item Types by Branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 [Bug 23599] Koha::Objects::Limit::Library fails if no library passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org