https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29975 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 129962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129962&action=edit Bug 29976: (Bug 21729 followup) fix holds unit tests Bug 21729 added to holds table the column patron_expiration_date. Currently test suite is failing : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/516/testR... We must fix where TestBuilder is creating with source Reserve and data expirationdate : t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t Note that t/db_dependent/Reserves/CancelExpiredReserves.t does not fail without this patch but surely we prefere change it also. Test plan : prove t/db_dependent/Holds/WaitingReserves.t prove t/db_dependent/Reserves/CancelExpiredReserves.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129962|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 129969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129969&action=edit Bug 29976: (Bug 21729 followup) fix holds unit tests Bug 21729 added to holds table the column patron_expiration_date. Currently test suite is failing : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/516/testR... We must fix where TestBuilder is creating with source Reserve and data expirationdate : t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t Note that t/db_dependent/Reserves/CancelExpiredReserves.t does not fail without this patch but surely we prefere change it also. Test plan : prove t/db_dependent/Holds/WaitingReserves.t prove t/db_dependent/Reserves/CancelExpiredReserves.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129969|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129989&action=edit Bug 29976: (Bug 21729 followup) fix holds unit tests Bug 21729 added to holds table the column patron_expiration_date. Currently test suite is failing : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/516/testR... We must fix where TestBuilder is creating with source Reserve and data expirationdate : t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t Note that t/db_dependent/Reserves/CancelExpiredReserves.t does not fail without this patch but surely we prefere change it also. Test plan : prove t/db_dependent/Holds/WaitingReserves.t prove t/db_dependent/Reserves/CancelExpiredReserves.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.