[Bug 24993] New: koha-sip --restart is too fast, doesn't always start sip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Bug ID: 24993 Summary: koha-sip --restart is too fast, doesn't always start sip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Sometimes doing koha-sip --restart inst happens too fast and start sip doesn't start it. A pause in there to let SIP catch up would probably fix it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 101876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101876&action=edit Bug 24993: add a pause between stopping and starting sip on restart To test: - have SIP enabled and running - issue a restart, make sure it restarts. sudo koha-sip --restart inst -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101876|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 102255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102255&action=edit Bug 24993: add a pause between stopping and starting sip on restart To test: - have SIP enabled and running - issue a restart, make sure it restarts. sudo koha-sip --restart inst Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102280&action=edit Bug 24993: Make sure SIP server is stopped before restarting it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |wizzyrea@gmail.com |ity.org | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Liz, what about this patch? I think "sleeping 3" is too arbitrary. We may need to add a max number of iterations to avoid looping forever (in case something went wrong). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102280|Bug 24993: Make sure SIP |[ALTERNATIVE-PATCH] Bug description|server is stopped before |24993: Make sure SIP server |restarting it |is stopped before | |restarting it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- I tried it with sleep 1 it was still to fast on some machines! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- I don't know that I have an opinion about this, if you think your way is better I'll sign off on that. I do like the idea of a limit, if we have to do it this way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102546&action=edit Bug 24993: Make sure we are not going to loop indefinitely -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Hi Jonathan, I just tested this in my devbox, I'd get into the loop but every test I did, sip didn't get started after it stopped. I'll try to troubleshoot it but if you can immediately see what's wrong, happy for a fix. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102255|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 102648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102648&action=edit Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102648|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102682&action=edit Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102280|0 |1 is obsolete| | Attachment #102546|0 |1 is obsolete| | Attachment #102682|0 |1 is obsolete| | --- Comment #11 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 102752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102752&action=edit Attachment to Bug 24993 - koha-sip --restart is too fast, doesn't always start sip Bug 24993: Make sure SIP server is stopped before restarting it Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102752|0 |1 is obsolete| | --- Comment #12 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 102753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102753&action=edit Attachment to Bug 24993 - koha-sip --restart is too fast, doesn't always start sip Bug 24993: Make sure SIP server is stopped before restarting it Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102753|0 |1 is obsolete| | --- Comment #13 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 102754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102754&action=edit Bug 24993: Make sure SIP server is stopped before restarting it Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #14 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 102755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102755&action=edit Bug 24993: Make sure we are not going to loop indefinitely Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #15 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 102756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102756&action=edit Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The latest iteration of these patches is missing test plans and descriptions? Can you remind me where I need to copy the files for testing with kohadevbox? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-sip --restart is too |koha-sip --restart is too |fast, doesn't always start |fast, doesn't always start |sip |SIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The test plan is the same as the original one. You need to restart the SIP server using koha-sip --restart, and makes sure is has been restarted (without this patch, it does not always). you can `reset_all` (which will call cp_debian_files.pl from misc4dev), or simply copy it to /usr/sbin/koha-sip (`which koha-sip` helps you to find it). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #17)
The test plan is the same as the original one.
I was referring to the fact, that there is nothing in the commit messages now, also it seems to have been there in early iterations? I'll readd it, but it's extra work I'd like to avoid :)
You need to restart the SIP server using koha-sip --restart, and makes sure is has been restarted (without this patch, it does not always).
you can `reset_all` (which will call cp_debian_files.pl from misc4dev), or simply copy it to /usr/sbin/koha-sip (`which koha-sip` helps you to find it).
Thx, exactly what I needed to know! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102754|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102823&action=edit Bug 24993: Make sure SIP server is stopped before restarting it Sometimes doing koha-sip --restart instance happens too fast and the SIP server is not started. To test: - have SIP enabled and running for your instance - issue a restart, make sure it restarts sudo koha-sip --restart inst Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102755|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102824&action=edit Bug 24993: Make sure we are not going to loop indefinitely Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102756|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102825&action=edit Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #23 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24991 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org